Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix glTF vertex colors #1123

Merged
merged 2 commits into from
Mar 30, 2021
Merged

Fix glTF vertex colors #1123

merged 2 commits into from
Mar 30, 2021

Conversation

ctrlaltdavid
Copy link
Collaborator

Implements support for glTF normalized values.

Testing:

@ctrlaltdavid ctrlaltdavid linked an issue Mar 28, 2021 that may be closed by this pull request
GLTF vertex colors from Blender 2.91 broken #957
Closed
@vircadia-build-notifier
Copy link

The following links are available:
build (macOS-latest, full)

build (ubuntu-18.04, full)

build (windows-latest, full)

build (ubuntu-18.04, android)

@digisomni digisomni added CR Approved At least one code reviewer has approved the PR. and removed needs CR (code review) labels Mar 29, 2021
@digisomni digisomni added this to the 2021.1.1 Eos Release milestone Mar 29, 2021
@SilverfishVR
Copy link
Contributor

Screenshot 2021-03-29 16 30 36

Looks good to me 👍 Thanks' for the fix.

Colorspace is still off so #302 is still relevant.

@Aitolda
Copy link
Collaborator

Aitolda commented Mar 30, 2021

\Colorspace is still off so #302 is still relevant.

Seems to do the trick. I'm not certain that it's the gltf that's off at this point but possibly fbx. The gltf seems truer to the colors in blender. Also as an added bonus gltf doesn't smear together the colors when adding vertex color to a face in blender.

fe8eb173cbe20a19cd308607170f9224
GLTF on Left. Fbx on right.

@digisomni digisomni added QA Approved The PR has been tested successfully. and removed needs testing (QA) The PR is ready for testing labels Mar 30, 2021
@digisomni digisomni merged commit edf835e into vircadia:master Mar 30, 2021
@ctrlaltdavid ctrlaltdavid deleted the fix/gltf-vertex-colors branch March 30, 2021 22:20
@SilverfishVR SilverfishVR mentioned this pull request Mar 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HifiExperiments HifiExperiments HifiExperiments approved these changes

Assignees
No one assigned
Labels
bugfix CR Approved At least one code reviewer has approved the PR. QA Approved The PR has been tested successfully.
Projects
None yet
Milestone
2021.1.1 Eos Release
Development

Successfully merging this pull request may close these issues.

GLTF vertex colors from Blender 2.91 broken
6 participants
@ctrlaltdavid @vircadia-build-notifier @SilverfishVR @Aitolda @HifiExperiments @digisomni