Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix glTF mesh colors #1181

Merged
merged 2 commits into from
Apr 24, 2021
Merged

Fix glTF mesh colors #1181

merged 2 commits into from
Apr 24, 2021

Conversation

ctrlaltdavid
Copy link
Collaborator

This change makes the colors in the color test FBX and glTF models in #957 appear to render consistently. And the glTF models' colors render the same when viewed in Windows' 3D Viewer.

However, the change makes the colors in the FBX and glTF palm tree models in #302 render very differently.

Testing needed!

@ctrlaltdavid ctrlaltdavid added needs testing (QA) The PR is ready for testing bugfix labels Apr 17, 2021
@vircadia-build-notifier
Copy link

The following links are available:
build (ubuntu-18.04, full)

build (macOS-latest, full)

build (ubuntu-18.04, android)

build (windows-latest, full)

@SilverfishVR
Copy link
Contributor

Testing PR1181-3ebfe50

The color panels from #957 looks correct to 👍

As for the palms, I think that is material related, the fbx palm is fully metallic whereas the glb one is not at all, it is well known issue the fbx models with no metallic map uses the albedo channel instead, maybe no material equals wall white.
Screenshot 2021-04-17 20 05 18
the framebuffer shows metallic value.
left is glb, middle is fbx, and right is same fbx but loaded as non-metal using this fst: https://silverfish-freestuff.s3.eu-north-1.amazonaws.com/TestStuff/vertexColorPanel/fbxPalm_nonMetal.fst and to me it looks the same as glb.

@ctrlaltdavid ctrlaltdavid linked an issue Apr 18, 2021 that may be closed by this pull request
colorspace issues with gltf/glb format #302
Closed
@digisomni digisomni added this to the 2021.1.2 Eos Release milestone Apr 19, 2021
@Aitolda
Copy link
Collaborator

Aitolda commented Apr 19, 2021 •
edited
Loading

So it's interesting. Using Silverfishes method I do indeed get identical looking models, However with a new export for the fbx using a solid black texture for metallic I still wind up with a darker color. So this PR is working perfectly, but we have a problem with blender's metallic export on fbx even when using a texture. I was under the impression the issue was only when using the slider to set your metallic.

@vircadia-build-notifier
Copy link

The following links are available:
build (ubuntu-18.04, full)

build (macOS-latest, full)

build (macOS-latest, client)

build (windows-latest, full)

build (ubuntu-18.04, android)

@digisomni digisomni added renderer Touches or changes rendering QA Approved The PR has been tested successfully. and removed needs testing (QA) The PR is ready for testing labels Apr 22, 2021
@digisomni digisomni removed the request for review from HifiExperiments April 24, 2021 17:39
@digisomni digisomni added CR Approved At least one code reviewer has approved the PR. and removed needs CR (code review) labels Apr 24, 2021
@daleglass daleglass merged commit c7e79a5 into vircadia:master Apr 24, 2021
@ctrlaltdavid ctrlaltdavid deleted the fix/gltf-colors branch April 24, 2021 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daleglass daleglass daleglass approved these changes

Assignees
No one assigned
Labels
bugfix CR Approved At least one code reviewer has approved the PR. QA Approved The PR has been tested successfully. renderer Touches or changes rendering
Projects
None yet
Milestone
2021.1.2 Eos Release
Development

Successfully merging this pull request may close these issues.

colorspace issues with gltf/glb format
6 participants
@ctrlaltdavid @vircadia-build-notifier @SilverfishVR @Aitolda @daleglass @digisomni