refactor: Update azure-aci to use nodeutil instead of node-cli #411

helayoty · 2023-01-05T01:45:12Z

Move away from the node-cli library and use the built-in nodeutil package from virtual-kubelet instead.
Use the new virtual-kubelet version, v1.8.0.
Upgrade Kubernetes version to v1.26.0
- Update Liveness/ReadinessProbe (Prope -> PropeHandler)

Update the old PR #277

Signed-off-by: Heba Elayoty hebaelayoty@gmail.com

codecov-commenter · 2023-01-05T02:05:37Z

Codecov Report

Merging #411 (77a6af7) into master (0c76852) will increase coverage by 2.32%.
The diff coverage is 47.10%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #411      +/-   ##
==========================================
+ Coverage   42.91%   45.23%   +2.32%     
==========================================
  Files          50       15      -35     
  Lines        5735     2465    -3270     
==========================================
- Hits         2461     1115    -1346     
+ Misses       3017     1265    -1752     
+ Partials      257       85     -172

Impacted Files	Coverage Δ
pkg/featureflag/feature_flag.go	`75.00% <ø> (+20.00%)`	⬆️
pkg/provider/podsTracker.go	`0.00% <0.00%> (ø)`
pkg/network/aci_network.go	`20.43% <7.74%> (-6.10%)`	⬇️
pkg/auth/auth.go	`60.32% <44.68%> (-6.35%)`	⬇️
pkg/metrics/metrics.go	`73.33% <55.00%> (-3.42%)`	⬇️
pkg/provider/aci_volumes.go	`45.19% <62.50%> (ø)`
pkg/provider/aci.go	`44.41% <63.20%> (+10.52%)`	⬆️
pkg/provider/containergroup_to_pod.go	`71.93% <75.80%> (-3.35%)`	⬇️
pkg/analytics/analytics.go	`64.70% <100.00%> (ø)`
pkg/provider/config.go	`68.29% <100.00%> (ø)`
... and 5 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

cmd/virtual-kubelet/context.go

pkg/provider/aci.go

pkg/tests/utils.go

pkg/provider/podsTracker.go

pkg/provider/aci_volumes_test.go

pkg/provider/aci_test.go

go.mod

Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>

helayoty added the kind/refactor label Jan 5, 2023

helayoty requested a review from Fei-Guo as a code owner January 5, 2023 01:45

helayoty temporarily deployed to test January 5, 2023 01:45 — with GitHub Actions Inactive

helayoty force-pushed the nodeutil-migration branch from d5d857d to 5085c20 Compare January 5, 2023 02:01

helayoty temporarily deployed to test January 5, 2023 02:01 — with GitHub Actions Inactive

helayoty force-pushed the nodeutil-migration branch from 5085c20 to fcdb79b Compare January 5, 2023 02:36

helayoty temporarily deployed to test January 5, 2023 02:36 — with GitHub Actions Inactive

helayoty force-pushed the nodeutil-migration branch from fcdb79b to 1980aeb Compare January 10, 2023 00:51

helayoty temporarily deployed to test January 10, 2023 00:51 — with GitHub Actions Inactive

cpuguy83 reviewed Jan 17, 2023

View reviewed changes

cmd/virtual-kubelet/context.go Outdated Show resolved Hide resolved

cpuguy83 reviewed Jan 17, 2023

View reviewed changes

pkg/provider/aci.go Outdated Show resolved Hide resolved

helayoty force-pushed the nodeutil-migration branch from 1980aeb to 26a0a6f Compare January 18, 2023 21:20

helayoty temporarily deployed to test January 18, 2023 21:20 — with GitHub Actions Inactive

helayoty temporarily deployed to test January 18, 2023 21:27 — with GitHub Actions Inactive

helayoty temporarily deployed to test January 18, 2023 21:29 — with GitHub Actions Inactive

helayoty force-pushed the nodeutil-migration branch from 134adad to c59ba68 Compare January 18, 2023 21:37

helayoty temporarily deployed to test January 18, 2023 21:37 — with GitHub Actions Inactive

helayoty temporarily deployed to test January 18, 2023 21:38 — with GitHub Actions Inactive

helayoty force-pushed the nodeutil-migration branch from c59ba68 to 76025e7 Compare January 24, 2023 17:39

helayoty temporarily deployed to test January 24, 2023 17:39 — with GitHub Actions Inactive

helayoty temporarily deployed to test January 24, 2023 17:40 — with GitHub Actions Inactive

helayoty force-pushed the nodeutil-migration branch from 76025e7 to 210515a Compare January 24, 2023 20:20

helayoty temporarily deployed to test January 24, 2023 20:20 — with GitHub Actions Inactive

helayoty temporarily deployed to test March 16, 2023 16:28 — with GitHub Actions Inactive

helayoty force-pushed the nodeutil-migration branch from a0c36d2 to 92b0eb6 Compare March 16, 2023 17:03

helayoty temporarily deployed to test March 16, 2023 17:03 — with GitHub Actions Inactive

helayoty force-pushed the nodeutil-migration branch from 92b0eb6 to e5b6812 Compare March 16, 2023 17:41

helayoty temporarily deployed to test March 16, 2023 17:41 — with GitHub Actions Inactive

Fei-Guo reviewed Mar 16, 2023

View reviewed changes

pkg/tests/utils.go Show resolved Hide resolved

pkg/provider/podsTracker.go Outdated Show resolved Hide resolved

pkg/provider/aci_volumes_test.go Outdated Show resolved Hide resolved

pkg/provider/aci_test.go Outdated Show resolved Hide resolved

go.mod Show resolved Hide resolved

helayoty temporarily deployed to test March 16, 2023 21:35 — with GitHub Actions Inactive

helayoty mentioned this pull request Mar 16, 2023

Remove a unused labels #485

Open

helayoty force-pushed the nodeutil-migration branch from 72501d0 to 78ed26e Compare March 16, 2023 21:49

helayoty temporarily deployed to test March 16, 2023 21:49 — with GitHub Actions Inactive

helayoty force-pushed the nodeutil-migration branch from 78ed26e to 1faa25e Compare March 16, 2023 21:50

helayoty temporarily deployed to test March 16, 2023 21:51 — with GitHub Actions Inactive

helayoty force-pushed the nodeutil-migration branch from 1faa25e to 8a7db9a Compare March 16, 2023 21:55

helayoty temporarily deployed to test March 16, 2023 21:55 — with GitHub Actions Inactive

helayoty added 2 commits March 16, 2023 15:39

Update azure-aci to use nodeutil instead of node-cli

ca9fed2

Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>

Code review comments

afd8ae7

Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>

helayoty force-pushed the nodeutil-migration branch from 8a7db9a to afd8ae7 Compare March 16, 2023 22:40

helayoty temporarily deployed to test March 16, 2023 22:40 — with GitHub Actions Inactive

helayoty requested a review from Fei-Guo March 16, 2023 22:47

Fei-Guo approved these changes Mar 16, 2023

View reviewed changes

helayoty merged commit 3b58bc0 into virtual-kubelet:master Mar 16, 2023

helayoty deleted the nodeutil-migration branch March 16, 2023 23:14

helayoty mentioned this pull request Mar 16, 2023

Update azure-aci K8s API version to 1.24. #361

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: Update azure-aci to use nodeutil instead of node-cli #411

refactor: Update azure-aci to use nodeutil instead of node-cli #411

helayoty commented Jan 5, 2023 •

edited

Loading

codecov-commenter commented Jan 5, 2023 •

edited

Loading

refactor: Update azure-aci to use nodeutil instead of node-cli #411

refactor: Update azure-aci to use nodeutil instead of node-cli #411

Conversation

helayoty commented Jan 5, 2023 • edited Loading

codecov-commenter commented Jan 5, 2023 • edited Loading

Codecov Report

helayoty commented Jan 5, 2023 •

edited

Loading

codecov-commenter commented Jan 5, 2023 •

edited

Loading