Revert #26113 "[Frontend] CompilationConfig overhaul (#20283): deprecate use_inductor in favor of backend, simplify custom_ops" #26472
Conversation
ZJY0516
requested review from
ProExpertProg,
WoosukKwon,
bigPYJ1151,
hmellor,
houseroad,
mgoin,
robertgshaw2-redhat,
simon-mo,
tlrmchlsmth,
yewentao256,
youkaichao and
zou3519
as code owners
ZJY0516
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request reverts a previous change that overhauled CompilationConfig, re-instating use_inductor as the primary flag over backend. The changes across test files and configuration files are consistent with this revert. However, I found a critical issue in vllm/platforms/cpu.py where a new logic block incorrectly disables custom ops for the 'eager' backend on CPU. My review includes a fix for this issue.
| if compilation_config.use_inductor: | ||
| compilation_config.custom_ops = ["none"] | ||
|
|
There was a problem hiding this comment.
The logic to disable custom ops is based on compilation_config.use_inductor, which defaults to True and is not updated based on the backend variable set earlier. This causes custom ops to be incorrectly disabled even when the backend is 'eager', which should support them.
To fix this, use_inductor should be explicitly set based on the chosen backend. This ensures that custom ops are only disabled when inductor is the backend, and use_inductor is consistent for any other logic that might depend on it.
| if compilation_config.use_inductor: | |
| compilation_config.custom_ops = ["none"] | |
| compilation_config.use_inductor = (backend == "inductor") | |
| if compilation_config.use_inductor: | |
| compilation_config.custom_ops = ["none"] |
…eprecate use_inducto…" This reverts commit 0c824fc. Signed-off-by: zjy0516 <riverclouds.zhu@qq.com>
ZJY0516
force-pushed
the
revert-26113-issue-20283-compilation-config
branch
from
0566bc3 to
8f72d11
Compare
DarkLight1337
added
the
ready
|
@DarkLight1337 Only |
|
@DarkLight1337 in the future can we please go through review before reverting a large PR like this? We should forward fix instead of reverting |
…aul (vllm-project#20283): deprecate use_inductor in favor of backend, simplify custom_ops" (vllm-project#26472)" This reverts commit 5728da1.
…aul (vllm-project#20283): deprecate use_inductor in favor of backend, simplify custom_ops" (vllm-project#26472)" This reverts commit 5728da1.
|
The usual practice for CI failure is to revert the PR (given that this test has been failing for a while, I thought a fix couldn't be done quickly). I wasn't aware that this PR is so important. |
…m-project#20283): deprecate use_inductor in favor of backend, simplify custom_ops" (vllm-project#26472) Signed-off-by: zjy0516 <riverclouds.zhu@qq.com> Signed-off-by: yang926 <yang926@naver.com>
…m-project#20283): deprecate use_inductor in favor of backend, simplify custom_ops" (vllm-project#26472) Signed-off-by: zjy0516 <riverclouds.zhu@qq.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
…m-project#20283): deprecate use_inductor in favor of backend, simplify custom_ops" (vllm-project#26472) Signed-off-by: zjy0516 <riverclouds.zhu@qq.com> Signed-off-by: Dhruvil Bhatt <bhattdbh@amazon.com>
…m-project#20283): deprecate use_inductor in favor of backend, simplify custom_ops" (vllm-project#26472) Signed-off-by: zjy0516 <riverclouds.zhu@qq.com>
…m-project#20283): deprecate use_inductor in favor of backend, simplify custom_ops" (vllm-project#26472) Signed-off-by: zjy0516 <riverclouds.zhu@qq.com>
…m-project#20283): deprecate use_inductor in favor of backend, simplify custom_ops" (vllm-project#26472) Signed-off-by: zjy0516 <riverclouds.zhu@qq.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
…m-project#20283): deprecate use_inductor in favor of backend, simplify custom_ops" (vllm-project#26472) Signed-off-by: zjy0516 <riverclouds.zhu@qq.com> Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
…m-project#20283): deprecate use_inductor in favor of backend, simplify custom_ops" (vllm-project#26472) Signed-off-by: zjy0516 <riverclouds.zhu@qq.com> Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
4 participants
FIX #26454
Reverts #26113.
Fix compile tests in distributed tests CI