-
-
Notifications
You must be signed in to change notification settings - Fork 11k
[compile] Fix inductor partition config #26645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: angelayi <yiangela7@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly fixes a bug in the inductor partition configuration. The is_attention_compiled_piecewise method was previously checking self.backend == "inductor", which would incorrectly evaluate to false when the default backend (an empty string) is used with inductor. The change to check self.use_inductor is the correct approach, as this flag accurately indicates whether inductor compilation is enabled. This resolves the assertion error described in the pull request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, bad merge of #25845 after #26113 was reverted in #26472. @morrison-turnansky can you fix in #26502?
|
@ProExpertProg yes, will do |
Signed-off-by: angelayi <yiangela7@gmail.com> Signed-off-by: 1994 <1994@users.noreply.github.com>
Signed-off-by: angelayi <yiangela7@gmail.com> Signed-off-by: Dhruvil Bhatt <bhattdbh@amazon.com>
Signed-off-by: angelayi <yiangela7@gmail.com> Signed-off-by: bbartels <benjamin@bartels.dev>
Signed-off-by: angelayi <yiangela7@gmail.com>
Signed-off-by: angelayi <yiangela7@gmail.com>
Signed-off-by: angelayi <yiangela7@gmail.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Signed-off-by: angelayi <yiangela7@gmail.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Signed-off-by: angelayi <yiangela7@gmail.com> Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
Signed-off-by: angelayi <yiangela7@gmail.com> Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
When trying to run the following cmd, I ran into this assertion error because self.backend is equal to
"".cc @ProExpertProg @zou3519 @BoyuanFeng @baonudesifeizhai