[Frontend] CompilationConfig overhaul (#20283): deprecate use_inductor in favor of backend, simplify custom_ops #26113

morrison-turnansky · 2025-10-02T17:22:53Z

Reverted in #26472, unrevert in #26502.

Purpose

update custom_ops, backend, and use_inductor refactor as discussed in #20283 (comment)

Test Plan

Test Result

Essential Elements of an Effective PR Description Checklist

The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
The test plan, such as providing test command.
The test results, such as pasting the results comparison before and after, or e2e results
(Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
(Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

github-actions · 2025-10-02T17:24:17Z

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors.

You ask your reviewers to trigger select CI tests on top of fastcheck CI.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

If you have any questions, please reach out to us on Slack at https://slack.vllm.ai.

🚀

ProExpertProg

This is overall the right approach, I just threw a bunch of nits on this (it is a cleanup so we should try to simplify and clarify as much as possible)

vllm/compilation/backends.py

vllm/config/compilation.py

vllm/model_executor/custom_op.py

vllm/platforms/cpu.py

vllm/config/compilation.py

ProExpertProg

Looks good apart from nits!

vllm/config/compilation.py

vllm/config/vllm.py

vllm/config/compilation.py

vllm/config/vllm.py

mergify · 2025-10-06T13:48:45Z

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @morrison-turnansky.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

Signed-off-by: morrison-turnansky <mturnans@redhat.com>

…custom_ops source of truth for default behaviour of Custom Ops Signed-off-by: morrison-turnansky <mturnans@redhat.com>

Signed-off-by: morrison-turnansky <mturnans@redhat.com>

Chenyaaang · 2025-10-08T23:17:10Z

vllm/config/vllm.py

+        ):
+            if (
+                self.compilation_config.level > 0
+                and self.compilation_config.backend != "eager"


I wonder with this setting, if the backend isn't eager, we will always use forward_native for all platforms, is this the expected behavior? @morrison-turnansky

@Chenyaaang yes I think so. If platforms are using a custom backend AND want custom ops enabled, they should override config in the platform.check_and_update_config.

… use_inductor in favor of backend, simplify custom_ops (vllm-project#26113) Signed-off-by: morrison-turnansky <mturnans@redhat.com> Signed-off-by: Morrison Turnansky <mturnans@redhat.com> Signed-off-by: Luka Govedič <ProExpertProg@users.noreply.github.com> Co-authored-by: Luka Govedič <ProExpertProg@users.noreply.github.com> Co-authored-by: Jiangyun Zhu <riverclouds.zhu@qq.com>

…ate use_inductor in favor of backend, simplify custom_ops" (#26472) Signed-off-by: zjy0516 <riverclouds.zhu@qq.com>

…aul (vllm-project#20283): deprecate use_inductor in favor of backend, simplify custom_ops" (vllm-project#26472)" This reverts commit 5728da1.

mergify · 2025-10-09T15:49:11Z

⚠️ The sha of the head commit of this PR conflicts with #26502. Mergify cannot evaluate rules on this PR. ⚠️

…m-project#20283): deprecate use_inductor in favor of backend, simplify custom_ops" (vllm-project#26472) Signed-off-by: zjy0516 <riverclouds.zhu@qq.com> Signed-off-by: yang926 <yang926@naver.com>

mergify · 2025-10-10T01:27:22Z

⚠️ The sha of the head commit of this PR conflicts with #26502. Mergify cannot evaluate rules on this PR. ⚠️

mergify · 2025-10-10T01:28:38Z

⚠️ The sha of the head commit of this PR conflicts with #26502. Mergify cannot evaluate rules on this PR. ⚠️

… use_inductor in favor of backend, simplify custom_ops (vllm-project#26113) Signed-off-by: morrison-turnansky <mturnans@redhat.com> Signed-off-by: Morrison Turnansky <mturnans@redhat.com> Signed-off-by: Luka Govedič <ProExpertProg@users.noreply.github.com> Co-authored-by: Luka Govedič <ProExpertProg@users.noreply.github.com> Co-authored-by: Jiangyun Zhu <riverclouds.zhu@qq.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>

…m-project#20283): deprecate use_inductor in favor of backend, simplify custom_ops" (vllm-project#26472) Signed-off-by: zjy0516 <riverclouds.zhu@qq.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>

… use_inductor in favor of backend, simplify custom_ops (vllm-project#26113) Signed-off-by: morrison-turnansky <mturnans@redhat.com> Signed-off-by: Morrison Turnansky <mturnans@redhat.com> Signed-off-by: Luka Govedič <ProExpertProg@users.noreply.github.com> Co-authored-by: Luka Govedič <ProExpertProg@users.noreply.github.com> Co-authored-by: Jiangyun Zhu <riverclouds.zhu@qq.com> Signed-off-by: Dhruvil Bhatt <bhattdbh@amazon.com>

…m-project#20283): deprecate use_inductor in favor of backend, simplify custom_ops" (vllm-project#26472) Signed-off-by: zjy0516 <riverclouds.zhu@qq.com> Signed-off-by: Dhruvil Bhatt <bhattdbh@amazon.com>

… use_inductor in favor of backend, simplify custom_ops (vllm-project#26113) Signed-off-by: morrison-turnansky <mturnans@redhat.com> Signed-off-by: Morrison Turnansky <mturnans@redhat.com> Signed-off-by: Luka Govedič <ProExpertProg@users.noreply.github.com> Co-authored-by: Luka Govedič <ProExpertProg@users.noreply.github.com> Co-authored-by: Jiangyun Zhu <riverclouds.zhu@qq.com>

…m-project#20283): deprecate use_inductor in favor of backend, simplify custom_ops" (vllm-project#26472) Signed-off-by: zjy0516 <riverclouds.zhu@qq.com>

… use_inductor in favor of backend, simplify custom_ops (vllm-project#26113) Signed-off-by: morrison-turnansky <mturnans@redhat.com> Signed-off-by: Morrison Turnansky <mturnans@redhat.com> Signed-off-by: Luka Govedič <ProExpertProg@users.noreply.github.com> Co-authored-by: Luka Govedič <ProExpertProg@users.noreply.github.com> Co-authored-by: Jiangyun Zhu <riverclouds.zhu@qq.com>

…m-project#20283): deprecate use_inductor in favor of backend, simplify custom_ops" (vllm-project#26472) Signed-off-by: zjy0516 <riverclouds.zhu@qq.com>

… use_inductor in favor of backend, simplify custom_ops (vllm-project#26113) Signed-off-by: morrison-turnansky <mturnans@redhat.com> Signed-off-by: Morrison Turnansky <mturnans@redhat.com> Signed-off-by: Luka Govedič <ProExpertProg@users.noreply.github.com> Co-authored-by: Luka Govedič <ProExpertProg@users.noreply.github.com> Co-authored-by: Jiangyun Zhu <riverclouds.zhu@qq.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>

…m-project#20283): deprecate use_inductor in favor of backend, simplify custom_ops" (vllm-project#26472) Signed-off-by: zjy0516 <riverclouds.zhu@qq.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>

…m-project#20283): deprecate use_inductor in favor of backend, simplify custom_ops" (vllm-project#26472) Signed-off-by: zjy0516 <riverclouds.zhu@qq.com> Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>

mergify bot added the llama Related to Llama models label Oct 2, 2025

morrison-turnansky changed the title ~~Issue 20283 compilation config~~ [Frontend] Issue 20283 compilation config Oct 2, 2025

morrison-turnansky force-pushed the issue-20283-compilation-config branch from 83aebbf to 3373dd7 Compare October 2, 2025 17:45

morrison-turnansky marked this pull request as ready for review October 2, 2025 18:01

morrison-turnansky requested review from ProExpertProg, WoosukKwon, bigPYJ1151, hmellor, houseroad, mgoin, robertgshaw2-redhat, simon-mo, tlrmchlsmth, yewentao256, youkaichao and zou3519 as code owners October 2, 2025 18:01

ProExpertProg reviewed Oct 2, 2025

View reviewed changes

morrison-turnansky force-pushed the issue-20283-compilation-config branch from ce8edb6 to 3bffb71 Compare October 3, 2025 16:47

morrison-turnansky requested a review from ProExpertProg October 3, 2025 17:37

ProExpertProg approved these changes Oct 3, 2025

View reviewed changes

vllm/config/compilation.py Outdated Show resolved Hide resolved

vllm/config/vllm.py Outdated Show resolved Hide resolved

ZJY0516 reviewed Oct 5, 2025

View reviewed changes

vllm/config/compilation.py Show resolved Hide resolved

ZJY0516 reviewed Oct 5, 2025

View reviewed changes

vllm/config/vllm.py Outdated Show resolved Hide resolved

mergify bot added the needs-rebase label Oct 6, 2025

morrison-turnansky added 5 commits October 6, 2025 13:52

added deprecation warning for use_inductor in CompilationConfig

617967a

Signed-off-by: morrison-turnansky <mturnans@redhat.com>

added logic for init_backend to take in backend information

367c600

Signed-off-by: morrison-turnansky <mturnans@redhat.com>

removed use_inductor from code paths

cfe2f95

Signed-off-by: morrison-turnansky <mturnans@redhat.com>

added all as default for custom_ops field in CompilitionConfig, made …

e6726da

…custom_ops source of truth for default behaviour of Custom Ops Signed-off-by: morrison-turnansky <mturnans@redhat.com>

updated test_enabled_ops

f17d95d

Signed-off-by: morrison-turnansky <mturnans@redhat.com>

ProExpertProg mentioned this pull request Oct 7, 2025

[Frontend][torch.compile] CompilationConfig Overhaul (#20283): name change compilation level to compilation mode, deprecation compilation level #26355

Merged

5 tasks

simon-mo disabled auto-merge October 7, 2025 19:53

simon-mo merged commit 0c824fc into vllm-project:main Oct 7, 2025
49 of 51 checks passed

Chenyaaang reviewed Oct 8, 2025

View reviewed changes

Chenyaaang mentioned this pull request Oct 9, 2025

[TPU] Fix tpu torch compile error #26453

Closed

ZJY0516 mentioned this pull request Oct 9, 2025

Revert #26113 "[Frontend] CompilationConfig overhaul (#20283): deprecate use_inductor in favor of backend, simplify custom_ops" #26472

Merged

vllm-bot pushed a commit that referenced this pull request Oct 9, 2025

Revert #26113 "[Frontend] CompilationConfig overhaul (#20283): deprec…

5728da1

…ate use_inductor in favor of backend, simplify custom_ops" (#26472) Signed-off-by: zjy0516 <riverclouds.zhu@qq.com>

morrison-turnansky mentioned this pull request Oct 9, 2025

[FrontEnd] UNREVERT CompilationConfig overhaul (#20283): deprecate use_inductor in favor of backend, simplify custom_ops #26502

Merged

5 tasks

hmellor mentioned this pull request Oct 9, 2025

[CI] Fix mypy for vllm/attention and vllm/compilation #26482

Open

ProExpertProg mentioned this pull request Oct 11, 2025

[compile] Fix inductor partition config #26645

Merged

ProExpertProg linked an issue Nov 3, 2025 that may be closed by this pull request

[RFC][UX][torch.compile][CUDAGraph]: Overhaul CompilationConfig and improve CLI -O<n> #20283

Open

1 task

Uh oh!

[Frontend] CompilationConfig overhaul (#20283): deprecate use_inductor in favor of backend, simplify custom_ops #26113

[Frontend] CompilationConfig overhaul (#20283): deprecate use_inductor in favor of backend, simplify custom_ops #26113

Uh oh!

Conversation

morrison-turnansky commented Oct 2, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose

Test Plan

Test Result

Uh oh!

github-actions bot commented Oct 2, 2025

Uh oh!

ProExpertProg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ProExpertProg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mergify bot commented Oct 6, 2025

Uh oh!

Uh oh!

Chenyaaang Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ProExpertProg Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

mergify bot commented Oct 9, 2025

Uh oh!

mergify bot commented Oct 10, 2025

Uh oh!

mergify bot commented Oct 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

morrison-turnansky commented Oct 2, 2025 •

edited by github-actions bot

Loading

Chenyaaang Oct 8, 2025 •

edited

Loading