Skip to content

Conversation

@DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Oct 16, 2025

Purpose

Part of #26900

  • vllm.utils.import_from_path -> vllm.utils.import_utils.import_from_path
  • vllm.utils.resolve_obj_by_qualname -> vllm.utils.import_utils.resolve_obj_by_qualname
  • vllm.utils.get_vllm_optional_dependencies -> vllm.utils.import_utils.get_vllm_optional_dependencies
  • vllm.utils.PlaceholderModule -> vllm.utils.import_utils.PlaceholderModule
  • vllm.utils.LazyLoader -> vllm.utils.import_utils.LazyLoader

Originally I thought about moving the _has_module-based functions here as well, but I decided they are better suited to be grouped with pytorch utils.

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@russellb
Copy link
Member

looks like you have a doc build error:

WARNING -  mkdocs_autorefs: api/vllm/utils/import_utils.md: from /home/docs/checkouts/readthedocs.org/user_builds/vllm/checkouts/27022/vllm/utils/import_utils.py:67: (vllm.utils.import_utils._PlaceholderBase) Could not find cross-reference target 'vllm.utils._PlaceholderBase.__getattr__'

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337
Copy link
Member Author

Fixed

@njhill
Copy link
Member

njhill commented Oct 16, 2025

How about vllm.utils.imports?

@DarkLight1337
Copy link
Member Author

DarkLight1337 commented Oct 16, 2025

Renaming to import_utils since it causes conflicts with the std importlib library

Because of this I think we need to rename the other utils as well. Let's do that in another PR. Any suggestions on names?

Copy link
Member

@yewentao256 yewentao256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the work!

@njhill
Copy link
Member

njhill commented Oct 16, 2025

Renaming to import_utils since it causes conflicts with the std importlib library

Because of this I think we need to rename the other utils as well. Let's do that in another PR. Any suggestions on names?

The clash is with importlib though right? imports should be ok I think?

May be personal preference but I think vllm.utils.abc is better than vllm.utils.abc_utils.

@DarkLight1337 DarkLight1337 merged commit 4d4d6ba into vllm-project:main Oct 17, 2025
65 checks passed
@DarkLight1337 DarkLight1337 deleted the separate-utils-importlib branch October 17, 2025 00:49
@DarkLight1337
Copy link
Member Author

I am referring to the other utils like vllm.utils.asyncio and vllm.utils.functools

Zhuul pushed a commit to Zhuul/vllm that referenced this pull request Oct 17, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
xuechendi pushed a commit to vllm-project/vllm-gaudi that referenced this pull request Oct 18, 2025
Culprit commit: vllm-project/vllm#27022

---------

Signed-off-by: Agata Dobrzyniewicz <adobrzyniewicz@habana.ai>
lywa1998 pushed a commit to lywa1998/vllm that referenced this pull request Oct 20, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
albertoperdomo2 pushed a commit to albertoperdomo2/vllm that referenced this pull request Oct 23, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: Alberto Perdomo <aperdomo@redhat.com>
alhridoy pushed a commit to alhridoy/vllm that referenced this pull request Oct 24, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
hlahkar pushed a commit to hlahkar/vllm-gaudi that referenced this pull request Oct 24, 2025
Culprit commit: vllm-project/vllm#27022

---------

Signed-off-by: Agata Dobrzyniewicz <adobrzyniewicz@habana.ai>
wangxiyuan pushed a commit to vllm-project/vllm-ascend that referenced this pull request Oct 24, 2025
### What this PR does / why we need it?
This is the step 1 of refactoring code to adapt with vllm main, and this
pr aligned with
vllm-project/vllm@17c540a

1. refactor deepseek to the latest code arch as of
vllm-project/vllm@17c540a
 
2. bunches of fixes due to vllm changes
- Fix `AscendScheduler` `__post_init__`, caused by
vllm-project/vllm#25075
- Fix `AscendScheduler` init got an unexpected arg `block_size`, caused
by vllm-project/vllm#26296
- Fix `KVCacheManager` `get_num_common_prefix_blocks` arg, caused by
vllm-project/vllm#23485
- Fix `MLAAttention` import,caused by
vllm-project/vllm#25103
- Fix `SharedFusedMoE` import, caused by
vllm-project/vllm#26145
- Fix `LazyLoader` improt, caused by
vllm-project/vllm#27022
- Fix `vllm.utils.swap_dict_values` improt, caused by
vllm-project/vllm#26990
- Fix `Backend` enum import, caused by
vllm-project/vllm#25893
- Fix `CompilationLevel` renaming to `CompilationMode` issue introduced
by vllm-project/vllm#26355
- Fix fused_moe ops, caused by
vllm-project/vllm#24097
- Fix bert model because of `inputs_embeds`, caused by
vllm-project/vllm#25922
- Fix MRope because of `get_input_positions_tensor` to
`get_mrope_input_positions`, caused by
vllm-project/vllm#24172
- Fix `splitting_ops` changes introduced by
vllm-project/vllm#25845
- Fix multi-modality changes introduced by
vllm-project/vllm#16229
- Fix lora bias dropping issue introduced by
vllm-project/vllm#25807
- Fix structured ouput break introduced by
vllm-project/vllm#26737

### Does this PR introduce _any_ user-facing change?

### How was this patch tested?
CI passed with existing test.


- vLLM version: v0.11.0rc3
- vLLM main: https://github.com/vllm-project/vllm/commit/v0.11.0

---------

Signed-off-by: MengqingCao <cmq0113@163.com>
Signed-off-by: Icey <1790571317@qq.com>
Co-authored-by: Icey <1790571317@qq.com>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 24, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: xuebwang-amd <xuebwang@amd.com>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 24, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: xuebwang-amd <xuebwang@amd.com>
0xrushi pushed a commit to 0xrushi/vllm that referenced this pull request Oct 26, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
0xrushi pushed a commit to 0xrushi/vllm that referenced this pull request Oct 26, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend multi-modality Related to multi-modality (#4194) performance Performance-related issues ready ONLY add when PR is ready to merge/full CI is needed structured-output tool-calling v1

Projects

Status: Done
Status: Done

Development

Successfully merging this pull request may close these issues.

7 participants