[Misc] Move utils to avoid conflicts with stdlib, and move tests #27169
+246
−237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
DarkLight1337
added
the
ready
DarkLight1337
requested review from
22quinn,
NickLucche,
aarnphm,
alexm-redhat,
chaunceyjiang,
comaniac,
jeejeelee,
mgoin,
njhill,
robertgshaw2-redhat,
sighingnow,
tlrmchlsmth,
yewentao256,
youkaichao,
ywang96 and
zhuohan123
as code owners
mergify
bot
added
deepseek
Isotr0py
approved these changes
Oct 19, 2025
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
vllm/vllm/utils/async_utils.py
Line 1 in ce8952f
Provide compatibility shim for renamed util modules
The commit renames vllm.utils.asyncio, vllm.utils.collections, and vllm.utils.functools to async_utils, collection_utils, and func_utils respectively, but the old module paths are removed entirely. Any user code importing vllm.utils.asyncio (or the others) will now raise ImportError even though the functionality is unchanged. Unless a breaking change is intended, consider keeping lightweight stub modules or adding aliases in vllm.utils.__getattr__ so the legacy paths continue to resolve (ideally with a deprecation warning).
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
DarkLight1337
changed the title
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
jeejeelee
approved these changes
Oct 19, 2025
lywa1998
pushed a commit
to lywa1998/vllm
that referenced
this pull request
Oct 20, 2025
…m-project#27169) Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
adabeyta
pushed a commit
to adabeyta/vllm
that referenced
this pull request
Oct 20, 2025
…m-project#27169) Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
This was referenced Oct 23, 2025
albertoperdomo2
pushed a commit
to albertoperdomo2/vllm
that referenced
this pull request
Oct 23, 2025
…m-project#27169) Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> Signed-off-by: Alberto Perdomo <aperdomo@redhat.com>
wangxiyuan
pushed a commit
to vllm-project/vllm-ascend
that referenced
this pull request
Oct 25, 2025
### What this PR does / why we need it? Upgrade to new vllm commit: vllm-project/vllm@c9461e0 - Fix many imports, caused by vllm-project/vllm#26908 - Fix import ```sha256```, caused by vllm-project/vllm#27169 - Remove ```SchedulerConfig.send_delta_data```, caused by vllm-project/vllm#27142 - Fix ```FusedMoE``` because of dual stream execution, caused by vllm-project/vllm#26440 ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? CI passed with new added/existing test. - vLLM version: v0.11.0rc3 - vLLM main: vllm-project/vllm@17c540a --------- Signed-off-by: MengqingCao <cmq0113@163.com> Signed-off-by: Icey <1790571317@qq.com> Co-authored-by: MengqingCao <cmq0113@163.com>
liziyu179
pushed a commit
to nwpu-zxr/vllm-ascend
that referenced
this pull request
Oct 25, 2025
### What this PR does / why we need it? Upgrade to new vllm commit: vllm-project/vllm@c9461e0 - Fix many imports, caused by vllm-project/vllm#26908 - Fix import ```sha256```, caused by vllm-project/vllm#27169 - Remove ```SchedulerConfig.send_delta_data```, caused by vllm-project/vllm#27142 - Fix ```FusedMoE``` because of dual stream execution, caused by vllm-project/vllm#26440 ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? CI passed with new added/existing test. - vLLM version: v0.11.0rc3 - vLLM main: vllm-project/vllm@17c540a --------- Signed-off-by: MengqingCao <cmq0113@163.com> Signed-off-by: Icey <1790571317@qq.com> Co-authored-by: MengqingCao <cmq0113@163.com> Signed-off-by: nwpu-zxr <zhouxuerong2@huawei.com>
0xrushi
pushed a commit
to 0xrushi/vllm
that referenced
this pull request
Oct 26, 2025
…m-project#27169) Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
0xrushi
pushed a commit
to 0xrushi/vllm
that referenced
this pull request
Oct 26, 2025
…m-project#27169) Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
vllm.utils.asyncio -> vllm.utils.async_utilsvllm.utils.collections -> vllm.utils.collection_utilsvllm.utils.functools -> vllm.utils.func_utilsAlso split out tests from
tests/test_utils.py.Based on #27022 (comment)
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.