Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vector extension simx without testcases #201

Open
wants to merge 136 commits into
base: master
Choose a base branch
from

Conversation

MichaelJSr
Copy link
Contributor

Massive thanks to Troibe for his amazing work on the vector extension!

This is a fork of his work that has been updated to be up-to-date with the master branch, as well as adding regression testing, a bit more debug logging, and a few other modifications.

This PR has the vector testcases removed due to their large size.

- vrsub.vi
- vand.vi
- vor.vi
- vxor.vi
- vsll.vi
- vsrl.vi
- vsra.vi
- vsub.vx
- vrsub.vx
- vminu.vx
- vmin.vx
- vmaxu.vx
- vmax.vx
- vand.vx
- vor.vx
- vxor.vx
- vsll.vx
- vsrl.vx
- vsra.vx
- vmulhu.vx
- vmul.vx
- vmulh.vx
- vadd.vv
- vsub.vv
- vminu.vv
- vmin.vv
- vmaxu.vv
- vmax.vv
- vand.vv
- vor.vv
- vxor.vv
- vsll.vv
- vsrl.vv
- vsra.vv
- vfmin.vv
- vfmax.vv
- vfcvt.f.x.v, vfcvt.x.f.v
- vfrec7.v, vfrsqrt7.v
- vredsum.vs
- vredor.vs
- vmseq.vv
- vmsne.vv
- vmsltu.vv
- vmslt.vv
- vmsleu.vv
- vmsle.vv
- vmsgtu.vv
- vmsgt.vv
- vmandn.mm
- vmand.mm
- vmor.mm
- vmxor.mm
- vmorn.mm
- vmnand.mm
- vmnor.mm
- vmxnor.mm
fix an include

add f32_recip7 and include header in rvfloats
Update softfloat_ext.cpp

Added softfloat_ext.cpp to Makefiles
Revert "Update softfloat_ext.cpp"

This reverts commit 215623a.
vector isa regression test changes

vector isa regression test changes

riscv-vector include changes
Update VX_csr_unit.sv

riscv vector regression test edits
Update VX_csr_unit.sv

Update VX_csr_unit.sv

Update VX_csr_unit.sv
@troibe
Copy link
Contributor

troibe commented Nov 3, 2024

Great, so Hyesoon wanted to upload the test cases on dropbox instead of GitHub releases.
Let's wait until that is done and integrate it in the test script then.

I think we generally want the fallback order to be:

  1. Copy locally generated testcases from the submodule if available
  2. Use existing testcases (from submodule or downloaded) if available
  3. Download testcases

I saw that you commented out the line for copying over the test cases.
Did that lead to issues for you? If yes let's try to resolve these...
The user should be able to regenerate the test cases themselves if they want to.

@MichaelJSr
Copy link
Contributor Author

Sorry I did not have any issues with the line for copying over testcases, I will go ahead and uncomment it out. The fallback order makes sense, let me know if there are any other changes you would like me to make!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants