Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add definitions required for triple terms #30

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

domel
Copy link
Contributor

@domel domel commented Sep 4, 2024

@pfps
Copy link
Contributor

pfps commented Sep 4, 2024

This PR seems to be running somewhat in advance of WG decisions?

@gkellogg
Copy link
Member

gkellogg commented Sep 4, 2024

This PR seems to be running somewhat in advance of WG decisions?

It is a Draft, so could just be anticipating that this will be adopted, but I agree that it may still be premature, as semantics could go in a different direction.

@domel
Copy link
Contributor Author

domel commented Sep 4, 2024

Yes, this is a draft. I've only added one class. Properties are waiting to see how the discussion goes.

@niklasl
Copy link

niklasl commented Dec 16, 2024

It sounds good to update this PR to track where we're at. How about re-titling it to "Add definitions required for triple terms"?

I think defining rdf:reifies makes sense at this point. And its range rdf:Proposition (or rdfs:Proposition), which we're converging upon as the class of resources that triple terms denote. It's not finalized, but the more concrete, the easier to judge its sensibility.

In Turtle, I'm thinking:

rdf:reifies a rdf:Property ;
    rdfs:domain rdfs:Resource ;
    rdfs:range rdf:Proposition ;
    rdfs:label "reifies"@en ;
    rdfs:comment "The abstract proposition of a more concrete circumstance."@en .

rdf:Proposition a rdfs:Class ;
    rdfs:label "proposition"@en ;
    rdfs:comment "An atomic, logical, abstract proposition."@en .

(See also w3c/rdf-concepts#115 and w3c/rdf-semantics#49 for additional properties relating a proposition to its constituents (in "classicized" and and symmetric RDF respectively). They may end up being defined elsewhere, so I don't think we can add those in this PR. Note that these referenced issues also need updates to reflect this recent convergence.)

@domel domel changed the title rdf:ReificationProperty added Add definitions required for triple terms Dec 17, 2024
@domel
Copy link
Contributor Author

domel commented Dec 17, 2024

Thank you for the feedback and suggestions. I have updated the PR as proposed and re-titled it to "Add definitions required for triple terms".

@domel domel requested review from gkellogg and niklasl and removed request for gkellogg December 17, 2024 11:46
@domel domel marked this pull request as ready for review December 17, 2024 11:47
@domel
Copy link
Contributor Author

domel commented Dec 17, 2024

See PR #31

spec/index.html Outdated Show resolved Hide resolved

<section id="ch_proposition">
<h3>rdf:Proposition</h3>
<p><code>rdf:Proposition</code> is the class of reified triples.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update this to the definition in the RDF representation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a PR for RDF Representation, I will handle this in a couple of days.

@domel domel requested a review from niklasl December 19, 2024 10:33
Copy link
Member

@TallTed TallTed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small things, improving markup

@@ -409,6 +410,23 @@ <h3>rdf:type</h3>
href="#ch_class"><code>rdfs:Class</code></a>.</p>
</section>

<section id="ch_reifies">
<h3>rdf:reifies</h3>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<h3>rdf:reifies</h3>
<h3><code>rdf:reifies</code></h3>

Comment on lines +419 to +421
<p>states that R is an instance of <a href="#ch_resource"><code>rdfs:Resource</code></a>
and reifies the triple term <code>&lt;&lt;S P O&gt;&gt;</code>, where S, P, and O represent
the subject, predicate, and object of the reified triple, respectively. The object
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that the R, S, P, and O variables should be tagged to set them apart from the surrounding text, whether <em>, <code>, or otherwise. (And that similar tagging should be applied to other places where there's a <code>-tagged sequence that is then deconstructed.) I'm applying <em> here, as that is what was applied in the ill-fated w3c/rdf-semantics/#52

Suggested change
<p>states that R is an instance of <a href="#ch_resource"><code>rdfs:Resource</code></a>
and reifies the triple term <code>&lt;&lt;S P O&gt;&gt;</code>, where S, P, and O represent
the subject, predicate, and object of the reified triple, respectively. The object
<p>states that <em>R</em> is an instance of <a href="#ch_resource"><code>rdfs:Resource</code></a>
and reifies the triple term <code>&lt;&lt;S P O&gt;&gt;</code>, where <em>S</em>, <em>P</em>, and <em>O</em> represent
the subject, predicate, and object of the reified triple, respectively. The object

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you can use |R| (or <var>R</var>) for variables, and if in an element tagged "algorithm", it will highlight all the places the variable is used (within that element), at least in the Editor's Draft. The main thing is to be consistent

Comment on lines +425 to +426
<code>rdf:reifies</code> is <a href="#ch_resource"><code>rdfs:Resource</code></a>.
The <a href="#ch_range"><code>rdfs:range</code></a> of rdf:reifies is
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<code>rdf:reifies</code> is <a href="#ch_resource"><code>rdfs:Resource</code></a>.
The <a href="#ch_range"><code>rdfs:range</code></a> of rdf:reifies is
<code>rdf:reifies</code> is <a href="#ch_resource"><code>rdfs:Resource</code></a>.
The <a href="#ch_range"><code>rdfs:range</code></a> of <code>rdf:reifies</code> is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants