-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add common math types and cleanup printf includes #44
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't C already have a math.h
? Is that handled by including <>
vs ""
? Cause if so that feels like a lot of unnecessary confusion
handled by making our include path to src/common, so you have to import using |
The lazy part of me thinks we should give all our headers unique names so that we can just add all include paths and include directly. Regardless, I think |
making the header name is one solution. I think using directory paths as diy namespacing is more elegant and maybe more common. Latest change: everything is inlucded relative to src/, so |
The EKF also uses matrices of multiple sizes, and the state/measurement/input vectors are also larger than the 3d or quaternion. Do they need to be defined as well? Most of this is just internal in the task |
Ohh and as I said once or twice before, you should really really really look at CORDIC for the STM32. The H7 has an accelerator onboard and it would speed up a lot of computations in the model by a lot, all the trig and exponents etc... And: maybe FMAC also helps, again the H7 has an accelerator. Don't know exactly what it does, if only convolution it doesn't really help, but maybe it can do matrix multiplication/transpose/inverse, which would be awesome |
those all seem very stateestimation-specific so idt its common enough to be part of this common lib? I was thinking abt making a general "N size vector" type but thats just more complicated than necessary |
doing this will be part of stateest implementation, thanks for reminidng (again lol) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
#41
idk if this makes things too convoluted, otherwise we could make stateest module define these types and everyone else (ie just controller rn i think) import from there. but i feel like that's kinda eh cuz state est didnt invent the idea of vectors...?