-
-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: diagnosable modules #4924
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
github-actions
bot
added
the
release: feature
release: feature related release(mr only)
label
Dec 6, 2023
This was referenced Dec 6, 2023
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
github-actions
bot
added
the
team
The issue/pr is created by the member of Rspack.
label
Dec 6, 2023
h-a-n-a
force-pushed
the
12-06-feat_diagnosable_modules
branch
from
December 6, 2023 08:30
c438b64
to
8bee308
Compare
h-a-n-a
force-pushed
the
12-04-refactor_io_errors
branch
from
December 6, 2023 08:34
0143b8b
to
0e70ef1
Compare
h-a-n-a
force-pushed
the
12-06-feat_diagnosable_modules
branch
from
December 6, 2023 08:34
8bee308
to
4f6bdb0
Compare
h-a-n-a
force-pushed
the
12-04-refactor_io_errors
branch
from
December 6, 2023 17:41
0e70ef1
to
a5b1bed
Compare
h-a-n-a
force-pushed
the
12-06-feat_diagnosable_modules
branch
from
December 6, 2023 17:41
4f6bdb0
to
106514c
Compare
h-a-n-a
force-pushed
the
12-04-refactor_io_errors
branch
from
December 7, 2023 09:57
a5b1bed
to
c046417
Compare
h-a-n-a
force-pushed
the
12-06-feat_diagnosable_modules
branch
from
December 7, 2023 09:57
106514c
to
3bacb8c
Compare
h-a-n-a
force-pushed
the
12-04-refactor_io_errors
branch
from
December 7, 2023 10:21
c046417
to
0894cfe
Compare
h-a-n-a
force-pushed
the
12-06-feat_diagnosable_modules
branch
from
December 7, 2023 10:21
3bacb8c
to
4eafe62
Compare
h-a-n-a
force-pushed
the
12-04-refactor_io_errors
branch
from
December 7, 2023 10:58
0894cfe
to
b50e77a
Compare
h-a-n-a
force-pushed
the
12-06-feat_diagnosable_modules
branch
2 times, most recently
from
December 7, 2023 13:40
dc282b0
to
23c5ddb
Compare
h-a-n-a
force-pushed
the
12-04-refactor_io_errors
branch
2 times, most recently
from
December 8, 2023 03:55
0bb3bf9
to
62886d7
Compare
h-a-n-a
force-pushed
the
12-06-feat_diagnosable_modules
branch
from
December 8, 2023 03:55
23c5ddb
to
4afbd9a
Compare
h-a-n-a
force-pushed
the
12-04-refactor_io_errors
branch
from
December 8, 2023 06:08
7109327
to
c55a30c
Compare
h-a-n-a
force-pushed
the
12-06-feat_diagnosable_modules
branch
3 times, most recently
from
December 11, 2023 06:27
f58828a
to
3fdf86d
Compare
Test Compatibility Diff
Unpassed tests
|
h-a-n-a
force-pushed
the
12-06-feat_diagnosable_modules
branch
from
December 18, 2023 07:05
3fdf86d
to
8e982fd
Compare
github-actions
bot
removed
the
release: feature
release: feature related release(mr only)
label
Dec 18, 2023
h-a-n-a
requested review from
IWANABETHATGUY,
ScriptedAlchemy,
LingyuCoder and
jerrykingxyz
December 18, 2023 10:07
ahabhgk
approved these changes
Dec 18, 2023
#3103, this is a good start for removing |
This was referenced Dec 19, 2023
ahabhgk
pushed a commit
that referenced
this pull request
Jan 2, 2024
* feat: diagnosable modules * save * improve * improve
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Aligns Rspack's module error with Webpack's.
Added trait
Diagnosable
for diagnostics.See how webpack did this
Test Plan
Require Documentation?