Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LazyLoad: Add external web platform tests for the "loading" attribute. #14914

Merged
merged 1 commit into from
Jul 12, 2019

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jan 17, 2019

This CL includes tests for:

  • Testing that images and iframes with the attribute loading="lazy" are
    deferred until they come into view
  • Testing that images and iframes with the attribute loading="eager" are
    loaded immediately

Bug: 916260
Change-Id: I323faa31c7683663d0d0136a719cf83c25758ad6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1417117
Commit-Queue: Dominic Farolino <dom@chromium.org>
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676804}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1417117 branch 2 times, most recently from 3b29d61 to b6b0fd5 Compare June 22, 2019 01:50
@chromium-wpt-export-bot chromium-wpt-export-bot changed the title LazyLoad: Add external web platform tests for the lazyload attribute. LazyLoad: Add external web platform tests for the "loading" attribute. Jun 22, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1417117 branch 2 times, most recently from 6f16773 to 8230c5d Compare July 9, 2019 02:18
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1417117 branch 2 times, most recently from 00d84a6 to 39546ea Compare July 12, 2019 08:04
This CL includes tests for:
- Testing that images and iframes with the attribute loading="lazy" are
  deferred until they come into view
- Testing that images and iframes with the attribute loading="eager" are
  loaded immediately

Bug: 916260
Change-Id: I323faa31c7683663d0d0136a719cf83c25758ad6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1417117
Commit-Queue: Dominic Farolino <dom@chromium.org>
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676804}
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 9919d0f into master Jul 12, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1417117 branch July 12, 2019 09:35
annevk added a commit to whatwg/html that referenced this pull request Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants