LazyLoad: Merge scroll.html into image-loading-lazy.tentative.html #20634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Dec 5, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1952868
branch
2 times, most recently
from
720e0af
to
a211252
Compare
The two tests do the same thing but scroll.html checks for placeholder, so move that functionality into image-loading-lazy.tentative.html and remove scroll.html. Bug: 1031157 Change-Id: Id0b15fb1a2866933ecaa072a10f4fbc8655d033c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952868 Commit-Queue: Rob Buis <rbuis@igalia.com> Reviewed-by: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#723286}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1952868
branch
from
a211252
to
15c3991
Compare
annevk
added a commit
to whatwg/html
that referenced
this pull request
Feb 12, 2020
Follow-up: #5236. Tests: * web-platform-tests/wpt#14914 * web-platform-tests/wpt#17985 * web-platform-tests/wpt#18087 * web-platform-tests/wpt#20634 * web-platform-tests/wpt#20747 * web-platform-tests/wpt#20683 * web-platform-tests/wpt#20774 * web-platform-tests/wpt#20680 * Some as part of https://bugzilla.mozilla.org/show_bug.cgi?id=1542784 Closes #2806. Closes #5250. Co-authored-by: Dominic Farolino <domfarolino@gmail.com> Co-authored-by: Anne van Kesteren <annevk@annevk.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two tests do the same thing but scroll.html checks for placeholder, so move
that functionality into image-loading-lazy.tentative.html and remove scroll.html.
Bug: 1031157
Change-Id: Id0b15fb1a2866933ecaa072a10f4fbc8655d033c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952868
Commit-Queue: Rob Buis <rbuis@igalia.com>
Reviewed-by: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#723286}