LazyLoad: add WPT test for invisible in-viewport lazy images #20747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Dec 12, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1962261
branch
5 times, most recently
from
0232779
to
4c87b64
Compare
Add WPT test for invisible in-viewport lazy images and clean up invisible-image.tentative.html as well. Bug: 956559 Change-Id: I26ba797fc8fcd3bd82f861c3b1578ab28fb93490 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962261 Commit-Queue: Rob Buis <rbuis@igalia.com> Reviewed-by: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#724821}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1962261
branch
from
4c87b64
to
5dd8efd
Compare
|
Existing flake (https://bugs.chromium.org/p/chromium/issues/detail?id=1033475), merging |
annevk
added a commit
to whatwg/html
that referenced
this pull request
Feb 12, 2020
Follow-up: #5236. Tests: * web-platform-tests/wpt#14914 * web-platform-tests/wpt#17985 * web-platform-tests/wpt#18087 * web-platform-tests/wpt#20634 * web-platform-tests/wpt#20747 * web-platform-tests/wpt#20683 * web-platform-tests/wpt#20774 * web-platform-tests/wpt#20680 * Some as part of https://bugzilla.mozilla.org/show_bug.cgi?id=1542784 Closes #2806. Closes #5250. Co-authored-by: Dominic Farolino <domfarolino@gmail.com> Co-authored-by: Anne van Kesteren <annevk@annevk.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add WPT test for invisible in-viewport lazy images and clean up
invisible-image.tentative.html as well.
Bug: 956559
Change-Id: I26ba797fc8fcd3bd82f861c3b1578ab28fb93490
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962261
Commit-Queue: Rob Buis <rbuis@igalia.com>
Reviewed-by: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#724821}