Stop conservatively rejecting none/normal/auto on newer <custom-ident> values. #36561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 19, 2022
…> values. In w3c/csswg-drafts#7431 the CSS Working Group resolved not to try to restrict none/normal/auto keywords, so there's no need to reject them to avoid worsening potential compatibility problems. Based on specs at https://drafts.csswg.org/css-contain-3/#container-name and https://drafts.csswg.org/css-contain-3/#container-rule, this adjusts ConsumeSingleContainerName to accept 'normal' and instead reject 'none'. Fixed: 1340852 Change-Id: I53b78e412b0797210c1b5463401bcc055f7bd550 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3966666 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: David Baron <dbaron@chromium.org> Cr-Commit-Position: refs/heads/main@{#1061600}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3966666
branch
from
94c6c5a
to
cdb2593
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In w3c/csswg-drafts#7431 the CSS Working Group
resolved not to try to restrict none/normal/auto keywords, so there's no
need to reject them to avoid worsening potential compatibility problems.
Based on specs at https://drafts.csswg.org/css-contain-3/#container-name
and https://drafts.csswg.org/css-contain-3/#container-rule, this adjusts
ConsumeSingleContainerName to accept 'normal' and instead reject 'none'.
Fixed: 1340852
Change-Id: I53b78e412b0797210c1b5463401bcc055f7bd550
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3966666
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: David Baron <dbaron@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1061600}