Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop conservatively rejecting none/normal/auto on newer <custom-ident> values. #36561

Merged
merged 1 commit into from
Oct 20, 2022
Merged

Stop conservatively rejecting none/normal/auto on newer <custom-ident> values. #36561

merged 1 commit into from
Oct 20, 2022

Commits on Oct 20, 2022

  1. Stop conservatively rejecting none/normal/auto on newer <custom-ident… 

    …> values.

In w3c/csswg-drafts#7431 the CSS Working Group
resolved not to try to restrict none/normal/auto keywords, so there's no
need to reject them to avoid worsening potential compatibility problems.

Based on specs at https://drafts.csswg.org/css-contain-3/#container-name
and https://drafts.csswg.org/css-contain-3/#container-rule, this adjusts
ConsumeSingleContainerName to accept 'normal' and instead reject 'none'.

Fixed: 1340852
Change-Id: I53b78e412b0797210c1b5463401bcc055f7bd550
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3966666
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: David Baron <dbaron@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1061600}
    @dbaron @chromium-wpt-export-bot
    dbaron authored and chromium-wpt-export-bot committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    cdb2593 View commit details
    Browse the repository at this point in the history