Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop conservatively rejecting none/normal/auto on newer <custom-ident> values. #36561

Merged
merged 1 commit into from
Oct 20, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions css/css-contain/container-queries/at-container-parsing.html
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,10 @@
test_container_name_valid('foo');
test_container_name_valid(' foo');
test_container_name_valid(' foo ');
test_container_name_valid('normal');
test_container_name_valid('Normal');
test_container_name_valid('auto');
test_container_name_valid('Auto');

test_container_name_invalid('foo foo');
test_container_name_invalid('1px');
Expand All @@ -175,12 +179,12 @@
test_container_name_invalid('type(inline-size)');
test_container_name_invalid('"foo"');
test_container_name_invalid('"inherit"');
test_container_name_invalid('inherit');
test_container_name_invalid('INITIAL');
test_container_name_invalid('Unset');
test_container_name_invalid('deFAULT');
test_container_name_invalid('none');
test_container_name_invalid('None');
test_container_name_invalid('normal');
test_container_name_invalid('Normal');
test_container_name_invalid('auto');
test_container_name_invalid('Auto');
test_container_name_invalid('and');
test_container_name_invalid('or');
test_container_name_invalid('not');
Expand Down
4 changes: 2 additions & 2 deletions css/css-contain/container-queries/container-name-parsing.html
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@
test_valid_value('container-name', 'foo bar');
test_valid_value('container-name', 'foo foo');
test_valid_value('container-name', '\\!escaped');
test_valid_value('container-name', 'auto');
test_valid_value('container-name', 'normal');

test_invalid_value('container-name', 'auto');
test_invalid_value('container-name', 'normal');
test_invalid_value('container-name', 'none none');
test_invalid_value('container-name', 'foo, bar');
test_invalid_value('container-name', '#fff');
Expand Down
4 changes: 2 additions & 2 deletions css/css-contain/container-queries/container-parsing.html
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@
test_valid_value('container', 'FOO / size');
test_valid_value('container', 'FOO/size', 'FOO / size');
test_valid_value('container', ' FOO /size', 'FOO / size');
test_valid_value('container', 'normal / size');
test_valid_value('container', 'auto / size');

test_invalid_value('container', 'none none');
test_invalid_value('container', 'none inline-size');
Expand All @@ -43,8 +45,6 @@
test_invalid_value('container', 'none, normal');
test_invalid_value('container', 'none / none');
test_invalid_value('container', 'none / auto');
test_invalid_value('container', 'normal / size');
test_invalid_value('container', 'auto / size');
test_invalid_value('container', 'none / foo');
test_invalid_value('container', 'none / foo, bar');
test_invalid_value('container', '#fff');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,9 @@
test_valid_value('scroll-timeline-name', 'abc');
test_valid_value('scroll-timeline-name', ' abc', 'abc');
test_valid_value('scroll-timeline-name', 'aBc');
test_valid_value('scroll-timeline-name', 'auto');

test_invalid_value('scroll-timeline-name', 'auto');
test_invalid_value('scroll-timeline-name', 'default');
test_invalid_value('scroll-timeline-name', '10px');
test_invalid_value('scroll-timeline-name', 'foo bar');
test_invalid_value('scroll-timeline-name', '"foo" "bar"');
Expand Down
3 changes: 2 additions & 1 deletion scroll-animations/css/view-timeline-name-parsing.html
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,9 @@
test_valid_value('view-timeline-name', 'bar, foo');
test_valid_value('view-timeline-name', 'none, none');
test_valid_value('view-timeline-name', 'a, none, b');
test_valid_value('view-timeline-name', 'auto');

test_invalid_value('view-timeline-name', 'auto');
test_invalid_value('view-timeline-name', 'default');
test_invalid_value('view-timeline-name', '10px');
test_invalid_value('view-timeline-name', 'foo bar');
test_invalid_value('view-timeline-name', '"foo" "bar"');
Expand Down
3 changes: 2 additions & 1 deletion scroll-animations/css/view-timeline-shorthand.tentative.html
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,12 @@

test_valid_value('view-timeline', 'a, b, c');
test_valid_value('view-timeline', 'a inline, b block, c vertical', 'a inline, b, c vertical');
test_valid_value('view-timeline', 'auto');

test_invalid_value('view-timeline', 'abc abc');
test_invalid_value('view-timeline', 'block none');
test_invalid_value('view-timeline', 'none none');
test_invalid_value('view-timeline', 'auto');
test_invalid_value('view-timeline', 'default');
test_invalid_value('view-timeline', ',');
test_invalid_value('view-timeline', ',,block,,');

Expand Down