Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provider related improvements #3190

Merged
merged 184 commits into from
Apr 6, 2020
Merged

Provider related improvements #3190

merged 184 commits into from
Apr 6, 2020

Commits on Oct 24, 2019

  1. Configuration menu
    Copy the full SHA
    1a05194 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2019

  1. Configuration menu
    Copy the full SHA
    4f856c8 View commit details
    Browse the repository at this point in the history
  2. packageInit, setProvider and related listener issue fixed with adding…

    … of a setRequestManager method
    nivida committed Oct 30, 2019
    Configuration menu
    Copy the full SHA
    9c028ad View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2019

  1. Configuration menu
    Copy the full SHA
    0a978d8 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2019

  1. Attach ws event listeners using EventTarget API

    When using `.on<event>=fn` to attach listeners, only one listener can be
    set at the same time. Since multiple request managers can use the same
    provider, the EventTarget API has to be used to ensure all of them
    receive the events emitted from the provider.
    
    This is needed on both the `on` and `removeListener` functions.
    gabmontes authored and cgewecke committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    57be867 View commit details
    Browse the repository at this point in the history
  2. Add once to the WS provider interface

    The method `once` is required to allow the subscription logic to
    identify if the provider is able to reconnect/resubscribe and then
    attach to the following `connect` event the function to resubscribe.
    gabmontes authored and cgewecke committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    7c8451c View commit details
    Browse the repository at this point in the history
  3. Merge logic for resubscription

    When the subscription fails on start and when it fails after it was
    successfully established, the same logic needs to be executed: remove
    subscription, listen for the next `connect` event if available to
    actually subscribe again, emit the error and call the callback.
    
    Prior code did that only for established subscriptions so if a
    subscription was unable to be set right on start, no resubscription was
    ever tried.
    
    The logic was moved to a single method to avoid duplication of code.
    In addition reentry is avoided by checking and properly clearing the
    `_reconnectIntervalId` variable.
    gabmontes authored and cgewecke committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    53a7d36 View commit details
    Browse the repository at this point in the history
  4. Clear subscription id before resubscribing

    On subscribe, if there is an existing `id`, the subscription listeners
    are removed. In the case of a resubscription, the listeners have to be
    kept. Therefore, the `id` property -that will change anyway- must be
    cleared so the listeners are not removed.
    
    Then, after the subscription object resubscribes, the listeners set by
    the subscription user code remain untouched, making the resubscription
    transparent to the user code.
    gabmontes authored and cgewecke committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    666f087 View commit details
    Browse the repository at this point in the history
  5. Avoid reentry when removing subscriptions

    When the request manager removes a subscription due to an error, it
    tries to send an unsubscribe package, which can also fail if i.e. the
    network is down. In such a case, the function must not allow reentry.
    Removing the subscription first ensures it will not do so.
    
    In addition, if the subscription was already removed, the callback shall
    be called anyway.
    gabmontes authored and cgewecke committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    9c366e4 View commit details
    Browse the repository at this point in the history
  6. Broadcast provider error to subscribers

    When error events are emitted by the provider, all subscriptions shall
    receive the event and trigger the unsubscription/resubscription logic.
    gabmontes authored and cgewecke committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    f35fc88 View commit details
    Browse the repository at this point in the history
  7. Add support for WebSocket reconnections

    By wrapping the available WebSocket implementation (native WebSocket
    object or `websocket` package) with `websocket-reconnector`, the
    provider is given a WebSocket that will automatically reconnect on
    errors.
    
    A new option was added to the WebSocket provider to controll whether it
    should automatically reconnect or it should behave as usual.
    gabmontes authored and cgewecke committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    4af2f2b View commit details
    Browse the repository at this point in the history
  8. Try to reconnect on timeout too

    In the case any websocket call takes too long to return and a timeout
    was set for the provider to timeout, the provider should try to restart
    the connection.
    
    This could happen, for instance, if the client loses connection with the
    server, the server closes the connection and later, the connectivity is
    up again but since the client did not receive the closing frame *and*
    the client does not attempt to send any package to the server, no error
    is observed.
    
    `websocket` implementation for Node.js has an option to send keep-alive
    frames and detect such scenarios, but the standard browser W3C WebSocket
    does not, so it is "vulnerable" to this kind of failure which will
    mostly affect web3 subscriptions.
    gabmontes authored and cgewecke committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    fbba26e View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    5f5c2b8 View commit details
    Browse the repository at this point in the history
  10. Ensure resubscription is done on silent reconnects

    If the provider silently recoonects and emits a new "connect" event, the subscriptions have to be set again over that new connection.
    gabmontes authored and cgewecke committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    6305262 View commit details
    Browse the repository at this point in the history
  11. Fix indentation

    gabmontes authored and cgewecke committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    ed96084 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    d31f7e2 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    6b639e5 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    4e4d341 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    d624492 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2019

  1. Update packages/web3-providers-ws/src/index.js

    Co-Authored-By: cgewecke <christophergewecke@gmail.com>
    nivida and cgewecke authored Nov 7, 2019
    Configuration menu
    Copy the full SHA
    8715096 View commit details
    Browse the repository at this point in the history
  2. subscriptions are now hold in a Map in the RequestManager, and resubs…

    …cribing after the connection got lost will now get triggered from the RequestManager instead of the subscriptions
    nivida committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    3cc23f5 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2019

  1. Configuration menu
    Copy the full SHA
    b0c22c3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    62fc1b5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3c77b99 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d2de9fd View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5c4b2da View commit details
    Browse the repository at this point in the history
  6. missing _this added

    nivida committed Nov 8, 2019
    Configuration menu
    Copy the full SHA
    a62c543 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    4230f78 View commit details
    Browse the repository at this point in the history
  8. no longer requried _reconnectIntervalId property removed in subscript…

    …ion.js and funcDoc added to websocketprovider.send()
    nivida committed Nov 8, 2019
    Configuration menu
    Copy the full SHA
    155adc5 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    f37a305 View commit details
    Browse the repository at this point in the history
  10. explicit delete will now be used on connect to remove the request ite…

    …ms instead of clearing it after. Who knows the connection could got interuppted 1ms after the connect event got emitted
    nivida committed Nov 8, 2019
    Configuration menu
    Copy the full SHA
    68a5a33 View commit details
    Browse the repository at this point in the history
  11. close and connect handler for requestQueue extended with stoping of r…

    …e-sending or rejecting of the requests if the event connect or close got emitted
    nivida committed Nov 8, 2019
    Configuration menu
    Copy the full SHA
    e5eacfb View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    b223a20 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    e991785 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    7b6c48b View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    08d83b0 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    0b8bedb View commit details
    Browse the repository at this point in the history
  17. missing object properties added to WebsocketProvider and eventemitter…

    …3 added to dependencies of the web3-providers-ws package
    nivida committed Nov 8, 2019
    Configuration menu
    Copy the full SHA
    e7c41be View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    de090b4 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    44688ef View commit details
    Browse the repository at this point in the history
  20. not required else and var remove in websocketprovider.onMessage() and…

    … position moved of emit(event) in some provider listeners
    nivida committed Nov 8, 2019
    Configuration menu
    Copy the full SHA
    909b6c3 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    1c9f306 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    091851a View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    e3be52f View commit details
    Browse the repository at this point in the history
  24. reconnecting property will now get set to false if the maximum of att…

    …empts is reached and parseURL helper moved out to helper file because of ethical reasons
    nivida committed Nov 8, 2019
    1 Configuration menu
    Copy the full SHA
    4161ec5 View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    e182974 View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    21ae48f View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    30da469 View commit details
    Browse the repository at this point in the history
  28. Configuration menu
    Copy the full SHA
    22c91d1 View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    879fbca View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    d982f9f View commit details
    Browse the repository at this point in the history
  31. Configuration menu
    Copy the full SHA
    1fbea04 View commit details
    Browse the repository at this point in the history
  32. _removeAllSocketListeners -> _removeSocketListeners renamed in Websoc…

    …ketProvider for consistency reasons with _addSocketListeners
    nivida committed Nov 8, 2019
    Configuration menu
    Copy the full SHA
    99b5da9 View commit details
    Browse the repository at this point in the history
  33. Configuration menu
    Copy the full SHA
    aaf4a30 View commit details
    Browse the repository at this point in the history
  34. timeout removed in _parseResponse because the timeout in send will co…

    …ver it and is also configurable
    nivida committed Nov 8, 2019
    Configuration menu
    Copy the full SHA
    c75da8b View commit details
    Browse the repository at this point in the history
  35. Configuration menu
    Copy the full SHA
    1fdb56f View commit details
    Browse the repository at this point in the history
  36. Configuration menu
    Copy the full SHA
    f0c57a3 View commit details
    Browse the repository at this point in the history
  37. Configuration menu
    Copy the full SHA
    56376f7 View commit details
    Browse the repository at this point in the history
  38. Configuration menu
    Copy the full SHA
    16efbf2 View commit details
    Browse the repository at this point in the history
  39. Configuration menu
    Copy the full SHA
    dc88690 View commit details
    Browse the repository at this point in the history
  40. Configuration menu
    Copy the full SHA
    d796635 View commit details
    Browse the repository at this point in the history
  41. Configuration menu
    Copy the full SHA
    7b3b122 View commit details
    Browse the repository at this point in the history
  42. Configuration menu
    Copy the full SHA
    9d2f65b View commit details
    Browse the repository at this point in the history
  43. Configuration menu
    Copy the full SHA
    5931584 View commit details
    Browse the repository at this point in the history
  44. Configuration menu
    Copy the full SHA
    b344092 View commit details
    Browse the repository at this point in the history
  45. ddefault value '1000' for the optional and newly added parameter code…

    … of the websocketprovider.disconnect() method. It will otherwise not close the connection if re-connecting is enabled
    nivida committed Nov 8, 2019
    Configuration menu
    Copy the full SHA
    581cdbc View commit details
    Browse the repository at this point in the history
  46. timeout handling changed in WS provider to save a event listener in t…

    …he RequestManager and provider event name properties are now used in the RequestManager
    nivida committed Nov 8, 2019
    Configuration menu
    Copy the full SHA
    1f0689d View commit details
    Browse the repository at this point in the history
  47. recconectAttempts reset added, TODOs added, and order updated in the …

    …send methof of the WebsocketProvider object
    nivida committed Nov 8, 2019
    Configuration menu
    Copy the full SHA
    a1e5762 View commit details
    Browse the repository at this point in the history
  48. Configuration menu
    Copy the full SHA
    0c1a32c View commit details
    Browse the repository at this point in the history
  49. WebsocketProvider timeout handling does now clean the requestQueue if…

    … not trying to reconnect
    nivida committed Nov 8, 2019
    Configuration menu
    Copy the full SHA
    9ee548f View commit details
    Browse the repository at this point in the history
  50. Configuration menu
    Copy the full SHA
    52385b4 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2019

  1. 'connect' listener updated in RequestManager, func doc improved, and …

    …reconnect options extended/improved for the WebsocketProvider
    nivida committed Nov 10, 2019
    Configuration menu
    Copy the full SHA
    4a30c79 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    297ffc9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8e8c6b3 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2019

  1. Configuration menu
    Copy the full SHA
    2be288f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    11989cd View commit details
    Browse the repository at this point in the history
  3. test/contract.js updated because the RequestManager is now using a Ma…

    …p object instead of a plain data object
    nivida committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    569f481 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9043ab3 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    bd2857a View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    5559969 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    c552e98 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    8f0a2cf View commit details
    Browse the repository at this point in the history
  9. reconnecting test updated and disconnect method simplified in Websock…

    …etProvider. Test test is succeeding but it does trigger the reconnecting process again because I can't close the ganache server cleanly
    nivida committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    eb27a23 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2019

  1. eth.subscribe.ganache test updated and the error handling of Websocke…

    …tProvider.send improved
    nivida committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    3c0904d View commit details
    Browse the repository at this point in the history
  2. call of removeListener added to error and close listener in send meth…

    …od of the WebsocketProvider
    nivida committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    1d05111 View commit details
    Browse the repository at this point in the history
  3. test case added to eth.subscribe.ganache and error handling in the cl…

    …ose listener of the RequestManager for subscriptions improved
    nivida committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    1e6efaa View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    453c742 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    318c345 View commit details
    Browse the repository at this point in the history
  6. provider handling for contracts updated. This was required because of…

    … the new way the RequestManager does get inherited
    nivida committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    6df7456 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    2958284 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    2951da7 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    c5b0471 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    5727104 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    349076d View commit details
    Browse the repository at this point in the history
  12. error handling updated the errorQueue will now be used instead of usi…

    …ng the requestQueue to listen for close or event errors during execution of the request. (fixes a bug where transactions could get executed twice on reconnecting)
    nivida committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    84ec342 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    bf61074 View commit details
    Browse the repository at this point in the history
  14. additional timeout wrapped in if because this case only happens if th…

    …e provider is reconnecting because of a manual call or because the reconnecting option auto is set to true
    nivida committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    9160389 View commit details
    Browse the repository at this point in the history
  15. errorQueue renamed to responseQueue, send method simplified, and not …

    …finished request do now get handled if the provider does start to reconnect
    nivida committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    5b405f4 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2019

  1. Configuration menu
    Copy the full SHA
    a82f899 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2019

  1. Configuration menu
    Copy the full SHA
    f90842e View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2019

  1. exit option added to mocha for now until we are able to kill the gana…

    …che process in a clean way
    nivida committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    07565a4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a27af13 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ebf9239 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1456620 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ef63cf7 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d9b080f View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2019

  1. code-style changes reverted

    nivida committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    127b06c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f5a1217 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    81474d9 View commit details
    Browse the repository at this point in the history
  4. Merge branch 'provider-related-improvements' of github.com:ethereum/w…

    …eb3.js into provider-related-improvements
    nivida committed Dec 4, 2019
    Configuration menu
    Copy the full SHA
    52e5c5c View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2019

  1. Configuration menu
    Copy the full SHA
    a46dbcd View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2019

  1. Configuration menu
    Copy the full SHA
    0168764 View commit details
    Browse the repository at this point in the history
  2. Remove console.log in test

    cgewecke committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    6cf61ed View commit details
    Browse the repository at this point in the history
  3. Use done

    cgewecke committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    4c6bab9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    21d854c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    1cb8b80 View commit details
    Browse the repository at this point in the history
  6. Remove .only

    cgewecke committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    7790a26 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    ac880f6 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2019

  1. provider types moved back to web3-core-helpers package to not break e…

    …xisting code and during moving the tests improved
    nivida committed Dec 18, 2019
    Configuration menu
    Copy the full SHA
    fb1d422 View commit details
    Browse the repository at this point in the history
  2. the response and request queue does now get cleaned up if WebsocketPr…

    …ovider.reset does get called from a consumer
    nivida committed Dec 18, 2019
    Configuration menu
    Copy the full SHA
    80ea81c View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2019

  1. Configuration menu
    Copy the full SHA
    d21d746 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2020

  1. Configuration menu
    Copy the full SHA
    9038a7a View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2020

  1. Merge pull request #3276 from ethereum/pri/more-ganache-tests

    Add tests for core-subscriptions edge cases
    nivida authored Jan 7, 2020
    Configuration menu
    Copy the full SHA
    5b51b2d View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2020

  1. Configuration menu
    Copy the full SHA
    ebc2e32 View commit details
    Browse the repository at this point in the history
  2. WebsocketProviderOptions interface updated, code style improved in et…

    …h.subscribe.ganache.js and websocket.reconnect.ganache test added
    nivida committed Jan 8, 2020
    Configuration menu
    Copy the full SHA
    ec72aa9 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2020

  1. Configuration menu
    Copy the full SHA
    1f8e75d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3048f50 View commit details
    Browse the repository at this point in the history
  3. error listener removed in WSProvider because the close listener does …

    …get triggered anyways, error handling immproved in WebsocketProvider and RequestManager
    nivida committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    d7fb27f View commit details
    Browse the repository at this point in the history
  4. renaming of ConnectionTimeout to ConnectionTimeoutError reverted (bre…

    …aking-change). Error types extended and required type test cases added
    nivida committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    ab7e40b View commit details
    Browse the repository at this point in the history
  5. populating of MaxAttemptsReachedOnReconnectingError fixed and require…

    …d error listener re-added to the RequestManager to populate the error also for subscriptions
    nivida committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    84e1296 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    0252714 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2020

  1. Add websocket / misc tests

    cgewecke committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    b2e33de View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0b962da View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b06d0fe View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7975e64 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2020

  1. Configuration menu
    Copy the full SHA
    5e1aec2 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2020

  1. Configuration menu
    Copy the full SHA
    8e9a408 View commit details
    Browse the repository at this point in the history
  2. Make tests pass

    cgewecke committed Jan 12, 2020
    Configuration menu
    Copy the full SHA
    a50d2e9 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2020

  1. Configuration menu
    Copy the full SHA
    4044687 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7ad8d34 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    68ff063 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2020

  1. Configuration menu
    Copy the full SHA
    6428287 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #3299 from ethereum/pri/testing-gaps

    Add websocket / misc tests (#3190)
    nivida authored Jan 15, 2020
    Configuration menu
    Copy the full SHA
    7b6a389 View commit details
    Browse the repository at this point in the history
  3. WebsocketProvider error handling compared to current and breaking cha…

    …nges removed. Known error objects extended with 'code' and 'reason' property.
    nivida committed Jan 15, 2020
    Configuration menu
    Copy the full SHA
    57a50e8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d709ab2 View commit details
    Browse the repository at this point in the history
  5. additional assertions added to websocket.ganache test to cover the 'c…

    …ode' and 'reason' property of the ConnectionError
    nivida committed Jan 15, 2020
    Configuration menu
    Copy the full SHA
    3ca9b09 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f937631 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    1b9c969 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2020

  1. Merge pull request #3314 from ethereum/pri/error-handling

    WebsocketProvider - Error Handling
    nivida authored Jan 16, 2020
    Configuration menu
    Copy the full SHA
    cd680eb View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2020

  1. Configuration menu
    Copy the full SHA
    044a4d5 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2020

  1. Configuration menu
    Copy the full SHA
    b1a71b2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a84df3f View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2020

  1. Fix code comment

    cgewecke authored Jan 24, 2020
    Configuration menu
    Copy the full SHA
    4b05a67 View commit details
    Browse the repository at this point in the history
  2. as discussed in #3303 does this commit add a hint to the documenation…

    … if someone does passes the exact same provider instance again to the setProvider method of the current module
    nivida committed Jan 24, 2020
    Configuration menu
    Copy the full SHA
    8bae2a9 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2020

  1. helpful note on wish removed

    nivida committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    561c3eb View commit details
    Browse the repository at this point in the history
  2. Merge pull request #3303 from ethereum/pri/contract-js-clean

    Minimize changes to test/contract.js (#3190)
    nivida authored Jan 27, 2020
    Configuration menu
    Copy the full SHA
    100dab7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    df21651 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #3330 from ethereum/pri/minimize-changeset

    Revert non-essential changes (#3190)
    nivida authored Jan 27, 2020
    Configuration menu
    Copy the full SHA
    e749c11 View commit details
    Browse the repository at this point in the history
  5. Use the web3-eth Contract constructor or the provider inheritance doe…

    …sn't work as expected
    nivida committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    5e3ad84 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    060a71d View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2020

  1. Configuration menu
    Copy the full SHA
    191ae06 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    35663ec View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d8159e4 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3dd1d7b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e303c61 View commit details
    Browse the repository at this point in the history
  6. Merge pull request #3344 from ethereum/pri/fix-contract-js-test

    Implement FakeIpcProvider.reset (#3190)
    nivida authored Jan 28, 2020
    Configuration menu
    Copy the full SHA
    d05d608 View commit details
    Browse the repository at this point in the history
  7. Fix style issues

    cgewecke committed Jan 28, 2020
    Configuration menu
    Copy the full SHA
    68d3716 View commit details
    Browse the repository at this point in the history
  8. JSDoc

    cgewecke authored Jan 28, 2020
    Configuration menu
    Copy the full SHA
    8749185 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2020

  1. missing requested changes from PR applied, funcDoc formatting improve…

    …d, strange emitterInstance variable removed, and missing semicolons added to websocket.ganache test file
    nivida committed Jan 29, 2020
    Configuration menu
    Copy the full SHA
    319710d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    46ebb24 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2020

  1. Configuration menu
    Copy the full SHA
    9f4b28c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1984430 View commit details
    Browse the repository at this point in the history
  3. Remove unused emitter ref

    cgewecke authored Jan 30, 2020
    Configuration menu
    Copy the full SHA
    e78bed7 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    bca6a58 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #3347 from ethereum/pri/isolation-tests

    Add subscription tests for disconnect & setProvider (#3190)
    nivida authored Jan 30, 2020
    Configuration menu
    Copy the full SHA
    2223335 View commit details
    Browse the repository at this point in the history
  6. Merge pull request #3329 from ethereum/pri/connection-close

    Check for error codes on close in RequestManager (#3190)
    nivida authored Jan 30, 2020
    Configuration menu
    Copy the full SHA
    aff3a6c View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    a805a27 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2020

  1. Update test/eth.subscribe.ganache.js

    Co-Authored-By: cgewecke <christophergewecke@gmail.com>
    nivida and cgewecke authored Feb 20, 2020
    Configuration menu
    Copy the full SHA
    3ab0779 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2020

  1. Configuration menu
    Copy the full SHA
    df8157e View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2020

  1. Merge pull request #3402 from ethereum/pri/document-ws-provider-options

    Document WS clientConfig options in README and RTD
    holgerd77 authored Mar 20, 2020
    Configuration menu
    Copy the full SHA
    288582f View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2020

  1. Configuration menu
    Copy the full SHA
    51ee313 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    dc3ed52 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f8b9b48 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2020

  1. Configuration menu
    Copy the full SHA
    2eb3ed1 View commit details
    Browse the repository at this point in the history