Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nvmrc file #3817

Merged
merged 8 commits into from
Mar 16, 2021
Merged

add nvmrc file #3817

merged 8 commits into from
Mar 16, 2021

Conversation

frankiebee
Copy link
Contributor

currently web3js will not successfully install deps with node version 15~ and npm version 7

please feel free to debate the node version am very willing to change this

or weather we should specify in package.json file

@coveralls
Copy link

Coverage Status

Coverage increased (+2.4%) to 80.423% when pulling dfa8663 on safe-dev/create-nvmrc into 27c9679 on 1.x.

@CLAassistant
Copy link

CLAassistant commented Jan 7, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ spacesailor24
❌ frankiebee
You have signed the CLA already but the status is still pending? Let us recheck it.

@coveralls
Copy link

coveralls commented Jan 11, 2021

Pull Request Test Coverage Report for Build 659139631

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 76.265%

Totals Coverage Status
Change from base Build 659138699: 0.0%
Covered Lines: 3170
Relevant Lines: 3942

💛 - Coveralls

Copy link
Contributor

@spacesailor24 spacesailor24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested installing web3 as a dependency using node 15.5.1, and it works fine. However, installing the devDependencies with version 15.5.1 is broken, so I think adding the .nvmrc file with version 14.15.1 makes sense for developers of web3

koraykoska
koraykoska previously approved these changes Feb 10, 2021
Copy link

@koraykoska koraykoska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it and works for me.

Copy link
Contributor

@spacesailor24 spacesailor24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs changelog update :)

@spacesailor24 spacesailor24 added Enhancement Includes improvements or optimizations P3 Low severity bugs labels Mar 9, 2021
@render
Copy link

render bot commented Mar 16, 2021

@spacesailor24 spacesailor24 merged commit bb259d9 into 1.x Mar 16, 2021
@spacesailor24 spacesailor24 deleted the safe-dev/create-nvmrc branch March 16, 2021 22:28
This was referenced Mar 18, 2021
spacesailor24 added a commit that referenced this pull request Mar 26, 2021
* Replace hardcoded infura endpoints (#3943)

* Replace hardcoded infura endpoints

* infura link changelog

* WARNING Exposing secrets, rotate infura keys after debugging is finished

* Merging geth-dev-assistant updates (#3950)

* Bump geth-dev-assistant to 0.1.9

* npm i

* bump geth-dev-assistant

* Remove logs

* use posinstall to do deprecation warnings (#3917)

* use posinstall to do deprecation warnings

* add to change log

* add preinstall warning

* remove preinstall

* add warnings to bzz and shh package.json

Co-authored-by: Wyatt Barnes <wyatt@writerof.software>

* Bump elliptic from 6.5.3 to 6.5.4 in /packages/web3-eth-accounts (#3941)

Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.3 to 6.5.4.
- [Release notes](https://github.com/indutny/elliptic/releases)
- [Commits](indutny/elliptic@v6.5.3...v6.5.4)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Wyatt Barnes <wyatt@writerof.software>

* Bump elliptic from 6.5.3 to 6.5.4 in /packages/web3-bzz (#3940)

* Bump elliptic from 6.5.3 to 6.5.4 in /packages/web3-bzz

Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.3 to 6.5.4.
- [Release notes](https://github.com/indutny/elliptic/releases)
- [Commits](indutny/elliptic@v6.5.3...v6.5.4)

Signed-off-by: dependabot[bot] <support@github.com>

* Update CHANGELOG

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Wyatt Barnes <wyatt@writerof.software>
Co-authored-by: Wyatt Barnes <me@wyatt.email>

* Bump elliptic from 6.5.3 to 6.5.4 in /packages/web3-core-requestmanager (#3945)

* Bump elliptic from 6.5.3 to 6.5.4 in /packages/web3-core-requestmanager

Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.3 to 6.5.4.
- [Release notes](https://github.com/indutny/elliptic/releases)
- [Commits](indutny/elliptic@v6.5.3...v6.5.4)

Signed-off-by: dependabot[bot] <support@github.com>

* Update CHANGELOG

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Wyatt Barnes <me@wyatt.email>

* add nvmrc file (#3817)

* add nvmrc file

* Update changelog

Co-authored-by: Wyatt Barnes <wyatt@writerof.software>
Co-authored-by: Wyatt Barnes <me@wyatt.email>

* Rename tsc to compile (#3957) (#3958)

* Change 'tsc' command in scripts & lerna run to 'compile'

* Update changelog

* Undo incorrect rename

* Checking if e2e test is deterministic

Co-authored-by: Sam Hodak <slhodak@gmail.com>

Co-authored-by: Sam Hodak <slhodak@gmail.com>

* Debugging failing tests (#3959) (#3960)

* Remote node provider edits

* remote node provider documentation edits

Co-authored-by: smudgil <38195323+smudgil@users.noreply.github.com>

Co-authored-by: smudgil <38195323+smudgil@users.noreply.github.com>

* Clarify commitment to semantic versioning (#3961) (#3962)

see discussion in the issue #3758

Co-authored-by: LudwikJaniuk <ludvig.janiuk@gmail.com>

Co-authored-by: LudwikJaniuk <ludvig.janiuk@gmail.com>

* Feature/web3 eth iban es6 (#3964) (#3965)

* Feature/web3 eth iban es6 (#3964)

* web3-eth-iban es6 rewrite - replace `var` with `const` and `let`

* web3-eth-iban es6 rewrite - replace object prototype with class

* web3-eth-iban code style fix

Co-authored-by: Loredana <loredana.cirstea@gmail.com>

* Update changelog

Co-authored-by: Loredana <loredana.cirstea@gmail.com>

Co-authored-by: Frankie <frankie.diamond@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sam Hodak <slhodak@gmail.com>
Co-authored-by: smudgil <38195323+smudgil@users.noreply.github.com>
Co-authored-by: LudwikJaniuk <ludvig.janiuk@gmail.com>
Co-authored-by: Loredana <loredana.cirstea@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Includes improvements or optimizations P3 Low severity bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants