use posinstall to do deprecation warnings #3917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 655498077
💛 - Coveralls |
packages/web3/package.json
Outdated
| @@ -20,7 +20,9 @@ | |||
| "types": "types/index.d.ts", | |||
| "scripts": { | |||
| "tsc": "tsc -b tsconfig.json", | |||
| "dtslint": "dtslint --localTs ../../node_modules/typescript/lib types" | |||
| "dtslint": "dtslint --localTs ../../node_modules/typescript/lib types", | |||
| "preinstall": "echo \"WARNING: the web3-shh and web3-bzz api will be deprecated in the next version\"", | |||
There was a problem hiding this comment.
Do we need both pre and post? I think just post could suffice, no?
There was a problem hiding this comment.
it was mentioned in slack that that was wanted can remove though if it's overkill
spacesailor24
approved these changes
Mar 8, 2021
spacesailor24
suggested changes
Mar 8, 2021
spacesailor24
approved these changes
Mar 16, 2021
spacesailor24
added a commit
that referenced
this pull request
Mar 26, 2021
* Replace hardcoded infura endpoints (#3943) * Replace hardcoded infura endpoints * infura link changelog * WARNING Exposing secrets, rotate infura keys after debugging is finished * Merging geth-dev-assistant updates (#3950) * Bump geth-dev-assistant to 0.1.9 * npm i * bump geth-dev-assistant * Remove logs * use posinstall to do deprecation warnings (#3917) * use posinstall to do deprecation warnings * add to change log * add preinstall warning * remove preinstall * add warnings to bzz and shh package.json Co-authored-by: Wyatt Barnes <wyatt@writerof.software> * Bump elliptic from 6.5.3 to 6.5.4 in /packages/web3-eth-accounts (#3941) Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.3 to 6.5.4. - [Release notes](https://github.com/indutny/elliptic/releases) - [Commits](indutny/elliptic@v6.5.3...v6.5.4) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Wyatt Barnes <wyatt@writerof.software> * Bump elliptic from 6.5.3 to 6.5.4 in /packages/web3-bzz (#3940) * Bump elliptic from 6.5.3 to 6.5.4 in /packages/web3-bzz Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.3 to 6.5.4. - [Release notes](https://github.com/indutny/elliptic/releases) - [Commits](indutny/elliptic@v6.5.3...v6.5.4) Signed-off-by: dependabot[bot] <support@github.com> * Update CHANGELOG Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Wyatt Barnes <wyatt@writerof.software> Co-authored-by: Wyatt Barnes <me@wyatt.email> * Bump elliptic from 6.5.3 to 6.5.4 in /packages/web3-core-requestmanager (#3945) * Bump elliptic from 6.5.3 to 6.5.4 in /packages/web3-core-requestmanager Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.3 to 6.5.4. - [Release notes](https://github.com/indutny/elliptic/releases) - [Commits](indutny/elliptic@v6.5.3...v6.5.4) Signed-off-by: dependabot[bot] <support@github.com> * Update CHANGELOG Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Wyatt Barnes <me@wyatt.email> * add nvmrc file (#3817) * add nvmrc file * Update changelog Co-authored-by: Wyatt Barnes <wyatt@writerof.software> Co-authored-by: Wyatt Barnes <me@wyatt.email> * Rename tsc to compile (#3957) (#3958) * Change 'tsc' command in scripts & lerna run to 'compile' * Update changelog * Undo incorrect rename * Checking if e2e test is deterministic Co-authored-by: Sam Hodak <slhodak@gmail.com> Co-authored-by: Sam Hodak <slhodak@gmail.com> * Debugging failing tests (#3959) (#3960) * Remote node provider edits * remote node provider documentation edits Co-authored-by: smudgil <38195323+smudgil@users.noreply.github.com> Co-authored-by: smudgil <38195323+smudgil@users.noreply.github.com> * Clarify commitment to semantic versioning (#3961) (#3962) see discussion in the issue #3758 Co-authored-by: LudwikJaniuk <ludvig.janiuk@gmail.com> Co-authored-by: LudwikJaniuk <ludvig.janiuk@gmail.com> * Feature/web3 eth iban es6 (#3964) (#3965) * Feature/web3 eth iban es6 (#3964) * web3-eth-iban es6 rewrite - replace `var` with `const` and `let` * web3-eth-iban es6 rewrite - replace object prototype with class * web3-eth-iban code style fix Co-authored-by: Loredana <loredana.cirstea@gmail.com> * Update changelog Co-authored-by: Loredana <loredana.cirstea@gmail.com> Co-authored-by: Frankie <frankie.diamond@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sam Hodak <slhodak@gmail.com> Co-authored-by: smudgil <38195323+smudgil@users.noreply.github.com> Co-authored-by: LudwikJaniuk <ludvig.janiuk@gmail.com> Co-authored-by: Loredana <loredana.cirstea@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sorry for all the spam 😅