Validate name-start code points for identifier #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The thrown exception will be caught when in lenient mode
* tag '8.4.0': (133 commits) Prepare release 8.4.0 Test on PHP 8.2-dev Fix PHP 8.1 compatibility in ParserState::strsplit() Update ci.yml Also run PHP-linting with PHP 8.1 Install the development tools in the CI build the proper way Make the tests for `AtRuleBlockList` more fine-grained Fix invalid or impossible PHPDoc type annotations Make the existing tests for `Document` for fine-grained Add and clean up the type annotations for the tests Add type annotations for `Settings` Add type annotations for `URL` Add type annotations for `Size` Add more type annotations for `ValueList` Add type annotations for `LineName` Add type annotations for `PrimitiveValue` Add type annotations for `CSSString` Fix a typo in a variable name Add type annotations for `Color` Add type annotations for `CSSFunction` ...
westonruter
added a commit
that referenced
this pull request
Feb 24, 2022
…into fix/malformed-identifier * 'master' of https://github.com/sabberworm/PHP-CSS-Parser: (57 commits) Update PHP-CS-Fixer and PHPStan Update README.md Update PHP-CS-Fixer and PHPStan Update PHP-CS-Fixer and PHPStan Update PHP-CS-Fixer and PHPStan Run the tests on CI with all warnings enabled Show the Composer configuration in the CI jobs Add PHPDoc Fixes for CI Add missing code after catchup merge Fix unit tests Code refactor for CI Streamline parsing functions Re-implement ParserState anchors with dedicated Anchor class Add back code that got dropped while resolving conflicts Fix indents Use PHPUnit 5.x features in the tests Add unit tests for interface implementation in `CSSList` classes Add more detailed unit tests for `Comment` Sync the code documentation from the README to the source files ...
westonruter
force-pushed
the
fix/malformed-identifier
branch
from
185f98c to
afae6ab
Compare
2 tasks
…into fix/malformed-identifier * 'v8.x' of https://github.com/MyIntervals/PHP-CSS-Parser: (46 commits) [CLEANUP] Autoformat the code (MyIntervals#749) [TASK] Prepare the 8.7.0 release (MyIntervals#742) [BUGFIX] Fix another implictly nullable parameter (MyIntervals#751) [CLEANUP] Autoformat the changelog (MyIntervals#750) [TASK] Configure PHPUnit to be more strict (MyIntervals#744) [BUGFIX] Avoid implicit nullable parameters (MyIntervals#746) [BUGFIX] Revert broken support for multiple comments (MyIntervals#741) [TASK] Add some more tests for parsing comments (MyIntervals#739) [TASK] Use fixed PHPUnit versions (MyIntervals#726) [TASK] Update PHPUnit (MyIntervals#725) [TASK] State since which version code is `@internal`/`@deprecated` (MyIntervals#723) [TASK] Deprecate the expansion of shorthand properties (MyIntervals#719) [TASK] Mark parsing-internal classes and methods as `@internal` (MyIntervals#711) [TASK] Deprecate `Parser::setCharset()` and `Parser::getCharset()` (MyIntervals#703) [FEATURE] Run the tests on CI with PHP 8.4 as well (MyIntervals#701) [TASK] Run the tests with PHP versions up to 8.3 (MyIntervals#697) [TASK] Also allow higher versions of PHPUnit (MyIntervals#682) [BUGFIX] Fix type errors in PHP strict mode (MyIntervals#695) [TASK] Block installations on unsupported higher PHP versions (MyIntervals#692) [BUGFIX] Avoid using `setUp()` in testcases (MyIntervals#683) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes merge conflicts in MyIntervals#185.
Note: The
fix/malformed-identifier-without-testsbranch contains the same changes as in this PR, without changes totests. This is so that a patch can be obtained to apply to the dist version of the package, using a URL like: https://github.com/sabberworm/PHP-CSS-Parser/compare/cc791ad...westonruter:PHP-CSS-Parser:fix/malformed-identifier-without-tests.diffSee https://github.com/ampproject/amp-wp/blob/828f229af54b9462a9e96152530a920d7431b1ca/composer.json#L92