Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lowLatency flag to CanvasRenderingContext2DSettings #4360

Conversation

yell0wd0g
Copy link
Contributor

@yell0wd0g yell0wd0g commented Feb 12, 2019

This is a duplicate of the current state of @kenrussell's #4234 PR (that partially addresses #4087), so I can take it over from here.

Note that this PR is blocking KhronosGroup/WebGL#2753.


/canvas.html ( diff )
/references.html ( diff )

kenrussell and others added 4 commits January 21, 2019 09:55
Developers of stylus-based drawing applications (e.g. Google Keep)
have found this hint to be critical in order to be competitive with
native applications. It has been prototyped in Chromium and yields
significant latency improvements there.

Partial fix for whatwg#4087.
@yell0wd0g
Copy link
Contributor Author

@annevk, @kenrussell, @jrmuizel, @grorg, @travisleithead, @fserb

Gathering a wee bit the status:
(1) - Low Latency as a feature comprises two parts: one is decoupling the input event processing and rendering from the browser main loop, and another is rendering onto the front buffer. (Chrome ToT (M74) has the first part in all platforms, whereas currently only implements front buffer rendering on ChromeOS.)
(2) - The App can use either or both of the features described in (1) to decrease latency from input events to rendering, but of course at the expense of having -maybe- tearing of the rendered contents; this PR is about offering this possibility to application developers which anyway would need to be aware of the implications of what they are doing (see e.g. this article).

With that I'd say the best flag name might be un/synchronized (synchronized: false or unsynchronized: true), conveying the two parts of the desynchronization as described in (1) and doesn't look like something everyone would like to have in their apps. WDYT? (Feel free 👍 this message).

Of course the PR should reflect this tradeoff, if at least in some informatiional non-normative note.

@kenrussell
Copy link
Member

It's all personal preference, but I like unsynchronized:true, desynchronized:true, and allowTearing:true.

@domenic
Copy link
Member

domenic commented Feb 12, 2019

I'll just note that boolean dictionary values should default to false, so all of @kenrussell's latest suggestions are good in that regard (as is the OP lowLatency: true). But e.g. synchronized: false would be bad.

(Yes, alpha: false breaks this rule. That is a sad historical mistake.)

@yell0wd0g
Copy link
Contributor Author

unsynchronized: true ping: @annevk, @jrmuizel, @grorg, @travisleithead, @fserb, WDYT?

@annevk annevk added addition/proposal New features or enhancements topic: canvas impacts documentation Used by documentation communities, such as MDN, to track changes that impact documentation labels Feb 13, 2019
@kdashg
Copy link

kdashg commented Feb 14, 2019

I generally do prefer foo: true over unfoo: false, so that !unfoo would just be foo.
If it's a strong recommendation that defaults should be false, I'd prefer desynchronized, which I think better reflects that it's allowing opting out of (the default) synchronization. (unsynchronized is acceptable, but not my preference)

@yell0wd0g
Copy link
Contributor Author

So, desynchronized: true seems to be leading the pack, @annevk, @travisleithead, does it sounds good to you too?

@othermaciej
Copy link

@YellowDoge I wrote in the previous PR for this that I don't really understand what this does, and I feel a bit more confused after your explanation. Some specific questions that came to mind:

  • Why would a canvas context flag affect processing of input events? Does setting this flag on any context affect all input events? Also, I didn't see anything in the spec change about processing of input events, did I miss it? Or is this a separate feature that you described solely for context.

  • I'm still not totally clear on what "rendering from the front buffer" means even after reading the Wikipedia reference on Multiple Buffering.

  • It doesn't seem like the spec has enough info to interoperable implement this, or to write test cases. Maybe that's ok for a performance hint?

  • Is this feature intended to be implementable on and/or relevant to platforms other than Chrome OS?

@annevk
Copy link
Member

annevk commented Feb 22, 2019

The name seems fine to me, but I'm a bit surprised @othermaciej's feedback on the prior PR went unaddressed. I'll try to be more careful ensuring all loose ends are tied up when we switch the place of discussion.

@yell0wd0g
Copy link
Contributor Author

yell0wd0g commented Feb 26, 2019

@othermaciej's feedback on the prior PR went unaddressed.

I thought it better to agree on a name for the new functionality before even getting to writing the spec patch, since the former will (greatly) affect the latter.

I can reply here to two of the concrete comments from #4360 (comment):

  • Why would a canvas context flag affect processing of input events?

Why not? If we want to decrease latency between input event and pixels on screen, this is one of the sources of delay to cut on. Moreover, some elements (like <video>) produce output in a manner essentially decoupled from the event processing loop, so this operational mode would be nothing new to the platform.

  • Is this feature intended to be implementable on and/or relevant to platforms other than Chrome OS?

Yes, in my coarse description in #4360 (comment), there's nothing ChromeOS specific, and as a matter of fact we're exploring the implementation on Windows.

@yell0wd0g
Copy link
Contributor Author

Folks I've uploaded a new version of the patch where hopefully things are clearer. I'm using the term desynchronized since it seems more consensual and nobody has expressed opinions against. I tried to explain in a note what is front buffer rendering, starting from the assumption that readers understand what is rendering, drawing, etc, pretty basic concepts IMHO but please give some feedback from spec-land as to what's the appropriate prerequisites of the reader. Note that front-buffer is just one of the ways to reduce latency (albeit a powerful one), but there's at least another one that is referenced.

@travisleithead
Copy link
Member

The name seems fine to me.

  • Why would a canvas context flag affect processing of input events?

I was similarly confused, but after @YellowDoge's answer, I understand now that there's no feature work to directly impact how input events are dispatched and processed, rather he meant that from the perspective of elapsed time, if the Javascript code that runs as a result of an input event being dispatched is able to send instructions to a canvas element that is, in turn, rendered to the screen more immediately (due to this feature), then this is a net improvement in the overall time to "process" an input event. If I'm still mistaken, let me know.

@othermaciej
Copy link

@travisleithead

I was similarly confused, but after @YellowDoge's answer, I understand now that there's no feature work to directly impact how input events are dispatched and processed[...]

The new spec diff says this (emphasis added)

When a CanvasRenderingContext2D object has its desynchronized flag set to true, then the user agent should optimize the rendering of the canvas to reduce the latency, as measured from input events to rasterization, by either decoupling the input event processing from the normal event processing cycle, bypassing the ordinary user agent/OS rendering algorithm, or both. Insofar as this mode involves bypassing the usual processing mechanisms of events or rasterization or both, it might introduce visible tearing artifacts.

This totally sounds like it would affect input event processing. It describes this as a separate change from the rendering change that is also controlled by the flag. (And it doesn't have enough info to interoperably implement this alternate event processing, if that is what it's supposed to mean).

@YellowDoge can you clarify? Is this flag meant to affect event processing, and not just rendering?

@yell0wd0g
Copy link
Contributor Author

@YellowDoge can you clarify? Is this flag meant to affect event processing, and not just rendering?

Yes, as it says :

by either decoupling the input event processing from the normal event processing cycle, bypassing the ordinary user agent/OS rendering algorithm, or both.

Reducing the latency can be achieved by reducing any of its components, namely: (a) input event delivery, (b) app logic processing, (c) drawing of the canvas (== execution of the drawing commands), and (d) OS rendering. If any of them is reduced, then the overall latency is reduced, right? Depending on the UA and OS capabilities, reduction of the latency can be done in several ways: reducing (a), reducing (c), reducing (d) or any combination of those.

The flag is a hint -- but if the UA is absolutely unable to improve (== reduce) he latency as defined before, then desynchronized will read back false, meaning it's not supported.

@kdashg
Copy link

kdashg commented Mar 6, 2019

Can we drop the 'changes input event processing' part? It seems like the primary adjustment we're making here is to desynchronize from the normal DOM update presentation atomicity.

Is there a need to go further than that right now, or can we move forward with just desynchronization from DOM update presentation atomicity?

@othermaciej
Copy link

I tend to agree with @jdashg . Changing input event processing is pretty concerning here, and it seems better left out. Reasoning:

  • It is surprising for a flag on a canvas graphics context object to change anything about input event handling.
  • It's unclear whether the effect is global to all input events or only about events directed to the relevant canvas element somehow.
  • While the rendering effects of this patch are not directly observable to web content (they only affect what the user sees on the screen), the event effects sound like they are. In particular, it sounds like timing of input events relative to other tasks or micro tasks could change. So there is interoperability risk if the event handling changes are implemented in slightly different ways.
  • At the same time, the specific possible changes to event handling are not described here at all, so it's impossible to implement them interoperably based on the spec, or make test cases that reflect the spec.

An alternative would be to specify what the alternate event handling behavior is, in a way that is precise enough to make test cases (even if it is a MAY-level requirement).

@othermaciej
Copy link

Further question about the term "front buffer rendering": could this also be accurately described as "single buffering" or "bypassing double/triple buffering"? I tried to look up resources on it and it sounds the same, but I might be missing a subtle difference. I ask because "single buffering" seems to be a more common term than "front buffer rendering", at least based on search engine frequency.

@yell0wd0g
Copy link
Contributor Author

Guys PTAL:

  • Removed the reference to the input events and left it as ...desynchronizing the canvas paint cycle from the normal DOM cycle, which is something we can control from the Canvas Context. If this is still unclear or off the point, please suggest a wording on the diff (@jdashg, @travisleithead, @othermaciej).
  • Added the reference to multiple buffering:

A popular technique for reducing latency is called front buffer rendering, also known as single buffer rendering, where rendering happens in parallel and racily with the scanning out process.

Copy link
Member

@travisleithead travisleithead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit, but otherwise looks good.

source Show resolved Hide resolved
@annevk
Copy link
Member

annevk commented Mar 11, 2019

Aside: please don't use "guys".

mykmelez pushed a commit to mykmelez/gecko that referenced this pull request Apr 25, 2019
…owLatency/desynchronized/", a=testonly

Automatic update from web-platform-tests
Revert "WIP Canvas 2D/WebGL context: s/lowLatency/desynchronized/"

This reverts commit 3fa9fd5b2eb09d461012c832db99273bb8c5a905.

Reason for revert: Suspect cause of failure in webkit_layout_tests:
* external/wpt/2dcontext/context-attributes/getContextAttributes.html
https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/35391

Original change's description:
> WIP Canvas 2D/WebGL context: s/lowLatency/desynchronized/
>
> This CL renames s/lowLatency/desynchronized/ on web-exposed parts
> (s/low_latency/desynchronized/ internally) following [1,2] PRs
> (issue [3]), and extends wpt getContextAttributes.html.
>
> [1] whatwg/html#4360
> [2] KhronosGroup/WebGL#2753
> [3] whatwg/html#4087
>
> Bug: 944199
> Change-Id: Ic9d7bd6165f9dc9536613dc63e77b86b8ec42f7f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532920
> Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
> Commit-Queue: Miguel Casas <mcasas@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#643323}

TBR=mcasas@chromium.org,foolip@chromium.org

Change-Id: I47d31863f61a882424e06aec40e93e8bc3875849
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 944199
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534473
Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#643430}

--

wpt-commits: d62bee5a53daade043c4704dc77379bdd2db0ea8
wpt-pr: 16029
mykmelez pushed a commit to mykmelez/gecko that referenced this pull request Apr 25, 2019
…t, a=testonly

Automatic update from web-platform-tests
Extend canvas getContextAttributes WPTest

This CL extend the WPTest for Canvas getContextAttributes to include
the |desynchronized|.

This CL covers the flag WPT test extension mentioned in
whatwg/html#4360 (which addressed
whatwg/html#4087).

Bug: 944199, 945835
Change-Id: Ibb339c66014d7579023f75c7f2cef99e3f03d351
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538491
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#644332}

--

wpt-commits: c3f8e5c0bb15e7d7f57dbe60f6869caa0c4ad2e7
wpt-pr: 16084
mykmelez pushed a commit to mykmelez/gecko that referenced this pull request Apr 25, 2019
…y/desynchronized/, a=testonly

Automatic update from web-platform-tests
WIP Canvas 2D/WebGL context: s/lowLatency/desynchronized/

This CL renames s/lowLatency/desynchronized/ on web-exposed parts
(s/low_latency/desynchronized/ internally) following [1,2] PRs
(issue [3]), and extends wpt getContextAttributes.html.

[1] whatwg/html#4360
[2] KhronosGroup/WebGL#2753
[3] whatwg/html#4087

Bug: 944199
Change-Id: Ic9d7bd6165f9dc9536613dc63e77b86b8ec42f7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532920
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#643323}

--

wpt-commits: 02e61522099b874a0075d058f89b9f549563c6dc
wpt-pr: 15982
mykmelez pushed a commit to mykmelez/gecko that referenced this pull request Apr 25, 2019
…owLatency/desynchronized/", a=testonly

Automatic update from web-platform-tests
Revert "WIP Canvas 2D/WebGL context: s/lowLatency/desynchronized/"

This reverts commit 3fa9fd5b2eb09d461012c832db99273bb8c5a905.

Reason for revert: Suspect cause of failure in webkit_layout_tests:
* external/wpt/2dcontext/context-attributes/getContextAttributes.html
https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/35391

Original change's description:
> WIP Canvas 2D/WebGL context: s/lowLatency/desynchronized/
>
> This CL renames s/lowLatency/desynchronized/ on web-exposed parts
> (s/low_latency/desynchronized/ internally) following [1,2] PRs
> (issue [3]), and extends wpt getContextAttributes.html.
>
> [1] whatwg/html#4360
> [2] KhronosGroup/WebGL#2753
> [3] whatwg/html#4087
>
> Bug: 944199
> Change-Id: Ic9d7bd6165f9dc9536613dc63e77b86b8ec42f7f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532920
> Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
> Commit-Queue: Miguel Casas <mcasas@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#643323}

TBR=mcasas@chromium.org,foolip@chromium.org

Change-Id: I47d31863f61a882424e06aec40e93e8bc3875849
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 944199
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534473
Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#643430}

--

wpt-commits: d62bee5a53daade043c4704dc77379bdd2db0ea8
wpt-pr: 16029
mykmelez pushed a commit to mykmelez/gecko that referenced this pull request Apr 25, 2019
…t, a=testonly

Automatic update from web-platform-tests
Extend canvas getContextAttributes WPTest

This CL extend the WPTest for Canvas getContextAttributes to include
the |desynchronized|.

This CL covers the flag WPT test extension mentioned in
whatwg/html#4360 (which addressed
whatwg/html#4087).

Bug: 944199, 945835
Change-Id: Ibb339c66014d7579023f75c7f2cef99e3f03d351
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538491
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#644332}

--

wpt-commits: c3f8e5c0bb15e7d7f57dbe60f6869caa0c4ad2e7
wpt-pr: 16084
marcoscaceres pushed a commit to web-platform-tests/wpt that referenced this pull request Jul 23, 2019
This CL renames s/lowLatency/desynchronized/ on web-exposed parts
(s/low_latency/desynchronized/ internally) following [1,2] PRs
(issue [3]), and extends wpt getContextAttributes.html.

[1] whatwg/html#4360
[2] KhronosGroup/WebGL#2753
[3] whatwg/html#4087

Bug: 944199
Change-Id: Ic9d7bd6165f9dc9536613dc63e77b86b8ec42f7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532920
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#643323}
marcoscaceres pushed a commit to web-platform-tests/wpt that referenced this pull request Jul 23, 2019
This reverts commit 3fa9fd5b2eb09d461012c832db99273bb8c5a905.

Reason for revert: Suspect cause of failure in webkit_layout_tests:
* external/wpt/2dcontext/context-attributes/getContextAttributes.html
https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/35391

Original change's description:
> WIP Canvas 2D/WebGL context: s/lowLatency/desynchronized/
>
> This CL renames s/lowLatency/desynchronized/ on web-exposed parts
> (s/low_latency/desynchronized/ internally) following [1,2] PRs
> (issue [3]), and extends wpt getContextAttributes.html.
>
> [1] whatwg/html#4360
> [2] KhronosGroup/WebGL#2753
> [3] whatwg/html#4087
>
> Bug: 944199
> Change-Id: Ic9d7bd6165f9dc9536613dc63e77b86b8ec42f7f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532920
> Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
> Commit-Queue: Miguel Casas <mcasas@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#643323}

TBR=mcasas@chromium.org,foolip@chromium.org

Change-Id: I47d31863f61a882424e06aec40e93e8bc3875849
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 944199
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534473
Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#643430}
marcoscaceres pushed a commit to web-platform-tests/wpt that referenced this pull request Jul 23, 2019
This CL extend the WPTest for Canvas getContextAttributes to include
the |desynchronized|.

This CL covers the flag WPT test extension mentioned in
whatwg/html#4360 (which addressed
whatwg/html#4087).

Bug: 944199, 945835
Change-Id: Ibb339c66014d7579023f75c7f2cef99e3f03d351
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538491
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#644332}
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 4, 2019
…y/desynchronized/, a=testonly

Automatic update from web-platform-tests
WIP Canvas 2D/WebGL context: s/lowLatency/desynchronized/

This CL renames s/lowLatency/desynchronized/ on web-exposed parts
(s/low_latency/desynchronized/ internally) following [1,2] PRs
(issue [3]), and extends wpt getContextAttributes.html.

[1] whatwg/html#4360
[2] KhronosGroup/WebGL#2753
[3] whatwg/html#4087

Bug: 944199
Change-Id: Ic9d7bd6165f9dc9536613dc63e77b86b8ec42f7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532920
Reviewed-by: Philip Jägenstedt <foolipchromium.org>
Commit-Queue: Miguel Casas <mcasaschromium.org>
Cr-Commit-Position: refs/heads/master{#643323}

--

wpt-commits: 02e61522099b874a0075d058f89b9f549563c6dc
wpt-pr: 15982

UltraBlame original commit: e67259837e8158c2f585ec79fdd5355eacadcc8b
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 4, 2019
…owLatency/desynchronized/", a=testonly

Automatic update from web-platform-tests
Revert "WIP Canvas 2D/WebGL context: s/lowLatency/desynchronized/"

This reverts commit 3fa9fd5b2eb09d461012c832db99273bb8c5a905.

Reason for revert: Suspect cause of failure in webkit_layout_tests:
* external/wpt/2dcontext/context-attributes/getContextAttributes.html
https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/35391

Original change's description:
> WIP Canvas 2D/WebGL context: s/lowLatency/desynchronized/
>
> This CL renames s/lowLatency/desynchronized/ on web-exposed parts
> (s/low_latency/desynchronized/ internally) following [1,2] PRs
> (issue [3]), and extends wpt getContextAttributes.html.
>
> [1] whatwg/html#4360
> [2] KhronosGroup/WebGL#2753
> [3] whatwg/html#4087
>
> Bug: 944199
> Change-Id: Ic9d7bd6165f9dc9536613dc63e77b86b8ec42f7f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532920
> Reviewed-by: Philip Jägenstedt <foolipchromium.org>
> Commit-Queue: Miguel Casas <mcasaschromium.org>
> Cr-Commit-Position: refs/heads/master{#643323}

TBR=mcasaschromium.org,foolipchromium.org

Change-Id: I47d31863f61a882424e06aec40e93e8bc3875849
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 944199
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534473
Reviewed-by: Fabrice de Gans-Riberi <fdeganschromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdeganschromium.org>
Cr-Commit-Position: refs/heads/master{#643430}

--

wpt-commits: d62bee5a53daade043c4704dc77379bdd2db0ea8
wpt-pr: 16029

UltraBlame original commit: 0af953b7bc949a695ba962e2eeda584175bb602b
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 4, 2019
…t, a=testonly

Automatic update from web-platform-tests
Extend canvas getContextAttributes WPTest

This CL extend the WPTest for Canvas getContextAttributes to include
the |desynchronized|.

This CL covers the flag WPT test extension mentioned in
whatwg/html#4360 (which addressed
whatwg/html#4087).

Bug: 944199, 945835
Change-Id: Ibb339c66014d7579023f75c7f2cef99e3f03d351
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538491
Reviewed-by: Fernando Serboncini <fserbchromium.org>
Commit-Queue: Miguel Casas <mcasaschromium.org>
Cr-Commit-Position: refs/heads/master{#644332}

--

wpt-commits: c3f8e5c0bb15e7d7f57dbe60f6869caa0c4ad2e7
wpt-pr: 16084

UltraBlame original commit: f0294cf3eb4247c971f3860ff55bcdfd36029b05
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 4, 2019
…y/desynchronized/, a=testonly

Automatic update from web-platform-tests
WIP Canvas 2D/WebGL context: s/lowLatency/desynchronized/

This CL renames s/lowLatency/desynchronized/ on web-exposed parts
(s/low_latency/desynchronized/ internally) following [1,2] PRs
(issue [3]), and extends wpt getContextAttributes.html.

[1] whatwg/html#4360
[2] KhronosGroup/WebGL#2753
[3] whatwg/html#4087

Bug: 944199
Change-Id: Ic9d7bd6165f9dc9536613dc63e77b86b8ec42f7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532920
Reviewed-by: Philip Jägenstedt <foolipchromium.org>
Commit-Queue: Miguel Casas <mcasaschromium.org>
Cr-Commit-Position: refs/heads/master{#643323}

--

wpt-commits: 02e61522099b874a0075d058f89b9f549563c6dc
wpt-pr: 15982

UltraBlame original commit: d693cdd0e1c8d7eb678371f465099f1400d491db
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 4, 2019
…owLatency/desynchronized/", a=testonly

Automatic update from web-platform-tests
Revert "WIP Canvas 2D/WebGL context: s/lowLatency/desynchronized/"

This reverts commit 3fa9fd5b2eb09d461012c832db99273bb8c5a905.

Reason for revert: Suspect cause of failure in webkit_layout_tests:
* external/wpt/2dcontext/context-attributes/getContextAttributes.html
https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/35391

Original change's description:
> WIP Canvas 2D/WebGL context: s/lowLatency/desynchronized/
>
> This CL renames s/lowLatency/desynchronized/ on web-exposed parts
> (s/low_latency/desynchronized/ internally) following [1,2] PRs
> (issue [3]), and extends wpt getContextAttributes.html.
>
> [1] whatwg/html#4360
> [2] KhronosGroup/WebGL#2753
> [3] whatwg/html#4087
>
> Bug: 944199
> Change-Id: Ic9d7bd6165f9dc9536613dc63e77b86b8ec42f7f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532920
> Reviewed-by: Philip Jägenstedt <foolipchromium.org>
> Commit-Queue: Miguel Casas <mcasaschromium.org>
> Cr-Commit-Position: refs/heads/master{#643323}

TBR=mcasaschromium.org,foolipchromium.org

Change-Id: I47d31863f61a882424e06aec40e93e8bc3875849
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 944199
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534473
Reviewed-by: Fabrice de Gans-Riberi <fdeganschromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdeganschromium.org>
Cr-Commit-Position: refs/heads/master{#643430}

--

wpt-commits: d62bee5a53daade043c4704dc77379bdd2db0ea8
wpt-pr: 16029

UltraBlame original commit: 420ff79bebab20b467c3cd730cdebaf2b1ef97e7
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 4, 2019
…t, a=testonly

Automatic update from web-platform-tests
Extend canvas getContextAttributes WPTest

This CL extend the WPTest for Canvas getContextAttributes to include
the |desynchronized|.

This CL covers the flag WPT test extension mentioned in
whatwg/html#4360 (which addressed
whatwg/html#4087).

Bug: 944199, 945835
Change-Id: Ibb339c66014d7579023f75c7f2cef99e3f03d351
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538491
Reviewed-by: Fernando Serboncini <fserbchromium.org>
Commit-Queue: Miguel Casas <mcasaschromium.org>
Cr-Commit-Position: refs/heads/master{#644332}

--

wpt-commits: c3f8e5c0bb15e7d7f57dbe60f6869caa0c4ad2e7
wpt-pr: 16084

UltraBlame original commit: 1c1904072b0147267351bba8d5eafee1ffad8d56
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 4, 2019
…y/desynchronized/, a=testonly

Automatic update from web-platform-tests
WIP Canvas 2D/WebGL context: s/lowLatency/desynchronized/

This CL renames s/lowLatency/desynchronized/ on web-exposed parts
(s/low_latency/desynchronized/ internally) following [1,2] PRs
(issue [3]), and extends wpt getContextAttributes.html.

[1] whatwg/html#4360
[2] KhronosGroup/WebGL#2753
[3] whatwg/html#4087

Bug: 944199
Change-Id: Ic9d7bd6165f9dc9536613dc63e77b86b8ec42f7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532920
Reviewed-by: Philip Jägenstedt <foolipchromium.org>
Commit-Queue: Miguel Casas <mcasaschromium.org>
Cr-Commit-Position: refs/heads/master{#643323}

--

wpt-commits: 02e61522099b874a0075d058f89b9f549563c6dc
wpt-pr: 15982

UltraBlame original commit: e67259837e8158c2f585ec79fdd5355eacadcc8b
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 4, 2019
…owLatency/desynchronized/", a=testonly

Automatic update from web-platform-tests
Revert "WIP Canvas 2D/WebGL context: s/lowLatency/desynchronized/"

This reverts commit 3fa9fd5b2eb09d461012c832db99273bb8c5a905.

Reason for revert: Suspect cause of failure in webkit_layout_tests:
* external/wpt/2dcontext/context-attributes/getContextAttributes.html
https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/35391

Original change's description:
> WIP Canvas 2D/WebGL context: s/lowLatency/desynchronized/
>
> This CL renames s/lowLatency/desynchronized/ on web-exposed parts
> (s/low_latency/desynchronized/ internally) following [1,2] PRs
> (issue [3]), and extends wpt getContextAttributes.html.
>
> [1] whatwg/html#4360
> [2] KhronosGroup/WebGL#2753
> [3] whatwg/html#4087
>
> Bug: 944199
> Change-Id: Ic9d7bd6165f9dc9536613dc63e77b86b8ec42f7f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532920
> Reviewed-by: Philip Jägenstedt <foolipchromium.org>
> Commit-Queue: Miguel Casas <mcasaschromium.org>
> Cr-Commit-Position: refs/heads/master{#643323}

TBR=mcasaschromium.org,foolipchromium.org

Change-Id: I47d31863f61a882424e06aec40e93e8bc3875849
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 944199
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534473
Reviewed-by: Fabrice de Gans-Riberi <fdeganschromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdeganschromium.org>
Cr-Commit-Position: refs/heads/master{#643430}

--

wpt-commits: d62bee5a53daade043c4704dc77379bdd2db0ea8
wpt-pr: 16029

UltraBlame original commit: 0af953b7bc949a695ba962e2eeda584175bb602b
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 4, 2019
…t, a=testonly

Automatic update from web-platform-tests
Extend canvas getContextAttributes WPTest

This CL extend the WPTest for Canvas getContextAttributes to include
the |desynchronized|.

This CL covers the flag WPT test extension mentioned in
whatwg/html#4360 (which addressed
whatwg/html#4087).

Bug: 944199, 945835
Change-Id: Ibb339c66014d7579023f75c7f2cef99e3f03d351
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538491
Reviewed-by: Fernando Serboncini <fserbchromium.org>
Commit-Queue: Miguel Casas <mcasaschromium.org>
Cr-Commit-Position: refs/heads/master{#644332}

--

wpt-commits: c3f8e5c0bb15e7d7f57dbe60f6869caa0c4ad2e7
wpt-pr: 16084

UltraBlame original commit: f0294cf3eb4247c971f3860ff55bcdfd36029b05
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 4, 2019
…y/desynchronized/, a=testonly

Automatic update from web-platform-tests
WIP Canvas 2D/WebGL context: s/lowLatency/desynchronized/

This CL renames s/lowLatency/desynchronized/ on web-exposed parts
(s/low_latency/desynchronized/ internally) following [1,2] PRs
(issue [3]), and extends wpt getContextAttributes.html.

[1] whatwg/html#4360
[2] KhronosGroup/WebGL#2753
[3] whatwg/html#4087

Bug: 944199
Change-Id: Ic9d7bd6165f9dc9536613dc63e77b86b8ec42f7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532920
Reviewed-by: Philip Jägenstedt <foolipchromium.org>
Commit-Queue: Miguel Casas <mcasaschromium.org>
Cr-Commit-Position: refs/heads/master{#643323}

--

wpt-commits: 02e61522099b874a0075d058f89b9f549563c6dc
wpt-pr: 15982

UltraBlame original commit: d693cdd0e1c8d7eb678371f465099f1400d491db
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 4, 2019
…owLatency/desynchronized/", a=testonly

Automatic update from web-platform-tests
Revert "WIP Canvas 2D/WebGL context: s/lowLatency/desynchronized/"

This reverts commit 3fa9fd5b2eb09d461012c832db99273bb8c5a905.

Reason for revert: Suspect cause of failure in webkit_layout_tests:
* external/wpt/2dcontext/context-attributes/getContextAttributes.html
https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/35391

Original change's description:
> WIP Canvas 2D/WebGL context: s/lowLatency/desynchronized/
>
> This CL renames s/lowLatency/desynchronized/ on web-exposed parts
> (s/low_latency/desynchronized/ internally) following [1,2] PRs
> (issue [3]), and extends wpt getContextAttributes.html.
>
> [1] whatwg/html#4360
> [2] KhronosGroup/WebGL#2753
> [3] whatwg/html#4087
>
> Bug: 944199
> Change-Id: Ic9d7bd6165f9dc9536613dc63e77b86b8ec42f7f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532920
> Reviewed-by: Philip Jägenstedt <foolipchromium.org>
> Commit-Queue: Miguel Casas <mcasaschromium.org>
> Cr-Commit-Position: refs/heads/master{#643323}

TBR=mcasaschromium.org,foolipchromium.org

Change-Id: I47d31863f61a882424e06aec40e93e8bc3875849
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 944199
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534473
Reviewed-by: Fabrice de Gans-Riberi <fdeganschromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdeganschromium.org>
Cr-Commit-Position: refs/heads/master{#643430}

--

wpt-commits: d62bee5a53daade043c4704dc77379bdd2db0ea8
wpt-pr: 16029

UltraBlame original commit: 420ff79bebab20b467c3cd730cdebaf2b1ef97e7
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 4, 2019
…t, a=testonly

Automatic update from web-platform-tests
Extend canvas getContextAttributes WPTest

This CL extend the WPTest for Canvas getContextAttributes to include
the |desynchronized|.

This CL covers the flag WPT test extension mentioned in
whatwg/html#4360 (which addressed
whatwg/html#4087).

Bug: 944199, 945835
Change-Id: Ibb339c66014d7579023f75c7f2cef99e3f03d351
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538491
Reviewed-by: Fernando Serboncini <fserbchromium.org>
Commit-Queue: Miguel Casas <mcasaschromium.org>
Cr-Commit-Position: refs/heads/master{#644332}

--

wpt-commits: c3f8e5c0bb15e7d7f57dbe60f6869caa0c4ad2e7
wpt-pr: 16084

UltraBlame original commit: 1c1904072b0147267351bba8d5eafee1ffad8d56
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 4, 2019
…y/desynchronized/, a=testonly

Automatic update from web-platform-tests
WIP Canvas 2D/WebGL context: s/lowLatency/desynchronized/

This CL renames s/lowLatency/desynchronized/ on web-exposed parts
(s/low_latency/desynchronized/ internally) following [1,2] PRs
(issue [3]), and extends wpt getContextAttributes.html.

[1] whatwg/html#4360
[2] KhronosGroup/WebGL#2753
[3] whatwg/html#4087

Bug: 944199
Change-Id: Ic9d7bd6165f9dc9536613dc63e77b86b8ec42f7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532920
Reviewed-by: Philip Jägenstedt <foolipchromium.org>
Commit-Queue: Miguel Casas <mcasaschromium.org>
Cr-Commit-Position: refs/heads/master{#643323}

--

wpt-commits: 02e61522099b874a0075d058f89b9f549563c6dc
wpt-pr: 15982

UltraBlame original commit: e67259837e8158c2f585ec79fdd5355eacadcc8b
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 4, 2019
…owLatency/desynchronized/", a=testonly

Automatic update from web-platform-tests
Revert "WIP Canvas 2D/WebGL context: s/lowLatency/desynchronized/"

This reverts commit 3fa9fd5b2eb09d461012c832db99273bb8c5a905.

Reason for revert: Suspect cause of failure in webkit_layout_tests:
* external/wpt/2dcontext/context-attributes/getContextAttributes.html
https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/35391

Original change's description:
> WIP Canvas 2D/WebGL context: s/lowLatency/desynchronized/
>
> This CL renames s/lowLatency/desynchronized/ on web-exposed parts
> (s/low_latency/desynchronized/ internally) following [1,2] PRs
> (issue [3]), and extends wpt getContextAttributes.html.
>
> [1] whatwg/html#4360
> [2] KhronosGroup/WebGL#2753
> [3] whatwg/html#4087
>
> Bug: 944199
> Change-Id: Ic9d7bd6165f9dc9536613dc63e77b86b8ec42f7f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532920
> Reviewed-by: Philip Jägenstedt <foolipchromium.org>
> Commit-Queue: Miguel Casas <mcasaschromium.org>
> Cr-Commit-Position: refs/heads/master{#643323}

TBR=mcasaschromium.org,foolipchromium.org

Change-Id: I47d31863f61a882424e06aec40e93e8bc3875849
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 944199
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534473
Reviewed-by: Fabrice de Gans-Riberi <fdeganschromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdeganschromium.org>
Cr-Commit-Position: refs/heads/master{#643430}

--

wpt-commits: d62bee5a53daade043c4704dc77379bdd2db0ea8
wpt-pr: 16029

UltraBlame original commit: 0af953b7bc949a695ba962e2eeda584175bb602b
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 4, 2019
…t, a=testonly

Automatic update from web-platform-tests
Extend canvas getContextAttributes WPTest

This CL extend the WPTest for Canvas getContextAttributes to include
the |desynchronized|.

This CL covers the flag WPT test extension mentioned in
whatwg/html#4360 (which addressed
whatwg/html#4087).

Bug: 944199, 945835
Change-Id: Ibb339c66014d7579023f75c7f2cef99e3f03d351
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538491
Reviewed-by: Fernando Serboncini <fserbchromium.org>
Commit-Queue: Miguel Casas <mcasaschromium.org>
Cr-Commit-Position: refs/heads/master{#644332}

--

wpt-commits: c3f8e5c0bb15e7d7f57dbe60f6869caa0c4ad2e7
wpt-pr: 16084

UltraBlame original commit: f0294cf3eb4247c971f3860ff55bcdfd36029b05
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 4, 2019
…y/desynchronized/, a=testonly

Automatic update from web-platform-tests
WIP Canvas 2D/WebGL context: s/lowLatency/desynchronized/

This CL renames s/lowLatency/desynchronized/ on web-exposed parts
(s/low_latency/desynchronized/ internally) following [1,2] PRs
(issue [3]), and extends wpt getContextAttributes.html.

[1] whatwg/html#4360
[2] KhronosGroup/WebGL#2753
[3] whatwg/html#4087

Bug: 944199
Change-Id: Ic9d7bd6165f9dc9536613dc63e77b86b8ec42f7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532920
Reviewed-by: Philip Jägenstedt <foolipchromium.org>
Commit-Queue: Miguel Casas <mcasaschromium.org>
Cr-Commit-Position: refs/heads/master{#643323}

--

wpt-commits: 02e61522099b874a0075d058f89b9f549563c6dc
wpt-pr: 15982

UltraBlame original commit: d693cdd0e1c8d7eb678371f465099f1400d491db
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 4, 2019
…owLatency/desynchronized/", a=testonly

Automatic update from web-platform-tests
Revert "WIP Canvas 2D/WebGL context: s/lowLatency/desynchronized/"

This reverts commit 3fa9fd5b2eb09d461012c832db99273bb8c5a905.

Reason for revert: Suspect cause of failure in webkit_layout_tests:
* external/wpt/2dcontext/context-attributes/getContextAttributes.html
https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/35391

Original change's description:
> WIP Canvas 2D/WebGL context: s/lowLatency/desynchronized/
>
> This CL renames s/lowLatency/desynchronized/ on web-exposed parts
> (s/low_latency/desynchronized/ internally) following [1,2] PRs
> (issue [3]), and extends wpt getContextAttributes.html.
>
> [1] whatwg/html#4360
> [2] KhronosGroup/WebGL#2753
> [3] whatwg/html#4087
>
> Bug: 944199
> Change-Id: Ic9d7bd6165f9dc9536613dc63e77b86b8ec42f7f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532920
> Reviewed-by: Philip Jägenstedt <foolipchromium.org>
> Commit-Queue: Miguel Casas <mcasaschromium.org>
> Cr-Commit-Position: refs/heads/master{#643323}

TBR=mcasaschromium.org,foolipchromium.org

Change-Id: I47d31863f61a882424e06aec40e93e8bc3875849
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 944199
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534473
Reviewed-by: Fabrice de Gans-Riberi <fdeganschromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdeganschromium.org>
Cr-Commit-Position: refs/heads/master{#643430}

--

wpt-commits: d62bee5a53daade043c4704dc77379bdd2db0ea8
wpt-pr: 16029

UltraBlame original commit: 420ff79bebab20b467c3cd730cdebaf2b1ef97e7
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 4, 2019
…t, a=testonly

Automatic update from web-platform-tests
Extend canvas getContextAttributes WPTest

This CL extend the WPTest for Canvas getContextAttributes to include
the |desynchronized|.

This CL covers the flag WPT test extension mentioned in
whatwg/html#4360 (which addressed
whatwg/html#4087).

Bug: 944199, 945835
Change-Id: Ibb339c66014d7579023f75c7f2cef99e3f03d351
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538491
Reviewed-by: Fernando Serboncini <fserbchromium.org>
Commit-Queue: Miguel Casas <mcasaschromium.org>
Cr-Commit-Position: refs/heads/master{#644332}

--

wpt-commits: c3f8e5c0bb15e7d7f57dbe60f6869caa0c4ad2e7
wpt-pr: 16084

UltraBlame original commit: 1c1904072b0147267351bba8d5eafee1ffad8d56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addition/proposal New features or enhancements impacts documentation Used by documentation communities, such as MDN, to track changes that impact documentation topic: canvas
Development

Successfully merging this pull request may close these issues.

7 participants