-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lowLatency flag to CanvasRenderingContext2DSettings #4360
Add lowLatency flag to CanvasRenderingContext2DSettings #4360
Conversation
Developers of stylus-based drawing applications (e.g. Google Keep) have found this hint to be critical in order to be competitive with native applications. It has been prototyped in Chromium and yields significant latency improvements there. Partial fix for whatwg#4087.
@annevk, @kenrussell, @jrmuizel, @grorg, @travisleithead, @fserb Gathering a wee bit the status: With that I'd say the best flag name might be Of course the PR should reflect this tradeoff, if at least in some informatiional non-normative note. |
It's all personal preference, but I like |
I'll just note that boolean dictionary values should default to false, so all of @kenrussell's latest suggestions are good in that regard (as is the OP (Yes, |
|
I generally do prefer |
So, |
@YellowDoge I wrote in the previous PR for this that I don't really understand what this does, and I feel a bit more confused after your explanation. Some specific questions that came to mind:
|
The name seems fine to me, but I'm a bit surprised @othermaciej's feedback on the prior PR went unaddressed. I'll try to be more careful ensuring all loose ends are tied up when we switch the place of discussion. |
I thought it better to agree on a name for the new functionality before even getting to writing the spec patch, since the former will (greatly) affect the latter. I can reply here to two of the concrete comments from #4360 (comment):
Why not? If we want to decrease latency between input event and pixels on screen, this is one of the sources of delay to cut on. Moreover, some elements (like
Yes, in my coarse description in #4360 (comment), there's nothing ChromeOS specific, and as a matter of fact we're exploring the implementation on Windows. |
Folks I've uploaded a new version of the patch where hopefully things are clearer. I'm using the term |
The name seems fine to me.
I was similarly confused, but after @YellowDoge's answer, I understand now that there's no feature work to directly impact how input events are dispatched and processed, rather he meant that from the perspective of elapsed time, if the Javascript code that runs as a result of an input event being dispatched is able to send instructions to a canvas element that is, in turn, rendered to the screen more immediately (due to this feature), then this is a net improvement in the overall time to "process" an input event. If I'm still mistaken, let me know. |
The new spec diff says this (emphasis added)
This totally sounds like it would affect input event processing. It describes this as a separate change from the rendering change that is also controlled by the flag. (And it doesn't have enough info to interoperably implement this alternate event processing, if that is what it's supposed to mean). @YellowDoge can you clarify? Is this flag meant to affect event processing, and not just rendering? |
Yes, as it says :
Reducing the latency can be achieved by reducing any of its components, namely: (a) input event delivery, (b) app logic processing, (c) drawing of the canvas (== execution of the drawing commands), and (d) OS rendering. If any of them is reduced, then the overall latency is reduced, right? Depending on the UA and OS capabilities, reduction of the latency can be done in several ways: reducing (a), reducing (c), reducing (d) or any combination of those. The flag is a hint -- but if the UA is absolutely unable to improve (== reduce) he latency as defined before, then |
Can we drop the 'changes input event processing' part? It seems like the primary adjustment we're making here is to desynchronize from the normal DOM update presentation atomicity. Is there a need to go further than that right now, or can we move forward with just desynchronization from DOM update presentation atomicity? |
I tend to agree with @jdashg . Changing input event processing is pretty concerning here, and it seems better left out. Reasoning:
An alternative would be to specify what the alternate event handling behavior is, in a way that is precise enough to make test cases (even if it is a MAY-level requirement). |
Further question about the term "front buffer rendering": could this also be accurately described as "single buffering" or "bypassing double/triple buffering"? I tried to look up resources on it and it sounds the same, but I might be missing a subtle difference. I ask because "single buffering" seems to be a more common term than "front buffer rendering", at least based on search engine frequency. |
Guys PTAL:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small nit, but otherwise looks good.
Aside: please don't use "guys". |
…owLatency/desynchronized/", a=testonly Automatic update from web-platform-tests Revert "WIP Canvas 2D/WebGL context: s/lowLatency/desynchronized/" This reverts commit 3fa9fd5b2eb09d461012c832db99273bb8c5a905. Reason for revert: Suspect cause of failure in webkit_layout_tests: * external/wpt/2dcontext/context-attributes/getContextAttributes.html https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/35391 Original change's description: > WIP Canvas 2D/WebGL context: s/lowLatency/desynchronized/ > > This CL renames s/lowLatency/desynchronized/ on web-exposed parts > (s/low_latency/desynchronized/ internally) following [1,2] PRs > (issue [3]), and extends wpt getContextAttributes.html. > > [1] whatwg/html#4360 > [2] KhronosGroup/WebGL#2753 > [3] whatwg/html#4087 > > Bug: 944199 > Change-Id: Ic9d7bd6165f9dc9536613dc63e77b86b8ec42f7f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532920 > Reviewed-by: Philip Jägenstedt <foolip@chromium.org> > Commit-Queue: Miguel Casas <mcasas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#643323} TBR=mcasas@chromium.org,foolip@chromium.org Change-Id: I47d31863f61a882424e06aec40e93e8bc3875849 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 944199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534473 Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#643430} -- wpt-commits: d62bee5a53daade043c4704dc77379bdd2db0ea8 wpt-pr: 16029
…t, a=testonly Automatic update from web-platform-tests Extend canvas getContextAttributes WPTest This CL extend the WPTest for Canvas getContextAttributes to include the |desynchronized|. This CL covers the flag WPT test extension mentioned in whatwg/html#4360 (which addressed whatwg/html#4087). Bug: 944199, 945835 Change-Id: Ibb339c66014d7579023f75c7f2cef99e3f03d351 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538491 Reviewed-by: Fernando Serboncini <fserb@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#644332} -- wpt-commits: c3f8e5c0bb15e7d7f57dbe60f6869caa0c4ad2e7 wpt-pr: 16084
…y/desynchronized/, a=testonly Automatic update from web-platform-tests WIP Canvas 2D/WebGL context: s/lowLatency/desynchronized/ This CL renames s/lowLatency/desynchronized/ on web-exposed parts (s/low_latency/desynchronized/ internally) following [1,2] PRs (issue [3]), and extends wpt getContextAttributes.html. [1] whatwg/html#4360 [2] KhronosGroup/WebGL#2753 [3] whatwg/html#4087 Bug: 944199 Change-Id: Ic9d7bd6165f9dc9536613dc63e77b86b8ec42f7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532920 Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#643323} -- wpt-commits: 02e61522099b874a0075d058f89b9f549563c6dc wpt-pr: 15982
…owLatency/desynchronized/", a=testonly Automatic update from web-platform-tests Revert "WIP Canvas 2D/WebGL context: s/lowLatency/desynchronized/" This reverts commit 3fa9fd5b2eb09d461012c832db99273bb8c5a905. Reason for revert: Suspect cause of failure in webkit_layout_tests: * external/wpt/2dcontext/context-attributes/getContextAttributes.html https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/35391 Original change's description: > WIP Canvas 2D/WebGL context: s/lowLatency/desynchronized/ > > This CL renames s/lowLatency/desynchronized/ on web-exposed parts > (s/low_latency/desynchronized/ internally) following [1,2] PRs > (issue [3]), and extends wpt getContextAttributes.html. > > [1] whatwg/html#4360 > [2] KhronosGroup/WebGL#2753 > [3] whatwg/html#4087 > > Bug: 944199 > Change-Id: Ic9d7bd6165f9dc9536613dc63e77b86b8ec42f7f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532920 > Reviewed-by: Philip Jägenstedt <foolip@chromium.org> > Commit-Queue: Miguel Casas <mcasas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#643323} TBR=mcasas@chromium.org,foolip@chromium.org Change-Id: I47d31863f61a882424e06aec40e93e8bc3875849 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 944199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534473 Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#643430} -- wpt-commits: d62bee5a53daade043c4704dc77379bdd2db0ea8 wpt-pr: 16029
…t, a=testonly Automatic update from web-platform-tests Extend canvas getContextAttributes WPTest This CL extend the WPTest for Canvas getContextAttributes to include the |desynchronized|. This CL covers the flag WPT test extension mentioned in whatwg/html#4360 (which addressed whatwg/html#4087). Bug: 944199, 945835 Change-Id: Ibb339c66014d7579023f75c7f2cef99e3f03d351 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538491 Reviewed-by: Fernando Serboncini <fserb@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#644332} -- wpt-commits: c3f8e5c0bb15e7d7f57dbe60f6869caa0c4ad2e7 wpt-pr: 16084
This CL renames s/lowLatency/desynchronized/ on web-exposed parts (s/low_latency/desynchronized/ internally) following [1,2] PRs (issue [3]), and extends wpt getContextAttributes.html. [1] whatwg/html#4360 [2] KhronosGroup/WebGL#2753 [3] whatwg/html#4087 Bug: 944199 Change-Id: Ic9d7bd6165f9dc9536613dc63e77b86b8ec42f7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532920 Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#643323}
This reverts commit 3fa9fd5b2eb09d461012c832db99273bb8c5a905. Reason for revert: Suspect cause of failure in webkit_layout_tests: * external/wpt/2dcontext/context-attributes/getContextAttributes.html https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/35391 Original change's description: > WIP Canvas 2D/WebGL context: s/lowLatency/desynchronized/ > > This CL renames s/lowLatency/desynchronized/ on web-exposed parts > (s/low_latency/desynchronized/ internally) following [1,2] PRs > (issue [3]), and extends wpt getContextAttributes.html. > > [1] whatwg/html#4360 > [2] KhronosGroup/WebGL#2753 > [3] whatwg/html#4087 > > Bug: 944199 > Change-Id: Ic9d7bd6165f9dc9536613dc63e77b86b8ec42f7f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532920 > Reviewed-by: Philip Jägenstedt <foolip@chromium.org> > Commit-Queue: Miguel Casas <mcasas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#643323} TBR=mcasas@chromium.org,foolip@chromium.org Change-Id: I47d31863f61a882424e06aec40e93e8bc3875849 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 944199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534473 Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#643430}
This CL extend the WPTest for Canvas getContextAttributes to include the |desynchronized|. This CL covers the flag WPT test extension mentioned in whatwg/html#4360 (which addressed whatwg/html#4087). Bug: 944199, 945835 Change-Id: Ibb339c66014d7579023f75c7f2cef99e3f03d351 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538491 Reviewed-by: Fernando Serboncini <fserb@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#644332}
…y/desynchronized/, a=testonly Automatic update from web-platform-tests WIP Canvas 2D/WebGL context: s/lowLatency/desynchronized/ This CL renames s/lowLatency/desynchronized/ on web-exposed parts (s/low_latency/desynchronized/ internally) following [1,2] PRs (issue [3]), and extends wpt getContextAttributes.html. [1] whatwg/html#4360 [2] KhronosGroup/WebGL#2753 [3] whatwg/html#4087 Bug: 944199 Change-Id: Ic9d7bd6165f9dc9536613dc63e77b86b8ec42f7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532920 Reviewed-by: Philip Jägenstedt <foolipchromium.org> Commit-Queue: Miguel Casas <mcasaschromium.org> Cr-Commit-Position: refs/heads/master{#643323} -- wpt-commits: 02e61522099b874a0075d058f89b9f549563c6dc wpt-pr: 15982 UltraBlame original commit: e67259837e8158c2f585ec79fdd5355eacadcc8b
…owLatency/desynchronized/", a=testonly Automatic update from web-platform-tests Revert "WIP Canvas 2D/WebGL context: s/lowLatency/desynchronized/" This reverts commit 3fa9fd5b2eb09d461012c832db99273bb8c5a905. Reason for revert: Suspect cause of failure in webkit_layout_tests: * external/wpt/2dcontext/context-attributes/getContextAttributes.html https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/35391 Original change's description: > WIP Canvas 2D/WebGL context: s/lowLatency/desynchronized/ > > This CL renames s/lowLatency/desynchronized/ on web-exposed parts > (s/low_latency/desynchronized/ internally) following [1,2] PRs > (issue [3]), and extends wpt getContextAttributes.html. > > [1] whatwg/html#4360 > [2] KhronosGroup/WebGL#2753 > [3] whatwg/html#4087 > > Bug: 944199 > Change-Id: Ic9d7bd6165f9dc9536613dc63e77b86b8ec42f7f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532920 > Reviewed-by: Philip Jägenstedt <foolipchromium.org> > Commit-Queue: Miguel Casas <mcasaschromium.org> > Cr-Commit-Position: refs/heads/master{#643323} TBR=mcasaschromium.org,foolipchromium.org Change-Id: I47d31863f61a882424e06aec40e93e8bc3875849 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 944199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534473 Reviewed-by: Fabrice de Gans-Riberi <fdeganschromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdeganschromium.org> Cr-Commit-Position: refs/heads/master{#643430} -- wpt-commits: d62bee5a53daade043c4704dc77379bdd2db0ea8 wpt-pr: 16029 UltraBlame original commit: 0af953b7bc949a695ba962e2eeda584175bb602b
…t, a=testonly Automatic update from web-platform-tests Extend canvas getContextAttributes WPTest This CL extend the WPTest for Canvas getContextAttributes to include the |desynchronized|. This CL covers the flag WPT test extension mentioned in whatwg/html#4360 (which addressed whatwg/html#4087). Bug: 944199, 945835 Change-Id: Ibb339c66014d7579023f75c7f2cef99e3f03d351 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538491 Reviewed-by: Fernando Serboncini <fserbchromium.org> Commit-Queue: Miguel Casas <mcasaschromium.org> Cr-Commit-Position: refs/heads/master{#644332} -- wpt-commits: c3f8e5c0bb15e7d7f57dbe60f6869caa0c4ad2e7 wpt-pr: 16084 UltraBlame original commit: f0294cf3eb4247c971f3860ff55bcdfd36029b05
…y/desynchronized/, a=testonly Automatic update from web-platform-tests WIP Canvas 2D/WebGL context: s/lowLatency/desynchronized/ This CL renames s/lowLatency/desynchronized/ on web-exposed parts (s/low_latency/desynchronized/ internally) following [1,2] PRs (issue [3]), and extends wpt getContextAttributes.html. [1] whatwg/html#4360 [2] KhronosGroup/WebGL#2753 [3] whatwg/html#4087 Bug: 944199 Change-Id: Ic9d7bd6165f9dc9536613dc63e77b86b8ec42f7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532920 Reviewed-by: Philip Jägenstedt <foolipchromium.org> Commit-Queue: Miguel Casas <mcasaschromium.org> Cr-Commit-Position: refs/heads/master{#643323} -- wpt-commits: 02e61522099b874a0075d058f89b9f549563c6dc wpt-pr: 15982 UltraBlame original commit: d693cdd0e1c8d7eb678371f465099f1400d491db
…owLatency/desynchronized/", a=testonly Automatic update from web-platform-tests Revert "WIP Canvas 2D/WebGL context: s/lowLatency/desynchronized/" This reverts commit 3fa9fd5b2eb09d461012c832db99273bb8c5a905. Reason for revert: Suspect cause of failure in webkit_layout_tests: * external/wpt/2dcontext/context-attributes/getContextAttributes.html https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/35391 Original change's description: > WIP Canvas 2D/WebGL context: s/lowLatency/desynchronized/ > > This CL renames s/lowLatency/desynchronized/ on web-exposed parts > (s/low_latency/desynchronized/ internally) following [1,2] PRs > (issue [3]), and extends wpt getContextAttributes.html. > > [1] whatwg/html#4360 > [2] KhronosGroup/WebGL#2753 > [3] whatwg/html#4087 > > Bug: 944199 > Change-Id: Ic9d7bd6165f9dc9536613dc63e77b86b8ec42f7f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532920 > Reviewed-by: Philip Jägenstedt <foolipchromium.org> > Commit-Queue: Miguel Casas <mcasaschromium.org> > Cr-Commit-Position: refs/heads/master{#643323} TBR=mcasaschromium.org,foolipchromium.org Change-Id: I47d31863f61a882424e06aec40e93e8bc3875849 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 944199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534473 Reviewed-by: Fabrice de Gans-Riberi <fdeganschromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdeganschromium.org> Cr-Commit-Position: refs/heads/master{#643430} -- wpt-commits: d62bee5a53daade043c4704dc77379bdd2db0ea8 wpt-pr: 16029 UltraBlame original commit: 420ff79bebab20b467c3cd730cdebaf2b1ef97e7
…t, a=testonly Automatic update from web-platform-tests Extend canvas getContextAttributes WPTest This CL extend the WPTest for Canvas getContextAttributes to include the |desynchronized|. This CL covers the flag WPT test extension mentioned in whatwg/html#4360 (which addressed whatwg/html#4087). Bug: 944199, 945835 Change-Id: Ibb339c66014d7579023f75c7f2cef99e3f03d351 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538491 Reviewed-by: Fernando Serboncini <fserbchromium.org> Commit-Queue: Miguel Casas <mcasaschromium.org> Cr-Commit-Position: refs/heads/master{#644332} -- wpt-commits: c3f8e5c0bb15e7d7f57dbe60f6869caa0c4ad2e7 wpt-pr: 16084 UltraBlame original commit: 1c1904072b0147267351bba8d5eafee1ffad8d56
…y/desynchronized/, a=testonly Automatic update from web-platform-tests WIP Canvas 2D/WebGL context: s/lowLatency/desynchronized/ This CL renames s/lowLatency/desynchronized/ on web-exposed parts (s/low_latency/desynchronized/ internally) following [1,2] PRs (issue [3]), and extends wpt getContextAttributes.html. [1] whatwg/html#4360 [2] KhronosGroup/WebGL#2753 [3] whatwg/html#4087 Bug: 944199 Change-Id: Ic9d7bd6165f9dc9536613dc63e77b86b8ec42f7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532920 Reviewed-by: Philip Jägenstedt <foolipchromium.org> Commit-Queue: Miguel Casas <mcasaschromium.org> Cr-Commit-Position: refs/heads/master{#643323} -- wpt-commits: 02e61522099b874a0075d058f89b9f549563c6dc wpt-pr: 15982 UltraBlame original commit: e67259837e8158c2f585ec79fdd5355eacadcc8b
…owLatency/desynchronized/", a=testonly Automatic update from web-platform-tests Revert "WIP Canvas 2D/WebGL context: s/lowLatency/desynchronized/" This reverts commit 3fa9fd5b2eb09d461012c832db99273bb8c5a905. Reason for revert: Suspect cause of failure in webkit_layout_tests: * external/wpt/2dcontext/context-attributes/getContextAttributes.html https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/35391 Original change's description: > WIP Canvas 2D/WebGL context: s/lowLatency/desynchronized/ > > This CL renames s/lowLatency/desynchronized/ on web-exposed parts > (s/low_latency/desynchronized/ internally) following [1,2] PRs > (issue [3]), and extends wpt getContextAttributes.html. > > [1] whatwg/html#4360 > [2] KhronosGroup/WebGL#2753 > [3] whatwg/html#4087 > > Bug: 944199 > Change-Id: Ic9d7bd6165f9dc9536613dc63e77b86b8ec42f7f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532920 > Reviewed-by: Philip Jägenstedt <foolipchromium.org> > Commit-Queue: Miguel Casas <mcasaschromium.org> > Cr-Commit-Position: refs/heads/master{#643323} TBR=mcasaschromium.org,foolipchromium.org Change-Id: I47d31863f61a882424e06aec40e93e8bc3875849 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 944199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534473 Reviewed-by: Fabrice de Gans-Riberi <fdeganschromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdeganschromium.org> Cr-Commit-Position: refs/heads/master{#643430} -- wpt-commits: d62bee5a53daade043c4704dc77379bdd2db0ea8 wpt-pr: 16029 UltraBlame original commit: 0af953b7bc949a695ba962e2eeda584175bb602b
…t, a=testonly Automatic update from web-platform-tests Extend canvas getContextAttributes WPTest This CL extend the WPTest for Canvas getContextAttributes to include the |desynchronized|. This CL covers the flag WPT test extension mentioned in whatwg/html#4360 (which addressed whatwg/html#4087). Bug: 944199, 945835 Change-Id: Ibb339c66014d7579023f75c7f2cef99e3f03d351 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538491 Reviewed-by: Fernando Serboncini <fserbchromium.org> Commit-Queue: Miguel Casas <mcasaschromium.org> Cr-Commit-Position: refs/heads/master{#644332} -- wpt-commits: c3f8e5c0bb15e7d7f57dbe60f6869caa0c4ad2e7 wpt-pr: 16084 UltraBlame original commit: f0294cf3eb4247c971f3860ff55bcdfd36029b05
…y/desynchronized/, a=testonly Automatic update from web-platform-tests WIP Canvas 2D/WebGL context: s/lowLatency/desynchronized/ This CL renames s/lowLatency/desynchronized/ on web-exposed parts (s/low_latency/desynchronized/ internally) following [1,2] PRs (issue [3]), and extends wpt getContextAttributes.html. [1] whatwg/html#4360 [2] KhronosGroup/WebGL#2753 [3] whatwg/html#4087 Bug: 944199 Change-Id: Ic9d7bd6165f9dc9536613dc63e77b86b8ec42f7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532920 Reviewed-by: Philip Jägenstedt <foolipchromium.org> Commit-Queue: Miguel Casas <mcasaschromium.org> Cr-Commit-Position: refs/heads/master{#643323} -- wpt-commits: 02e61522099b874a0075d058f89b9f549563c6dc wpt-pr: 15982 UltraBlame original commit: d693cdd0e1c8d7eb678371f465099f1400d491db
…owLatency/desynchronized/", a=testonly Automatic update from web-platform-tests Revert "WIP Canvas 2D/WebGL context: s/lowLatency/desynchronized/" This reverts commit 3fa9fd5b2eb09d461012c832db99273bb8c5a905. Reason for revert: Suspect cause of failure in webkit_layout_tests: * external/wpt/2dcontext/context-attributes/getContextAttributes.html https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/35391 Original change's description: > WIP Canvas 2D/WebGL context: s/lowLatency/desynchronized/ > > This CL renames s/lowLatency/desynchronized/ on web-exposed parts > (s/low_latency/desynchronized/ internally) following [1,2] PRs > (issue [3]), and extends wpt getContextAttributes.html. > > [1] whatwg/html#4360 > [2] KhronosGroup/WebGL#2753 > [3] whatwg/html#4087 > > Bug: 944199 > Change-Id: Ic9d7bd6165f9dc9536613dc63e77b86b8ec42f7f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532920 > Reviewed-by: Philip Jägenstedt <foolipchromium.org> > Commit-Queue: Miguel Casas <mcasaschromium.org> > Cr-Commit-Position: refs/heads/master{#643323} TBR=mcasaschromium.org,foolipchromium.org Change-Id: I47d31863f61a882424e06aec40e93e8bc3875849 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 944199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534473 Reviewed-by: Fabrice de Gans-Riberi <fdeganschromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdeganschromium.org> Cr-Commit-Position: refs/heads/master{#643430} -- wpt-commits: d62bee5a53daade043c4704dc77379bdd2db0ea8 wpt-pr: 16029 UltraBlame original commit: 420ff79bebab20b467c3cd730cdebaf2b1ef97e7
…t, a=testonly Automatic update from web-platform-tests Extend canvas getContextAttributes WPTest This CL extend the WPTest for Canvas getContextAttributes to include the |desynchronized|. This CL covers the flag WPT test extension mentioned in whatwg/html#4360 (which addressed whatwg/html#4087). Bug: 944199, 945835 Change-Id: Ibb339c66014d7579023f75c7f2cef99e3f03d351 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538491 Reviewed-by: Fernando Serboncini <fserbchromium.org> Commit-Queue: Miguel Casas <mcasaschromium.org> Cr-Commit-Position: refs/heads/master{#644332} -- wpt-commits: c3f8e5c0bb15e7d7f57dbe60f6869caa0c4ad2e7 wpt-pr: 16084 UltraBlame original commit: 1c1904072b0147267351bba8d5eafee1ffad8d56
…y/desynchronized/, a=testonly Automatic update from web-platform-tests WIP Canvas 2D/WebGL context: s/lowLatency/desynchronized/ This CL renames s/lowLatency/desynchronized/ on web-exposed parts (s/low_latency/desynchronized/ internally) following [1,2] PRs (issue [3]), and extends wpt getContextAttributes.html. [1] whatwg/html#4360 [2] KhronosGroup/WebGL#2753 [3] whatwg/html#4087 Bug: 944199 Change-Id: Ic9d7bd6165f9dc9536613dc63e77b86b8ec42f7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532920 Reviewed-by: Philip Jägenstedt <foolipchromium.org> Commit-Queue: Miguel Casas <mcasaschromium.org> Cr-Commit-Position: refs/heads/master{#643323} -- wpt-commits: 02e61522099b874a0075d058f89b9f549563c6dc wpt-pr: 15982 UltraBlame original commit: e67259837e8158c2f585ec79fdd5355eacadcc8b
…owLatency/desynchronized/", a=testonly Automatic update from web-platform-tests Revert "WIP Canvas 2D/WebGL context: s/lowLatency/desynchronized/" This reverts commit 3fa9fd5b2eb09d461012c832db99273bb8c5a905. Reason for revert: Suspect cause of failure in webkit_layout_tests: * external/wpt/2dcontext/context-attributes/getContextAttributes.html https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/35391 Original change's description: > WIP Canvas 2D/WebGL context: s/lowLatency/desynchronized/ > > This CL renames s/lowLatency/desynchronized/ on web-exposed parts > (s/low_latency/desynchronized/ internally) following [1,2] PRs > (issue [3]), and extends wpt getContextAttributes.html. > > [1] whatwg/html#4360 > [2] KhronosGroup/WebGL#2753 > [3] whatwg/html#4087 > > Bug: 944199 > Change-Id: Ic9d7bd6165f9dc9536613dc63e77b86b8ec42f7f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532920 > Reviewed-by: Philip Jägenstedt <foolipchromium.org> > Commit-Queue: Miguel Casas <mcasaschromium.org> > Cr-Commit-Position: refs/heads/master{#643323} TBR=mcasaschromium.org,foolipchromium.org Change-Id: I47d31863f61a882424e06aec40e93e8bc3875849 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 944199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534473 Reviewed-by: Fabrice de Gans-Riberi <fdeganschromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdeganschromium.org> Cr-Commit-Position: refs/heads/master{#643430} -- wpt-commits: d62bee5a53daade043c4704dc77379bdd2db0ea8 wpt-pr: 16029 UltraBlame original commit: 0af953b7bc949a695ba962e2eeda584175bb602b
…t, a=testonly Automatic update from web-platform-tests Extend canvas getContextAttributes WPTest This CL extend the WPTest for Canvas getContextAttributes to include the |desynchronized|. This CL covers the flag WPT test extension mentioned in whatwg/html#4360 (which addressed whatwg/html#4087). Bug: 944199, 945835 Change-Id: Ibb339c66014d7579023f75c7f2cef99e3f03d351 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538491 Reviewed-by: Fernando Serboncini <fserbchromium.org> Commit-Queue: Miguel Casas <mcasaschromium.org> Cr-Commit-Position: refs/heads/master{#644332} -- wpt-commits: c3f8e5c0bb15e7d7f57dbe60f6869caa0c4ad2e7 wpt-pr: 16084 UltraBlame original commit: f0294cf3eb4247c971f3860ff55bcdfd36029b05
…y/desynchronized/, a=testonly Automatic update from web-platform-tests WIP Canvas 2D/WebGL context: s/lowLatency/desynchronized/ This CL renames s/lowLatency/desynchronized/ on web-exposed parts (s/low_latency/desynchronized/ internally) following [1,2] PRs (issue [3]), and extends wpt getContextAttributes.html. [1] whatwg/html#4360 [2] KhronosGroup/WebGL#2753 [3] whatwg/html#4087 Bug: 944199 Change-Id: Ic9d7bd6165f9dc9536613dc63e77b86b8ec42f7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532920 Reviewed-by: Philip Jägenstedt <foolipchromium.org> Commit-Queue: Miguel Casas <mcasaschromium.org> Cr-Commit-Position: refs/heads/master{#643323} -- wpt-commits: 02e61522099b874a0075d058f89b9f549563c6dc wpt-pr: 15982 UltraBlame original commit: d693cdd0e1c8d7eb678371f465099f1400d491db
…owLatency/desynchronized/", a=testonly Automatic update from web-platform-tests Revert "WIP Canvas 2D/WebGL context: s/lowLatency/desynchronized/" This reverts commit 3fa9fd5b2eb09d461012c832db99273bb8c5a905. Reason for revert: Suspect cause of failure in webkit_layout_tests: * external/wpt/2dcontext/context-attributes/getContextAttributes.html https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/35391 Original change's description: > WIP Canvas 2D/WebGL context: s/lowLatency/desynchronized/ > > This CL renames s/lowLatency/desynchronized/ on web-exposed parts > (s/low_latency/desynchronized/ internally) following [1,2] PRs > (issue [3]), and extends wpt getContextAttributes.html. > > [1] whatwg/html#4360 > [2] KhronosGroup/WebGL#2753 > [3] whatwg/html#4087 > > Bug: 944199 > Change-Id: Ic9d7bd6165f9dc9536613dc63e77b86b8ec42f7f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532920 > Reviewed-by: Philip Jägenstedt <foolipchromium.org> > Commit-Queue: Miguel Casas <mcasaschromium.org> > Cr-Commit-Position: refs/heads/master{#643323} TBR=mcasaschromium.org,foolipchromium.org Change-Id: I47d31863f61a882424e06aec40e93e8bc3875849 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 944199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534473 Reviewed-by: Fabrice de Gans-Riberi <fdeganschromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdeganschromium.org> Cr-Commit-Position: refs/heads/master{#643430} -- wpt-commits: d62bee5a53daade043c4704dc77379bdd2db0ea8 wpt-pr: 16029 UltraBlame original commit: 420ff79bebab20b467c3cd730cdebaf2b1ef97e7
…t, a=testonly Automatic update from web-platform-tests Extend canvas getContextAttributes WPTest This CL extend the WPTest for Canvas getContextAttributes to include the |desynchronized|. This CL covers the flag WPT test extension mentioned in whatwg/html#4360 (which addressed whatwg/html#4087). Bug: 944199, 945835 Change-Id: Ibb339c66014d7579023f75c7f2cef99e3f03d351 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538491 Reviewed-by: Fernando Serboncini <fserbchromium.org> Commit-Queue: Miguel Casas <mcasaschromium.org> Cr-Commit-Position: refs/heads/master{#644332} -- wpt-commits: c3f8e5c0bb15e7d7f57dbe60f6869caa0c4ad2e7 wpt-pr: 16084 UltraBlame original commit: 1c1904072b0147267351bba8d5eafee1ffad8d56
This is a duplicate of the current state of @kenrussell's #4234 PR (that partially addresses #4087), so I can take it over from here.
Note that this PR is blocking KhronosGroup/WebGL#2753.
/canvas.html ( diff )
/references.html ( diff )