Tie BarProp object lifetime to the Window object #4430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also describe what happens when the browsing context is discarded. Tests: web-platform-tests/wpt#15815. Fixes #2579.
domenic
approved these changes
Mar 13, 2019
| <dd>Represents the user interface element found immediately above or before the document, as | ||
| appropriate for the user's media, which typically provides <span>session history</span> traversal | ||
| controls (back and forward buttons, reload buttons, etc). If the user agent has no such user | ||
| interface element, then the object may act as if the corresponding user interface element was | ||
| absent (i.e. its <code data-x="dom-BarProp-visible">visible</code> attribute may return | ||
| false).</dd> | ||
|
|
||
| </dl> | ||
|
|
||
| <p>The <dfn><code data-x="dom-window-locationbar">locationbar</code></dfn> attribute must return |
There was a problem hiding this comment.
I intentionally didn't because I assume #4431 will touch these.
|
Yeah, in particular the |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also describe what happens when the browsing context is discarded.
Tests: web-platform-tests/wpt#15815.
Fixes #2579.
/window-object.html ( diff )