emit counter metric on soft/hard limit breached #892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fisx
force-pushed
the
feature/gundeck-more-metrics
branch
from
2c8d767 to
cda229f
Compare
fisx
approved these changes
Oct 25, 2019
| oldsize | ||
| let softLimitBreached = (maybe False (oldsize >=) (limits ^. limitSoft)) | ||
| hardLimitBreached = (maybe False (oldsize >=) (limits ^. limitHard)) | ||
| warnNoBudget softLimitBreached hardLimitBreached oldsize |
I wouldn't bother to change anything now, but if I would, it'd be something like this: data LimitKind = Hard | Soft
class MonadThreadBudgetReport m where
reportLimitBreached :: MaxConcurrentNativePushes -> LimitKind -> Int -> m ()That would make it straight-forward to make this a stand-alone package (except maybe for the Options stuff). Also note 3d6229e |
jschaul
added a commit
that referenced
this pull request
Nov 6, 2019
- New configuration options available (none mandatory). See #895 #900 #869 - Support HEAD requests for `/sso/initiate-bind` (#878) - Do not send conversation delete events to team members upon team deletion (#897) - Support SNI for bot registrations (by bumping http-client version) (#899) - Make gundeck handle AWS outages better. (#869, #890, #892) - Improve performance by avoiding unbounded intra-service traffic spikes on team deletions (#900) - Add optional native push connection throttling (#895) - New backoffice/stern endpoint (#896) - SAML: Store raw idp metadata with typed details in c* (#872) - documentation/script updates
jschaul
added a commit
that referenced
this pull request
Nov 6, 2019
- New configuration options available (none mandatory). See #895 #900 #869 - Support HEAD requests for `/sso/initiate-bind` (#878) - Do not send conversation delete events to team members upon team deletion (#897) - Support SNI for bot registrations (by bumping http-client version) (#899) - Make gundeck handle AWS outages better. (#869, #890, #892) - Improve performance by avoiding unbounded intra-service traffic spikes on team deletions (#900) - Add optional native push connection throttling (#895) - New backoffice/stern endpoint (#896) - SAML: Store raw idp metadata with typed details in c* (#872) - documentation/script updates
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(I wonder actually whether
runWithBudgetcould not be within the Gundeck Monad, so as not to need to passmetricsaround, but maybe that's another discussion. There is no MonadMetrics, is there?)This PR can be (adapted if needed) and merged by the reviewer.