Release 2019 11 06 #902
Merged
Release 2019 11 06 #902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* docs * Add missing spar integration test cases
* Do not have default args that never apply * Make errors more greppable, do not abort on first error * Usage info
* Change SCIM documentation to actually use SAML Ids UUIDs are a bit confusing here. It is more common that your SAML provider is configured to have email addresses isntead Co-Authored-By: fisx <mf@zerobuzz.net>
Stack started not liking being called from a nix-shell anymore, because stack wants to create the nix-shell itself so it does some auto-detection and crashes. To trick it into doing the right thing again, we only use the nix-shell for non-build-deps and just for dev tools, then stack itself will call another nix-shell file that just handles build deps for the stack project.
Introduce `Gundeck.ThreadBudget.runWithBudget` that can be wrapped around actions. Wrapped actions are executed only if there is budget available, otherwise they are dropped and a warning is logged. See the haddocks at the beginning of `Gundeck.ThreadBudget` for a rationale.
Co-Authored-By: Tiago Manuel Ventura Loureiro <tiago.loureiro@gmail.com>
Currently, we get spammed with these warnings before any traffic happens, due to an incorrect handling of boolean. [gundeck] W, request=N/A, watchThreadBudgetState: total overall thread budget diverged from async weights (repaired). [gundeck] W, request=N/A, watchThreadBudgetState: total overall thread budget diverged from async weights (repaired). [gundeck] W, request=N/A, watchThreadBudgetState: total overall thread budget diverged from async weights (repaired).
…fyIORef (#891) * Add ad-hoc bench for O(n) function * Fix: do not block ThreadBudgetState for expensive sanity check * move benchmarking code out from production code, do real benchmarks
* emit counter metric on soft/hard limit breached * Cleanup exports * More related work
Events about deleted conversations do not need to be sent to everyone when a team is deleted. Indeed, it is harmful in that it leads to performance problems: For large teams with many conversations, notifying every team member about that fact that every conversation has been deleted creates a lot of events. None of these events are useful, since on a team deletion, the accounts of every user are deleted, i.e. in practice these events cannot be read. This PR fixes the bug that was introduced in #849
Follow-up from #549
http-client: bump to wire-20191104
* throttle galley->gundeck requests on team deletion by sending events slower (configurable, optional, slow/cautious defaults) * throttle user deletions (brig) by waiting in between each user deletion (configurable, optional, default: 100ms)
Chunk nativeToken lookups and chunk native pushes to SNS to avoid unbounded new connections to open on when sending to large amounts of recipients. * configurable (suggestion: 32); default to unbounded
- New configuration options available (none mandatory). See #895 #900 #869 - Support HEAD requests for `/sso/initiate-bind` (#878) - Do not send conversation delete events to team members upon team deletion (#897) - Support SNI for bot registrations (by bumping http-client version) (#899) - Make gundeck handle AWS outages better. (#869, #890, #892) - Improve performance by avoiding unbounded intra-service traffic spikes on team deletions (#900) - Add optional native push connection throttling (#895) - New backoffice/stern endpoint (#896) - SAML: Store raw idp metadata with typed details in c* (#872) - documentation/script updates
tiago-loureiro
approved these changes
Nov 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2019-11-06 #901
Relevant for self-hosters
Relevant for client developers
/sso/initiate-bind(Support HEAD requests for/sso/initiate-bind#878)Bug fixes
Internal changes