runfix(cells): disable spammy tracking [WPB-21469] #19829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copilot finished reviewing on behalf of
aweiss-dev
December 2, 2025 17:01
aweiss-dev
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This is a quick-fix PR that disables "spammy" video analytics tracking by commenting out multiple amplify.publish calls for video playback events. The changes properly clean up unused imports while leaving the tracking code commented for potential future re-enabling.
Key changes:
- Commented out all video analytics tracking events (PLAY_FAILED, PLAY_SUCCESS, UNPLAYABLE_ERROR, UNSUPPORTED_MIME_TYPE)
- Removed unused imports (
amplify,WebAppEvents,EventName) - Added TODO comments indicating this needs to be revisited
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 10 comments.
| File | Description |
|---|---|
| VideoAsset.tsx | Commented out 5 analytics tracking calls across mime type validation, playback loading, and error handling; removed 3 unused imports |
| useVideoPlayback.ts | Commented out 3 analytics tracking calls in playability check and error handler; removed 3 unused imports |
Review Summary: Changes Requested
- Nit issues (9): Inconsistent formatting in TODO comments and missing spaces after
// - Moderate issues (1): Maintainability concern about leaving commented-out code in the codebase
All issues are minor formatting/style concerns. The core functionality of disabling tracking is implemented correctly with proper cleanup of unused imports.
| amplify.publish(WebAppEvents.ANALYTICS.EVENT, EventName.MESSAGES.VIDEO.PLAY_FAILED); | ||
| amplify.publish(WebAppEvents.ANALYTICS.EVENT, EventName.MESSAGES.VIDEO.UNSUPPORTED_MIME_TYPE); | ||
| } | ||
| // ToDo: This needs to be revisited |
There was a problem hiding this comment.
Inconsistent TODO format. The codebase uses "Todo" in the other file (useVideoPlayback.ts:56) but "ToDo" here. Please standardize to one format for consistency.
Suggested change
| // ToDo: This needs to be revisited | |
| // Todo: This needs to be revisited |
| if (!playable) { | ||
| amplify.publish(WebAppEvents.ANALYTICS.EVENT, EventName.MESSAGES.VIDEO.PLAY_FAILED); | ||
| amplify.publish(WebAppEvents.ANALYTICS.EVENT, EventName.MESSAGES.VIDEO.UNPLAYABLE_ERROR); | ||
| // ToDo: This needs to be revisited |
There was a problem hiding this comment.
Inconsistent TODO format. The codebase uses "Todo" in the other file (useVideoPlayback.ts:56) but "ToDo" here. Please standardize to one format for consistency.
| onError={event => { | ||
| setVideoPlaybackError(true); | ||
| amplify.publish(WebAppEvents.ANALYTICS.EVENT, EventName.MESSAGES.VIDEO.PLAY_FAILED); | ||
| // ToDo: This needs to be revisited |
There was a problem hiding this comment.
Inconsistent TODO format. The codebase uses "Todo" in the other file (useVideoPlayback.ts:56) but "ToDo" here. Please standardize to one format for consistency.
Suggested change
| // ToDo: This needs to be revisited | |
| // Todo: This needs to be revisited |
| setIsVideoLoaded(true); | ||
| amplify.publish(WebAppEvents.ANALYTICS.EVENT, EventName.MESSAGES.VIDEO.PLAY_SUCCESS); | ||
| // ToDo: This needs to be revisited | ||
| //amplify.publish(WebAppEvents.ANALYTICS.EVENT, EventName.MESSAGES.VIDEO.PLAY_SUCCESS); |
There was a problem hiding this comment.
Missing space after // in comment. For consistency with other comments in this file and line 107, add a space: // amplify.publish
Suggested change
| //amplify.publish(WebAppEvents.ANALYTICS.EVENT, EventName.MESSAGES.VIDEO.PLAY_SUCCESS); | |
| // amplify.publish(WebAppEvents.ANALYTICS.EVENT, EventName.MESSAGES.VIDEO.PLAY_SUCCESS); |
| } | ||
| amplify.publish(WebAppEvents.ANALYTICS.EVENT, EventName.MESSAGES.VIDEO.PLAY_FAILED); | ||
| // ToDo: This needs to be revisited | ||
| //amplify.publish(WebAppEvents.ANALYTICS.EVENT, EventName.MESSAGES.VIDEO.PLAY_FAILED); |
There was a problem hiding this comment.
Missing space after // in comment. For consistency with other comments in this file and line 107, add a space: // amplify.publish
Suggested change
| //amplify.publish(WebAppEvents.ANALYTICS.EVENT, EventName.MESSAGES.VIDEO.PLAY_FAILED); | |
| // amplify.publish(WebAppEvents.ANALYTICS.EVENT, EventName.MESSAGES.VIDEO.PLAY_FAILED); |
Comment on lines
+95
to
+98
| // if (!canPlay) { | ||
| // amplify.publish(WebAppEvents.ANALYTICS.EVENT, EventName.MESSAGES.VIDEO.PLAY_FAILED); | ||
| // amplify.publish(WebAppEvents.ANALYTICS.EVENT, EventName.MESSAGES.VIDEO.UNSUPPORTED_MIME_TYPE); | ||
| // } |
There was a problem hiding this comment.
[Suggestion] Commented-out code should generally be removed rather than left in the codebase. If this tracking is truly temporary and will be revisited soon, consider:
- Creating a GitHub issue to track the follow-up work and reference it in the comment
- Removing the imports that are no longer used (already done ✓)
- Using a feature flag instead to disable tracking if you need to quickly re-enable it
If the tracking won't be re-enabled, remove the commented code entirely to improve maintainability.
Suggested change
| // if (!canPlay) { | |
| // amplify.publish(WebAppEvents.ANALYTICS.EVENT, EventName.MESSAGES.VIDEO.PLAY_FAILED); | |
| // amplify.publish(WebAppEvents.ANALYTICS.EVENT, EventName.MESSAGES.VIDEO.UNSUPPORTED_MIME_TYPE); | |
| // } |
| setVideoSrc(assetUrl); | ||
| setIsVideoLoaded(true); | ||
| amplify.publish(WebAppEvents.ANALYTICS.EVENT, EventName.MESSAGES.VIDEO.PLAY_SUCCESS); | ||
| // ToDo: This needs to be revisited |
There was a problem hiding this comment.
Inconsistent TODO format. The codebase uses "Todo" in the other file (useVideoPlayback.ts:56) but "ToDo" here. Please standardize to one format for consistency.
| } | ||
| } | ||
| amplify.publish(WebAppEvents.ANALYTICS.EVENT, EventName.MESSAGES.VIDEO.PLAY_FAILED); | ||
| // ToDo: This needs to be revisited |
There was a problem hiding this comment.
Inconsistent TODO format. The codebase uses "Todo" in the other file (useVideoPlayback.ts:56) but "ToDo" here. Please standardize to one format for consistency.
| setVideoPlaybackError(true); | ||
| amplify.publish(WebAppEvents.ANALYTICS.EVENT, EventName.MESSAGES.VIDEO.PLAY_FAILED); | ||
| // ToDo: This needs to be revisited | ||
| //amplify.publish(WebAppEvents.ANALYTICS.EVENT, EventName.MESSAGES.VIDEO.PLAY_FAILED); |
There was a problem hiding this comment.
Missing space after // in comment. For consistency with other comments in this file and line 107, add a space: // amplify.publish
Suggested change
| //amplify.publish(WebAppEvents.ANALYTICS.EVENT, EventName.MESSAGES.VIDEO.PLAY_FAILED); | |
| // amplify.publish(WebAppEvents.ANALYTICS.EVENT, EventName.MESSAGES.VIDEO.PLAY_FAILED); |
| setIsError(true); | ||
| amplify.publish(WebAppEvents.ANALYTICS.EVENT, EventName.MESSAGES.VIDEO.PLAY_FAILED); | ||
| // Todo: This needs to be revisited | ||
| //amplify.publish(WebAppEvents.ANALYTICS.EVENT, EventName.MESSAGES.VIDEO.PLAY_FAILED); |
There was a problem hiding this comment.
Missing space after // in comment. For consistency with line 56 in this file, add a space: // amplify.publish
Suggested change
| //amplify.publish(WebAppEvents.ANALYTICS.EVENT, EventName.MESSAGES.VIDEO.PLAY_FAILED); | |
| // amplify.publish(WebAppEvents.ANALYTICS.EVENT, EventName.MESSAGES.VIDEO.PLAY_FAILED); |
zskhan
approved these changes
Dec 2, 2025
Contributor
|
🔗 Download Full Report Artifact 🧪 Playwright Test Summary
specs/Accessibility/Accessibility.spec.ts (❌ 2 failed,
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #19829 +/- ##
==========================================
+ Coverage 43.71% 43.73% +0.01%
==========================================
Files 1298 1298
Lines 32707 32696 -11
Branches 7259 7258 -1
==========================================
+ Hits 14297 14298 +1
+ Misses 16693 16682 -11
+ Partials 1717 1716 -1 🚀 New features to boost your workflow:
|
| setVideoSrc(assetUrl); | ||
| setIsVideoLoaded(true); | ||
| amplify.publish(WebAppEvents.ANALYTICS.EVENT, EventName.MESSAGES.VIDEO.PLAY_SUCCESS); | ||
| // ToDo: This needs to be revisited |
There was a problem hiding this comment.
Inconsistent comment format: "ToDo" should be "TODO" (standard task marker format).
| } | ||
| } | ||
| amplify.publish(WebAppEvents.ANALYTICS.EVENT, EventName.MESSAGES.VIDEO.PLAY_FAILED); | ||
| // ToDo: This needs to be revisited |
There was a problem hiding this comment.
Inconsistent comment format: "ToDo" should be "TODO" (standard task marker format).
| onError={event => { | ||
| setVideoPlaybackError(true); | ||
| amplify.publish(WebAppEvents.ANALYTICS.EVENT, EventName.MESSAGES.VIDEO.PLAY_FAILED); | ||
| // ToDo: This needs to be revisited |
There was a problem hiding this comment.
Inconsistent comment format: "ToDo" should be "TODO" (standard task marker format).
Suggested change
| // ToDo: This needs to be revisited | |
| // TODO: This needs to be revisited |
| const handleError = useCallback((event: SyntheticEvent<HTMLVideoElement>) => { | ||
| setIsError(true); | ||
| amplify.publish(WebAppEvents.ANALYTICS.EVENT, EventName.MESSAGES.VIDEO.PLAY_FAILED); | ||
| // Todo: This needs to be revisited |
There was a problem hiding this comment.
Inconsistent comment format: "Todo" should be "TODO" (standard task marker format).
Suggested change
| // Todo: This needs to be revisited | |
| // TODO: This needs to be revisited |
| if (!playable) { | ||
| amplify.publish(WebAppEvents.ANALYTICS.EVENT, EventName.MESSAGES.VIDEO.PLAY_FAILED); | ||
| amplify.publish(WebAppEvents.ANALYTICS.EVENT, EventName.MESSAGES.VIDEO.UNPLAYABLE_ERROR); | ||
| // ToDo: This needs to be revisited |
There was a problem hiding this comment.
Inconsistent comment format: "ToDo" should be "TODO" (standard task marker format).
|
|
||
| amplify.publish(WebAppEvents.ANALYTICS.EVENT, EventName.MESSAGES.VIDEO.PLAY_FAILED); | ||
| amplify.publish(WebAppEvents.ANALYTICS.EVENT, EventName.MESSAGES.VIDEO.UNPLAYABLE_ERROR); | ||
| // Todo: This needs to be revisited |
There was a problem hiding this comment.
Inconsistent comment format: "Todo" should be "TODO" (standard task marker format). Also note this file uses "Todo" while VideoAsset.tsx uses "ToDo" - both should be standardized to "TODO".
|
Copilot finished reviewing on behalf of
aweiss-dev
December 3, 2025 13:05
e-maad
pushed a commit
that referenced
this pull request
Dec 3, 2025
otto-the-bot
added a commit
that referenced
this pull request
Dec 3, 2025
* fix: remove call from the call state when a user is left the group (#19790) * chore(deps-dev): bump rimraf from 6.1.0 to 6.1.2 in /server (#19791) Bumps [rimraf](https://github.com/isaacs/rimraf) from 6.1.0 to 6.1.2. - [Changelog](https://github.com/isaacs/rimraf/blob/main/CHANGELOG.md) - [Commits](isaacs/rimraf@v6.1.0...v6.1.2) --- updated-dependencies: - dependency-name: rimraf dependency-version: 6.1.2 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * refactor(WPB-21957): create fixture for creating teams + refactor edit tests with it (#19804) This is an attempt to resolve the race conditions happening when two users connect in a 1:1 for the first time starting the conversation as proteus but it's migrated to MLS automatically. This leads to a message sent during the migration being lost. Team members don't need to go through this step as they are aware of the spoken protocol of other members after login. * test(WPB-19966): write "Reply" regression tests (#19760) * test(TC-8038): add test for not replying to a ping * test(TC-8039): add test for not replying to timed messages * test(TC-2994): add test for quote in reply to vanish if source message is removed * test(TC-2996): add test for searching message * test(TC-2997): test for quote in reply to be truncated * test(TC-3002): reply to a picture * test(TC-3003): reply to an audio message * test(TC-3004): reply to video * test(TC-3005): reply to link * test(TC3006): reply to file * test(TC-3007): reply to reply * test(TC-3008): reply to link with text * test(TC-3011): Reply with timed message * test(TC-3013): test clicking the reply * test(TC-3014): test replying in a conversation I'm no longer part of * test(TC-3016): click on mention in reply opens user profile * fix: remove visibility check from sendMessage * test(TC-3009): add test case for replying to a location + util for sending location via testservice * refactor: replace createPagesForUser with new fixtures * refactor(test): use new fixtures for reply tests * refactor: remove no longer used PagePlugin withConversation * fix: accessibility improvements login(https://wearezeta.atlassian.net/browse/WPB-20819) (#19714) * fix: make password toggle button accessible and localised(WPB-21228) * fix: translate type * fix: Login - New view is not announced * fix: make back button accessible WPB-21466 * fix: make external link 2fa accessible(WPB-21279) * fix: password toggle button text alternative(WPB-21228) * fix: make verify account header focusable using screenkey and login subheading style adjustments * fix: add toggle password show/hide label * fix: address review comments * chore: bump core packages * fix: pipeline issues * fix: PR comments * fix: pipeline issues * chore(deps): bump @wireapp/core from 46.46.3 to 46.46.5 (#19793) Bumps [@wireapp/core](https://github.com/wireapp/wire-web-packages) from 46.46.3 to 46.46.5. - [Commits](https://github.com/wireapp/wire-web-packages/compare/@wireapp/core@46.46.3...@wireapp/core@46.46.5) --- updated-dependencies: - dependency-name: "@wireapp/core" dependency-version: 46.46.5 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump core-js from 3.46.0 to 3.47.0 (#19797) Bumps [core-js](https://github.com/zloirock/core-js/tree/HEAD/packages/core-js) from 3.46.0 to 3.47.0. - [Release notes](https://github.com/zloirock/core-js/releases) - [Changelog](https://github.com/zloirock/core-js/blob/master/CHANGELOG.md) - [Commits](https://github.com/zloirock/core-js/commits/v3.47.0/packages/core-js) --- updated-dependencies: - dependency-name: core-js dependency-version: 3.47.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump emoji-picker-react from 4.15.1 to 4.15.2 (#19802) Bumps [emoji-picker-react](https://github.com/ealush/emoji-picker-react) from 4.15.1 to 4.15.2. - [Release notes](https://github.com/ealush/emoji-picker-react/releases) - [Commits](https://github.com/ealush/emoji-picker-react/commits) --- updated-dependencies: - dependency-name: emoji-picker-react dependency-version: 4.15.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump html-webpack-plugin from 5.6.4 to 5.6.5 (#19800) Bumps [html-webpack-plugin](https://github.com/jantimon/html-webpack-plugin) from 5.6.4 to 5.6.5. - [Release notes](https://github.com/jantimon/html-webpack-plugin/releases) - [Changelog](https://github.com/jantimon/html-webpack-plugin/blob/main/CHANGELOG.md) - [Commits](jantimon/html-webpack-plugin@v5.6.4...v5.6.5) --- updated-dependencies: - dependency-name: html-webpack-plugin dependency-version: 5.6.5 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump oidc-client-ts from 3.4.0 to 3.4.1 (#19801) Bumps [oidc-client-ts](https://github.com/authts/oidc-client-ts) from 3.4.0 to 3.4.1. - [Release notes](https://github.com/authts/oidc-client-ts/releases) - [Commits](authts/oidc-client-ts@v3.4.0...v3.4.1) --- updated-dependencies: - dependency-name: oidc-client-ts dependency-version: 3.4.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump webpack from 5.102.1 to 5.103.0 (#19796) Bumps [webpack](https://github.com/webpack/webpack) from 5.102.1 to 5.103.0. - [Release notes](https://github.com/webpack/webpack/releases) - [Commits](webpack/webpack@v5.102.1...v5.103.0) --- updated-dependencies: - dependency-name: webpack dependency-version: 5.103.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump workbox-webpack-plugin from 7.3.0 to 7.4.0 (#19799) Bumps [workbox-webpack-plugin](https://github.com/googlechrome/workbox) from 7.3.0 to 7.4.0. - [Release notes](https://github.com/googlechrome/workbox/releases) - [Commits](GoogleChrome/workbox@v7.3.0...v7.4.0) --- updated-dependencies: - dependency-name: workbox-webpack-plugin dependency-version: 7.4.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump stylelint from 16.25.0 to 16.26.0 (#19798) Bumps [stylelint](https://github.com/stylelint/stylelint) from 16.25.0 to 16.26.0. - [Release notes](https://github.com/stylelint/stylelint/releases) - [Changelog](https://github.com/stylelint/stylelint/blob/main/CHANGELOG.md) - [Commits](stylelint/stylelint@16.25.0...16.26.0) --- updated-dependencies: - dependency-name: stylelint dependency-version: 16.26.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump baseline-browser-mapping from 2.8.28 to 2.8.31 (#19792) Bumps [baseline-browser-mapping](https://github.com/web-platform-dx/baseline-browser-mapping) from 2.8.28 to 2.8.31. - [Release notes](https://github.com/web-platform-dx/baseline-browser-mapping/releases) - [Commits](web-platform-dx/baseline-browser-mapping@v2.8.28...v2.8.31) --- updated-dependencies: - dependency-name: baseline-browser-mapping dependency-version: 2.8.31 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * test(WPB-19968): add tests for self deleting messages (#19805) * test(TC-657): add test for sending ephemeral text message in 1:1 * test(TC-658): add test for sending ephemeral text message in group * refactor: replace util sendTimedMessage with dedicated utils for enabling and disabling timed messages * test(TC-662): Verify timer is applied to all messages until turning it off in 1:1 * test(TC-664): Verify that message with previous timer are deleted on start-up when the timeout passed in 1:1 * refactor: overload createPage fixture to optionally accept a context to reuse * refactor: use team for tests using new fixture * test(TC-675): Verify the message is not deleted for users that didn't read the message * test(TC-3715): set global group conversation timer * refactor(reply-tests): remove unused createUser fixture * test(TC-3716): check current time is visible in details * fix(a11y): add disabled attribute to MessageTimerButton * test(TC-3718): check timed message button is disabled if timed messages are set globally * test(TC-3719): globally set timer is shown on button next to input field * test(TC-3720): system messages are shown for enabled / disabled timer messages * test(TC-3717): check ephemeral message appear in search results * test(TC-3731): add test for message to disappear from search results (currently broken) * refactor: group search tests * refactor: update search result tests to do assertions on receiver side * refactor: group tests with self deleting messages set globally for a group conversation * docs: add ticket number to comment for skipped test * fix: prevent microphone disabled dialog display when muted (#19808) * test(WPB-21957): update backend endpoint to match api version (#19809) * chore: bump avs to v10.2.19 (#19810) * chore(deps): bump pm2 from 6.0.13 to 6.0.14 in /server (#19814) Bumps [pm2](https://github.com/Unitech/pm2) from 6.0.13 to 6.0.14. - [Release notes](https://github.com/Unitech/pm2/releases) - [Changelog](https://github.com/Unitech/pm2/blob/master/CHANGELOG.md) - [Commits](Unitech/pm2@v6.0.13...v6.0.14) --- updated-dependencies: - dependency-name: pm2 dependency-version: 6.0.14 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump js-yaml from 3.14.1 to 3.14.2 in /server (#19817) Bumps [js-yaml](https://github.com/nodeca/js-yaml) from 3.14.1 to 3.14.2. - [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md) - [Commits](nodeca/js-yaml@3.14.1...3.14.2) --- updated-dependencies: - dependency-name: js-yaml dependency-version: 3.14.2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * test(WPB-19939): add authentication regression tests (#19826) * test(TC-34579: verify signin button is disabled inc ase of empty credentials * test(TC-3468): Verify sign in error appearance in case of suspended team account * test(TC-3460): Verify current browser is set as temporary device * test(TC-3465): Verify sign in error appearance in case of wrong credentials * test(TC-3472): Ensure history is kept after refresh on permanent device * test(TC-3473): create data driven test to also ensure history is kept on temporary device * test(TC-1311): verify session expires * test(TC-3480): check tls versions allowed by webapp server * test(TC-1311): Ensure history is gone after logging out of public computer * fix(websocket): optimise event handling. Add heartbeat [WPB-21950] (#19825) * fix(lifecycle): optimise online / offline event handling. Add heartbeat for WS * Update src/script/repositories/event/EventRepository.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/script/repositories/event/EventRepository.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/script/repositories/event/EventRepository.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * chore: rename to updateConnectivityStatus * chore: add copilot suggested improvements --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * chore(deps): bump express from 4.21.2 to 4.22.0 in /server (#19827) Bumps [express](https://github.com/expressjs/express) from 4.21.2 to 4.22.0. - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/4.22.0/History.md) - [Commits](expressjs/express@4.21.2...4.22.0) --- updated-dependencies: - dependency-name: express dependency-version: 4.22.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: blocking user spec [19940] (#19784) * test(WPB-19940): add tests for blocking users * test(block): refactor block.spec.ts according to Review-Comments add function to userActions.ts to send a connection request add fixture for connection request delete conversationNotConnected.modal.ts, replace it with acknowledge.modal.ts * test(block): refactor block.spec.ts according to Review-Comments * test(block): refactor block.spec.ts according to Review-Comments * test(block): fixed unclear comments and variable namings --------- Co-authored-by: Klaus Boldt <klaus.boldt@mail.schwarz> * chore(deps): bump crowdin/github-action from 2.12.0 to 2.13.0 (#19828) Bumps [crowdin/github-action](https://github.com/crowdin/github-action) from 2.12.0 to 2.13.0. - [Release notes](https://github.com/crowdin/github-action/releases) - [Commits](crowdin/github-action@v2.12.0...v2.13.0) --- updated-dependencies: - dependency-name: crowdin/github-action dependency-version: 2.13.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat: integrate Collabora using iframe [WPB-21650] (#19813) * initial commit * add close modal handler * added isFileEditable() * added edit option for conversation assets * add tests * fixed getNode api call * bump @webapp/core * fix package.json * fixed package.json * fix package.json * address PR comments * fixed types * chore(deps-dev): bump stylelint from 16.26.0 to 16.26.1 (#19820) Bumps [stylelint](https://github.com/stylelint/stylelint) from 16.26.0 to 16.26.1. - [Release notes](https://github.com/stylelint/stylelint/releases) - [Changelog](https://github.com/stylelint/stylelint/blob/main/CHANGELOG.md) - [Commits](stylelint/stylelint@16.26.0...16.26.1) --- updated-dependencies: - dependency-name: stylelint dependency-version: 16.26.1 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump @playwright/test from 1.56.1 to 1.57.0 (#19818) Bumps [@playwright/test](https://github.com/microsoft/playwright) from 1.56.1 to 1.57.0. - [Release notes](https://github.com/microsoft/playwright/releases) - [Commits](microsoft/playwright@v1.56.1...v1.57.0) --- updated-dependencies: - dependency-name: "@playwright/test" dependency-version: 1.57.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump baseline-browser-mapping from 2.8.31 to 2.8.32 (#19819) Bumps [baseline-browser-mapping](https://github.com/web-platform-dx/baseline-browser-mapping) from 2.8.31 to 2.8.32. - [Release notes](https://github.com/web-platform-dx/baseline-browser-mapping/releases) - [Commits](web-platform-dx/baseline-browser-mapping@v2.8.31...v2.8.32) --- updated-dependencies: - dependency-name: baseline-browser-mapping dependency-version: 2.8.32 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump emoji-picker-react from 4.15.2 to 4.16.1 (#19822) Bumps [emoji-picker-react](https://github.com/ealush/emoji-picker-react) from 4.15.2 to 4.16.1. - [Release notes](https://github.com/ealush/emoji-picker-react/releases) - [Commits](https://github.com/ealush/emoji-picker-react/commits) --- updated-dependencies: - dependency-name: emoji-picker-react dependency-version: 4.16.1 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * ci(WPB-21987): shard playwright tests across multiple runners (#19807) * refactor: use nvmrc to select node version * feat: add job to build test service * feat: shard tests across multiple runners with integrated testservice & job to collect reports * fix: build shadowJar of testservice * fix: generate json report when merging blobs * refactor: only download chrome browser for tests * ci: use github reporter in CI * fix: re-use playwright config when merging reports to generate json report for PR comment * refactor: don't pass github user and token when building testservice * feat: use 16 runners for sharding * feat: execute regression tests in addition to critical flow * fix: make script for reporting playwright summary work with nested test suites * chore: use SHA for third party actions (So Sonar shuts up) * refactor: use line reporter instead of github The report annotations are too annoying * refactor: stop background process of testservice after test * fix: run critical flow and regression tests * ci: increase number of parallel test runners to 32 Now that the regression tests and critical flow tests are executed 16 runners is a bit too little * style: ignore prettier for shard definition * chore: safe guard stripAnsi function in report generation * ci(WPB-21987): group test in playwright comment by file (#19830) * refactor: update report script to group tests by file * style: use list to render test cases * feat: add direct link to download playwright report * test(WPB-19966): fix getMessage locator to account for different message states (#19832) * chore: add env var MAX_API_VERSION [WPB-22159] (#19831) * runfix(cells): disable spammy tracking (#19829) * test(WPB-19968): use a unique test message to avoid strict mode violation (#19834) * test(WPB-19939): wait for login to finish before continuing (#19833) * chore: Update translations --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Zafar Saeed Khan <zafarsaeed@outlook.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mark Brockhoff <95471369+markbrockhoff@users.noreply.github.com> Co-authored-by: Arjita <arjitamitra3@gmail.com> Co-authored-by: Adrian Weiß <77456193+aweiss-dev@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: JacquelineLehner <117973982+JacquelineLehner@users.noreply.github.com> Co-authored-by: Klaus Boldt <klaus.boldt@mail.schwarz> Co-authored-by: Immad Abdul Jabbar <immad.jabbar@wire.com>
e-maad
pushed a commit
that referenced
this pull request
Dec 3, 2025
e-maad
added a commit
that referenced
this pull request
Dec 3, 2025
* fix: remove call from the call state when a user is left the group (#19790) * chore(deps-dev): bump rimraf from 6.1.0 to 6.1.2 in /server (#19791) Bumps [rimraf](https://github.com/isaacs/rimraf) from 6.1.0 to 6.1.2. - [Changelog](https://github.com/isaacs/rimraf/blob/main/CHANGELOG.md) - [Commits](isaacs/rimraf@v6.1.0...v6.1.2) --- updated-dependencies: - dependency-name: rimraf dependency-version: 6.1.2 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * refactor(WPB-21957): create fixture for creating teams + refactor edit tests with it (#19804) This is an attempt to resolve the race conditions happening when two users connect in a 1:1 for the first time starting the conversation as proteus but it's migrated to MLS automatically. This leads to a message sent during the migration being lost. Team members don't need to go through this step as they are aware of the spoken protocol of other members after login. * test(WPB-19966): write "Reply" regression tests (#19760) * test(TC-8038): add test for not replying to a ping * test(TC-8039): add test for not replying to timed messages * test(TC-2994): add test for quote in reply to vanish if source message is removed * test(TC-2996): add test for searching message * test(TC-2997): test for quote in reply to be truncated * test(TC-3002): reply to a picture * test(TC-3003): reply to an audio message * test(TC-3004): reply to video * test(TC-3005): reply to link * test(TC3006): reply to file * test(TC-3007): reply to reply * test(TC-3008): reply to link with text * test(TC-3011): Reply with timed message * test(TC-3013): test clicking the reply * test(TC-3014): test replying in a conversation I'm no longer part of * test(TC-3016): click on mention in reply opens user profile * fix: remove visibility check from sendMessage * test(TC-3009): add test case for replying to a location + util for sending location via testservice * refactor: replace createPagesForUser with new fixtures * refactor(test): use new fixtures for reply tests * refactor: remove no longer used PagePlugin withConversation * fix: accessibility improvements login(https://wearezeta.atlassian.net/browse/WPB-20819) (#19714) * fix: make password toggle button accessible and localised(WPB-21228) * fix: translate type * fix: Login - New view is not announced * fix: make back button accessible WPB-21466 * fix: make external link 2fa accessible(WPB-21279) * fix: password toggle button text alternative(WPB-21228) * fix: make verify account header focusable using screenkey and login subheading style adjustments * fix: add toggle password show/hide label * fix: address review comments * chore: bump core packages * fix: pipeline issues * fix: PR comments * fix: pipeline issues * chore(deps): bump @wireapp/core from 46.46.3 to 46.46.5 (#19793) Bumps [@wireapp/core](https://github.com/wireapp/wire-web-packages) from 46.46.3 to 46.46.5. - [Commits](https://github.com/wireapp/wire-web-packages/compare/@wireapp/core@46.46.3...@wireapp/core@46.46.5) --- updated-dependencies: - dependency-name: "@wireapp/core" dependency-version: 46.46.5 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump core-js from 3.46.0 to 3.47.0 (#19797) Bumps [core-js](https://github.com/zloirock/core-js/tree/HEAD/packages/core-js) from 3.46.0 to 3.47.0. - [Release notes](https://github.com/zloirock/core-js/releases) - [Changelog](https://github.com/zloirock/core-js/blob/master/CHANGELOG.md) - [Commits](https://github.com/zloirock/core-js/commits/v3.47.0/packages/core-js) --- updated-dependencies: - dependency-name: core-js dependency-version: 3.47.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump emoji-picker-react from 4.15.1 to 4.15.2 (#19802) Bumps [emoji-picker-react](https://github.com/ealush/emoji-picker-react) from 4.15.1 to 4.15.2. - [Release notes](https://github.com/ealush/emoji-picker-react/releases) - [Commits](https://github.com/ealush/emoji-picker-react/commits) --- updated-dependencies: - dependency-name: emoji-picker-react dependency-version: 4.15.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump html-webpack-plugin from 5.6.4 to 5.6.5 (#19800) Bumps [html-webpack-plugin](https://github.com/jantimon/html-webpack-plugin) from 5.6.4 to 5.6.5. - [Release notes](https://github.com/jantimon/html-webpack-plugin/releases) - [Changelog](https://github.com/jantimon/html-webpack-plugin/blob/main/CHANGELOG.md) - [Commits](jantimon/html-webpack-plugin@v5.6.4...v5.6.5) --- updated-dependencies: - dependency-name: html-webpack-plugin dependency-version: 5.6.5 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump oidc-client-ts from 3.4.0 to 3.4.1 (#19801) Bumps [oidc-client-ts](https://github.com/authts/oidc-client-ts) from 3.4.0 to 3.4.1. - [Release notes](https://github.com/authts/oidc-client-ts/releases) - [Commits](authts/oidc-client-ts@v3.4.0...v3.4.1) --- updated-dependencies: - dependency-name: oidc-client-ts dependency-version: 3.4.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump webpack from 5.102.1 to 5.103.0 (#19796) Bumps [webpack](https://github.com/webpack/webpack) from 5.102.1 to 5.103.0. - [Release notes](https://github.com/webpack/webpack/releases) - [Commits](webpack/webpack@v5.102.1...v5.103.0) --- updated-dependencies: - dependency-name: webpack dependency-version: 5.103.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump workbox-webpack-plugin from 7.3.0 to 7.4.0 (#19799) Bumps [workbox-webpack-plugin](https://github.com/googlechrome/workbox) from 7.3.0 to 7.4.0. - [Release notes](https://github.com/googlechrome/workbox/releases) - [Commits](GoogleChrome/workbox@v7.3.0...v7.4.0) --- updated-dependencies: - dependency-name: workbox-webpack-plugin dependency-version: 7.4.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump stylelint from 16.25.0 to 16.26.0 (#19798) Bumps [stylelint](https://github.com/stylelint/stylelint) from 16.25.0 to 16.26.0. - [Release notes](https://github.com/stylelint/stylelint/releases) - [Changelog](https://github.com/stylelint/stylelint/blob/main/CHANGELOG.md) - [Commits](stylelint/stylelint@16.25.0...16.26.0) --- updated-dependencies: - dependency-name: stylelint dependency-version: 16.26.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump baseline-browser-mapping from 2.8.28 to 2.8.31 (#19792) Bumps [baseline-browser-mapping](https://github.com/web-platform-dx/baseline-browser-mapping) from 2.8.28 to 2.8.31. - [Release notes](https://github.com/web-platform-dx/baseline-browser-mapping/releases) - [Commits](web-platform-dx/baseline-browser-mapping@v2.8.28...v2.8.31) --- updated-dependencies: - dependency-name: baseline-browser-mapping dependency-version: 2.8.31 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * test(WPB-19968): add tests for self deleting messages (#19805) * test(TC-657): add test for sending ephemeral text message in 1:1 * test(TC-658): add test for sending ephemeral text message in group * refactor: replace util sendTimedMessage with dedicated utils for enabling and disabling timed messages * test(TC-662): Verify timer is applied to all messages until turning it off in 1:1 * test(TC-664): Verify that message with previous timer are deleted on start-up when the timeout passed in 1:1 * refactor: overload createPage fixture to optionally accept a context to reuse * refactor: use team for tests using new fixture * test(TC-675): Verify the message is not deleted for users that didn't read the message * test(TC-3715): set global group conversation timer * refactor(reply-tests): remove unused createUser fixture * test(TC-3716): check current time is visible in details * fix(a11y): add disabled attribute to MessageTimerButton * test(TC-3718): check timed message button is disabled if timed messages are set globally * test(TC-3719): globally set timer is shown on button next to input field * test(TC-3720): system messages are shown for enabled / disabled timer messages * test(TC-3717): check ephemeral message appear in search results * test(TC-3731): add test for message to disappear from search results (currently broken) * refactor: group search tests * refactor: update search result tests to do assertions on receiver side * refactor: group tests with self deleting messages set globally for a group conversation * docs: add ticket number to comment for skipped test * fix: prevent microphone disabled dialog display when muted (#19808) * test(WPB-21957): update backend endpoint to match api version (#19809) * chore: bump avs to v10.2.19 (#19810) * chore(deps): bump pm2 from 6.0.13 to 6.0.14 in /server (#19814) Bumps [pm2](https://github.com/Unitech/pm2) from 6.0.13 to 6.0.14. - [Release notes](https://github.com/Unitech/pm2/releases) - [Changelog](https://github.com/Unitech/pm2/blob/master/CHANGELOG.md) - [Commits](Unitech/pm2@v6.0.13...v6.0.14) --- updated-dependencies: - dependency-name: pm2 dependency-version: 6.0.14 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump js-yaml from 3.14.1 to 3.14.2 in /server (#19817) Bumps [js-yaml](https://github.com/nodeca/js-yaml) from 3.14.1 to 3.14.2. - [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md) - [Commits](nodeca/js-yaml@3.14.1...3.14.2) --- updated-dependencies: - dependency-name: js-yaml dependency-version: 3.14.2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * test(WPB-19939): add authentication regression tests (#19826) * test(TC-34579: verify signin button is disabled inc ase of empty credentials * test(TC-3468): Verify sign in error appearance in case of suspended team account * test(TC-3460): Verify current browser is set as temporary device * test(TC-3465): Verify sign in error appearance in case of wrong credentials * test(TC-3472): Ensure history is kept after refresh on permanent device * test(TC-3473): create data driven test to also ensure history is kept on temporary device * test(TC-1311): verify session expires * test(TC-3480): check tls versions allowed by webapp server * test(TC-1311): Ensure history is gone after logging out of public computer * fix(websocket): optimise event handling. Add heartbeat [WPB-21950] (#19825) * fix(lifecycle): optimise online / offline event handling. Add heartbeat for WS * Update src/script/repositories/event/EventRepository.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/script/repositories/event/EventRepository.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/script/repositories/event/EventRepository.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * chore: rename to updateConnectivityStatus * chore: add copilot suggested improvements --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * chore(deps): bump express from 4.21.2 to 4.22.0 in /server (#19827) Bumps [express](https://github.com/expressjs/express) from 4.21.2 to 4.22.0. - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/4.22.0/History.md) - [Commits](expressjs/express@4.21.2...4.22.0) --- updated-dependencies: - dependency-name: express dependency-version: 4.22.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: blocking user spec [19940] (#19784) * test(WPB-19940): add tests for blocking users * test(block): refactor block.spec.ts according to Review-Comments add function to userActions.ts to send a connection request add fixture for connection request delete conversationNotConnected.modal.ts, replace it with acknowledge.modal.ts * test(block): refactor block.spec.ts according to Review-Comments * test(block): refactor block.spec.ts according to Review-Comments * test(block): fixed unclear comments and variable namings --------- Co-authored-by: Klaus Boldt <klaus.boldt@mail.schwarz> * chore(deps): bump crowdin/github-action from 2.12.0 to 2.13.0 (#19828) Bumps [crowdin/github-action](https://github.com/crowdin/github-action) from 2.12.0 to 2.13.0. - [Release notes](https://github.com/crowdin/github-action/releases) - [Commits](crowdin/github-action@v2.12.0...v2.13.0) --- updated-dependencies: - dependency-name: crowdin/github-action dependency-version: 2.13.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat: integrate Collabora using iframe [WPB-21650] (#19813) * initial commit * add close modal handler * added isFileEditable() * added edit option for conversation assets * add tests * fixed getNode api call * bump @webapp/core * fix package.json * fixed package.json * fix package.json * address PR comments * fixed types * chore(deps-dev): bump stylelint from 16.26.0 to 16.26.1 (#19820) Bumps [stylelint](https://github.com/stylelint/stylelint) from 16.26.0 to 16.26.1. - [Release notes](https://github.com/stylelint/stylelint/releases) - [Changelog](https://github.com/stylelint/stylelint/blob/main/CHANGELOG.md) - [Commits](stylelint/stylelint@16.26.0...16.26.1) --- updated-dependencies: - dependency-name: stylelint dependency-version: 16.26.1 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump @playwright/test from 1.56.1 to 1.57.0 (#19818) Bumps [@playwright/test](https://github.com/microsoft/playwright) from 1.56.1 to 1.57.0. - [Release notes](https://github.com/microsoft/playwright/releases) - [Commits](microsoft/playwright@v1.56.1...v1.57.0) --- updated-dependencies: - dependency-name: "@playwright/test" dependency-version: 1.57.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump baseline-browser-mapping from 2.8.31 to 2.8.32 (#19819) Bumps [baseline-browser-mapping](https://github.com/web-platform-dx/baseline-browser-mapping) from 2.8.31 to 2.8.32. - [Release notes](https://github.com/web-platform-dx/baseline-browser-mapping/releases) - [Commits](web-platform-dx/baseline-browser-mapping@v2.8.31...v2.8.32) --- updated-dependencies: - dependency-name: baseline-browser-mapping dependency-version: 2.8.32 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump emoji-picker-react from 4.15.2 to 4.16.1 (#19822) Bumps [emoji-picker-react](https://github.com/ealush/emoji-picker-react) from 4.15.2 to 4.16.1. - [Release notes](https://github.com/ealush/emoji-picker-react/releases) - [Commits](https://github.com/ealush/emoji-picker-react/commits) --- updated-dependencies: - dependency-name: emoji-picker-react dependency-version: 4.16.1 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * ci(WPB-21987): shard playwright tests across multiple runners (#19807) * refactor: use nvmrc to select node version * feat: add job to build test service * feat: shard tests across multiple runners with integrated testservice & job to collect reports * fix: build shadowJar of testservice * fix: generate json report when merging blobs * refactor: only download chrome browser for tests * ci: use github reporter in CI * fix: re-use playwright config when merging reports to generate json report for PR comment * refactor: don't pass github user and token when building testservice * feat: use 16 runners for sharding * feat: execute regression tests in addition to critical flow * fix: make script for reporting playwright summary work with nested test suites * chore: use SHA for third party actions (So Sonar shuts up) * refactor: use line reporter instead of github The report annotations are too annoying * refactor: stop background process of testservice after test * fix: run critical flow and regression tests * ci: increase number of parallel test runners to 32 Now that the regression tests and critical flow tests are executed 16 runners is a bit too little * style: ignore prettier for shard definition * chore: safe guard stripAnsi function in report generation * ci(WPB-21987): group test in playwright comment by file (#19830) * refactor: update report script to group tests by file * style: use list to render test cases * feat: add direct link to download playwright report * test(WPB-19966): fix getMessage locator to account for different message states (#19832) * chore: add env var MAX_API_VERSION [WPB-22159] (#19831) * runfix(cells): disable spammy tracking (#19829) * test(WPB-19968): use a unique test message to avoid strict mode violation (#19834) * test(WPB-19939): wait for login to finish before continuing (#19833) * chore: Update translations --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Zafar Saeed Khan <zafarsaeed@outlook.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mark Brockhoff <95471369+markbrockhoff@users.noreply.github.com> Co-authored-by: Arjita <arjitamitra3@gmail.com> Co-authored-by: Adrian Weiß <77456193+aweiss-dev@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: JacquelineLehner <117973982+JacquelineLehner@users.noreply.github.com> Co-authored-by: Klaus Boldt <klaus.boldt@mail.schwarz> Co-authored-by: Immad Abdul Jabbar <immad.jabbar@wire.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
Get rid of the spammy logs as a quick fix
Security Checklist (required)
Standards Acknowledgement (required)
Screenshots or demo (if the user interface changed)
Notes for reviewers