Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation failed after updating fmt version to 11.1.0 #7592

Closed
jimwang118 opened this issue Dec 26, 2024 · 1 comment · Fixed by #7593
Closed

Compilation failed after updating fmt version to 11.1.0 #7592

jimwang118 opened this issue Dec 26, 2024 · 1 comment · Fixed by #7593
Labels
type: bug Something isn't working.

Comments

@jimwang118
Copy link

Describe the bug

E:\vcpkg\buildtrees\wpilib\src\v2024.3.2-0ef9e4f662\wpiutil\src\main\native\cpp\DataLog.cpp(265): error C2672: 'wpi::Logger::Log': no matching overloaded function found
E:\vcpkg\buildtrees\wpilib\src\v2024.3.2-0ef9e4f662\wpiutil\src\main\native\cpp\DataLog.cpp(354): error C2672: 'wpi::Logger::Log': no matching overloaded function found
E:\vcpkg\buildtrees\wpilib\src\v2024.3.2-0ef9e4f662\wpiutil\src\main\native\cpp\DataLog.cpp(370): error C2672: 'wpi::Logger::Log': no matching overloaded function found
E:\vcpkg\buildtrees\wpilib\src\v2024.3.2-0ef9e4f662\wpiutil\src\main\native\cpp\DataLog.cpp(380): error C2672: 'wpi::Logger::Log': no matching overloaded function found
E:\vcpkg\buildtrees\wpilib\src\v2024.3.2-0ef9e4f662\wpiutil\src\main\native\cpp\DataLog.cpp(382): error C2672: 'wpi::Logger::Log': no matching overloaded function found
E:\vcpkg\buildtrees\wpilib\src\v2024.3.2-0ef9e4f662\wpiutil\src\main\native\cpp\DataLog.cpp(445): error C2672: 'wpi::Logger::Log': no matching overloaded function found
E:\vcpkg\buildtrees\wpilib\src\v2024.3.2-0ef9e4f662\wpiutil\src\main\native\cpp\DataLog.cpp(455): error C2672: 'wpi::Logger::Log': no matching overloaded function found
E:\vcpkg\buildtrees\wpilib\src\v2024.3.2-0ef9e4f662\wpiutil\src\main\native\cpp\DataLog.cpp(491): error C2672: 'wpi::Logger::Log': no matching overloaded function found
E:\vcpkg\buildtrees\wpilib\src\v2024.3.2-0ef9e4f662\wpiutil\src\main\native\cpp\DataLog.cpp(494): error C2672: 'wpi::Logger::Log': no matching overloaded function found
E:\vcpkg\buildtrees\wpilib\src\v2024.3.2-0ef9e4f662\wpiutil\src\main\native\cpp\DataLog.cpp(529): error C2672: 'wpi::Logger::Log': no matching overloaded function found
E:\vcpkg\buildtrees\wpilib\src\v2024.3.2-0ef9e4f662\wpiutil\src\main\native\cpp\DataLog.cpp(643): error C2672: 'wpi::Logger::Log': no matching overloaded function found
E:\vcpkg\buildtrees\wpilib\src\v2024.3.2-0ef9e4f662\wpiutil\src\main\native\cpp\DataLog.cpp(716): error C2672: 'wpi::Logger::Log': no matching overloaded function found

To Reproduce
Steps to reproduce the behavior:

  1. I updated the fmt version to 11.1.0 in vcpkg, and then compiled wpilib, and the above compilation error occurred.
  2. You can download the code of PR 42936 for local testing.
  • Link to code:

Expected behavior
wpilib can be compiled normally.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. Windows 11]
  • Project Information: [In Visual Studio Code, press the WPILib button and choose WPILib: Open Project Information. Press the copy button and paste the data here. If not using VS Code, please include WPILib version, Gradle version, Java version, C++ version (if applicable), and any third party libraries and versions]

Additional context
Add any other context about the problem here.

@jimwang118 jimwang118 added the type: bug Something isn't working. label Dec 26, 2024
@PeterJohnson
Copy link
Member

PeterJohnson commented Dec 26, 2024

Is it broken with HEAD? We build with 11.0.2 normally now, but haven’t tried 11.1.0 yet.

calcmogul added a commit to calcmogul/allwpilib that referenced this issue Dec 26, 2024
Usage of FMT_STRING() was removed since it caused compilation failures,
and https://fmt.dev/11.1/api/#compile-time-checks says it's no longer
necessary for compile-time format strings.

Fixes wpilibsuite#7592.
PeterJohnson pushed a commit that referenced this issue Dec 27, 2024
Usage of FMT_STRING() was removed since it caused compilation failures,
and https://fmt.dev/11.1/api/#compile-time-checks says it's no longer
necessary for compile-time format strings.

Fixes #7592.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants