Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake Prepare for alternate core selections #2086

Merged
merged 3 commits into from
Oct 14, 2024

Conversation

islas
Copy link
Collaborator

@islas islas commented Aug 6, 2024

TYPE: enhancement

KEYWORDS: cmake, wrfplus, da

SOURCE: internal

DESCRIPTION OF CHANGES:
Problem:
The current CMake build only works with the em core / ARW in mind and presents a non-intuitive selection when attempting other cores. While these cores are not yet supported in the CMake build, remove these selections sets up the configuration script to be able to present a familiar set of options.

Solution:
Remove normally unselectable options from configure_new after selecting non-ARW cores. Put in place stand-in values for these unselected variables.

@islas islas requested review from a team as code owners August 6, 2024 02:48
@islas
Copy link
Collaborator Author

islas commented Aug 6, 2024

Requires #2056 and #2053

@weiwangncar
Copy link
Collaborator

The regression test results:

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 23           24
Number of Builds       : 60           57
Number of Simulations  : 158           150        0
Number of Comparisons  : 95           86        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

amstokely
amstokely previously approved these changes Sep 19, 2024
Copy link
Collaborator

@amstokely amstokely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and I approve these changes.

*Note: My review is based on my general experience with CMake and Python, as I haven’t personally used WRF.

@islas islas merged commit f68f0b9 into wrf-model:release-v4.6.1 Oct 14, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants