Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake confcheck switch to try_* functions #2090

Open
wants to merge 13 commits into
base: release-v4.6.1
Choose a base branch
from

Conversation

islas
Copy link
Collaborator

@islas islas commented Aug 6, 2024

TYPE: enhancement

KEYWORDS: cmake, configuration

SOURCE: internal

DESCRIPTION OF CHANGES:
Problem:
The configuration checks done by the CMake build use language-specific calls between various functions. This has lead to a rather complex signature that is also limited in scope.

Solution:
Simplify the wrf_conf_check calls to make use of CMake's built-in try_compile() and try_run() functions, forwarding argument to those as necessary. Aside from minor adjustments to the wrf_conf_check calls this should appear as a drop-in replacement that provides the same results as before, i.e. no change to the system configuration options detected.

@islas islas requested review from a team as code owners August 6, 2024 03:21
@islas
Copy link
Collaborator Author

islas commented Aug 6, 2024

Requires #2056, #2053, #2086, #2087, and #2088

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants