Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streamlookup special case nulls in keys #10508

Merged
merged 3 commits into from
Oct 17, 2024
Merged

Streamlookup special case nulls in keys #10508

merged 3 commits into from
Oct 17, 2024

Conversation

yumkam
Copy link
Collaborator

@yumkam yumkam commented Oct 16, 2024

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

yumkam added 2 commits October 16, 2024 15:21
@yumkam
streamlookup: special-handle keys with nulls
bf322c7 
In addition to minor performance optimization (those keys will have
empty answer), this is workaround for connector bug:
ydb-platform/ydb-go-sdk#1506
@yumkam
add tests with NULLs
e289759
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 16, 2024 •
edited
Loading

⚪ 2024-10-16 12:27:57 UTC Pre-commit check linux-x86_64-relwithdebinfo for 650640a has started.
⚪ 2024-10-16 12:28:07 UTC Artifacts will be uploaded here
⚪ 2024-10-16 12:31:00 UTC ya make is running...
🟡 2024-10-16 13:23:26 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39829 34243 0 5 5480 101

⚪ 2024-10-16 13:26:48 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-16 13:38:17 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
105 (only retried tests) 8 0 0 0 97

🟢 2024-10-16 13:38:24 UTC Build successful.
🟢 2024-10-16 13:38:43 UTC ydbd size 2.8 GiB changed* by +320 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 030f818 merge: 650640a diff diff %
ydbd size 3 010 928 160 Bytes 3 010 928 480 Bytes +320 Bytes +0.000%
ydbd stripped size 477 553 432 Bytes 477 553 560 Bytes +128 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 16, 2024 •
edited
Loading

⚪ 2024-10-16 12:32:20 UTC Pre-commit check linux-x86_64-release-asan for 650640a has started.
⚪ 2024-10-16 12:32:31 UTC Artifacts will be uploaded here
⚪ 2024-10-16 12:35:25 UTC ya make is running...
🟡 2024-10-16 13:52:12 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10280 10071 0 58 47 104

🟢 2024-10-16 13:53:05 UTC Build successful.
🟢 2024-10-16 13:53:34 UTC ydbd size 5.7 GiB changed* by +192 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 030f818 merge: 650640a diff diff %
ydbd size 6 099 890 304 Bytes 6 099 890 496 Bytes +192 Bytes +0.000%
ydbd stripped size 1 521 081 712 Bytes 1 521 081 776 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@yumkam yumkam marked this pull request as ready for review October 16, 2024 13:44
@yumkam yumkam requested review from a team as code owners October 16, 2024 13:44
@yumkam yumkam requested review from uzhastik and rvu1024 October 17, 2024 09:10
rvu1024
rvu1024 previously approved these changes Oct 17, 2024
View reviewed changes
uzhastik
uzhastik previously approved these changes Oct 17, 2024
View reviewed changes
@yumkam yumkam dismissed stale reviews from uzhastik and rvu1024 via 66c8a42 October 17, 2024 13:26
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 17, 2024 •
edited
Loading

⚪ 2024-10-17 13:30:53 UTC Pre-commit check linux-x86_64-release-asan for 5b59d04 has started.
⚪ 2024-10-17 13:31:04 UTC Artifacts will be uploaded here
⚪ 2024-10-17 13:34:04 UTC ya make is running...
🟡 2024-10-17 14:58:26 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10306 10074 0 66 64 102

🟢 2024-10-17 14:59:21 UTC Build successful.
🟡 2024-10-17 14:59:55 UTC ydbd size 5.7 GiB changed* by +275.0 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: f33f3fe merge: 5b59d04 diff diff %
ydbd size 6 129 656 288 Bytes 6 129 937 856 Bytes +275.0 KiB +0.005%
ydbd stripped size 1 529 234 448 Bytes 1 529 302 928 Bytes +66.9 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 17, 2024 •
edited
Loading

⚪ 2024-10-17 13:31:01 UTC Pre-commit check linux-x86_64-relwithdebinfo for 5b59d04 has started.
⚪ 2024-10-17 13:31:12 UTC Artifacts will be uploaded here
⚪ 2024-10-17 13:34:07 UTC ya make is running...
🟡 2024-10-17 14:27:16 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39848 34269 0 4 5480 95

⚪ 2024-10-17 14:30:43 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-10-17 14:42:01 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
99 (only retried tests) 6 0 2 1 90

⚪ 2024-10-17 14:42:10 UTC ya make is running... (failed tests rerun, try 3)
🟢 2024-10-17 14:53:19 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
92 (only retried tests) 2 0 0 0 90

🟢 2024-10-17 14:53:26 UTC Build successful.
🟢 2024-10-17 14:53:46 UTC ydbd size 2.8 GiB changed* by +448 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 3806a16 merge: 5b59d04 diff diff %
ydbd size 3 028 473 568 Bytes 3 028 474 016 Bytes +448 Bytes +0.000%
ydbd stripped size 480 034 712 Bytes 480 034 840 Bytes +128 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@yumkam yumkam merged commit aadf67f into ydb-platform:main Oct 17, 2024
10 checks passed
yumkam added a commit to yumkam/ydb that referenced this pull request Oct 18, 2024
@yumkam
Streamlookup special case nulls in keys (ydb-platform#10508)
40f0387 
(cherry picked from commit aadf67f)
yumkam added a commit that referenced this pull request Oct 18, 2024
@yumkam @dmasloff @Hor911
Streamlookup stable backports #7782 #9758 #9396 #10283 #10489 #10508 #…
9a9711d 
…7892 #10280 (#10341)

Co-authored-by: dmasloff <74042473+dmasloff@users.noreply.github.com>
Co-authored-by: Hor911 <hor911@ydb.tech>
This was referenced Oct 22, 2024
Merged
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Oct 29, 2024
Closed
@shnikd shnikd mentioned this pull request Nov 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uzhastik uzhastik uzhastik approved these changes

@rvu1024 rvu1024 rvu1024 approved these changes

Assignees
No one assigned
Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yumkam @uzhastik @rvu1024