Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YQ-3784 support computation graph invalidation in purecalc #10799

Merged
merged 4 commits into from
Oct 23, 2024
Merged

YQ-3784 support computation graph invalidation in purecalc #10799

merged 4 commits into from
Oct 23, 2024

Conversation

GrigoriyPA
Copy link
Collaborator

@GrigoriyPA GrigoriyPA commented Oct 23, 2024 •
edited
Loading

Changelog entry

Supported computation graph invalidation in purecalc in push stream mode, it is required for stateless execution

Changelog category

  • Improvement

Additional information

@GrigoriyPA GrigoriyPA requested a review from a team as a code owner October 23, 2024 15:29
@GrigoriyPA GrigoriyPA requested a review from vitstn October 23, 2024 15:30
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 23, 2024 •
edited
Loading

⚪ 2024-10-23 15:31:12 UTC Pre-commit check linux-x86_64-release-asan for 6de32b5 has started.
⚪ 2024-10-23 15:31:22 UTC Artifacts will be uploaded here
⚫ 2024-10-23 15:32:34 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 23, 2024 •
edited
Loading

⚪ 2024-10-23 15:31:58 UTC Pre-commit check linux-x86_64-relwithdebinfo for 6de32b5 has started.
⚪ 2024-10-23 15:32:09 UTC Artifacts will be uploaded here
⚫ 2024-10-23 15:32:35 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 23, 2024 •
edited
Loading

⚪ 2024-10-23 15:34:15 UTC Pre-commit check linux-x86_64-release-asan for 606dfdf has started.
⚪ 2024-10-23 15:34:26 UTC Artifacts will be uploaded here
⚫ 2024-10-23 15:36:44 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 23, 2024 •
edited
Loading

⚪ 2024-10-23 15:34:49 UTC Pre-commit check linux-x86_64-relwithdebinfo for 606dfdf has started.
⚪ 2024-10-23 15:35:01 UTC Artifacts will be uploaded here
⚫ 2024-10-23 15:36:44 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 23, 2024 •
edited
Loading

⚪ 2024-10-23 15:38:12 UTC Pre-commit check linux-x86_64-release-asan for 75681e6 has started.
⚪ 2024-10-23 15:38:16 UTC Artifacts will be uploaded here
⚪ 2024-10-23 15:41:14 UTC ya make is running...
🔴 2024-10-23 15:44:22 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 23, 2024 •
edited
Loading

⚪ 2024-10-23 15:39:27 UTC Pre-commit check linux-x86_64-relwithdebinfo for 75681e6 has started.
⚪ 2024-10-23 15:40:27 UTC Artifacts will be uploaded here
⚪ 2024-10-23 15:44:05 UTC ya make is running...
🔴 2024-10-23 15:46:19 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 23, 2024 •
edited
Loading

⚪ 2024-10-23 16:09:29 UTC Pre-commit check linux-x86_64-relwithdebinfo for e1b2b43 has started.
⚪ 2024-10-23 16:09:36 UTC Artifacts will be uploaded here
⚪ 2024-10-23 16:12:31 UTC ya make is running...
🟡 2024-10-23 17:04:15 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39957 34356 0 1 5503 97

⚪ 2024-10-23 17:07:37 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-10-23 17:19:00 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
98 (only retried tests) 2 0 1 1 94

⚪ 2024-10-23 17:19:08 UTC ya make is running... (failed tests rerun, try 3)
🟢 2024-10-23 17:30:24 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
95 (only retried tests) 2 0 0 0 93

🟢 2024-10-23 17:30:31 UTC Build successful.
🟢 2024-10-23 17:30:52 UTC ydbd size 2.8 GiB changed* by +1.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: f940b8c merge: e1b2b43 diff diff %
ydbd size 3 029 800 848 Bytes 3 029 802 608 Bytes +1.7 KiB +0.000%
ydbd stripped size 480 752 376 Bytes 480 752 760 Bytes +384 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 23, 2024 •
edited
Loading

⚪ 2024-10-23 16:09:50 UTC Pre-commit check linux-x86_64-release-asan for e1b2b43 has started.
⚪ 2024-10-23 16:10:01 UTC Artifacts will be uploaded here
⚪ 2024-10-23 16:13:09 UTC ya make is running...
🟡 2024-10-23 17:30:30 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10285 10087 0 50 44 104

🟢 2024-10-23 17:31:25 UTC Build successful.
🟢 2024-10-23 17:31:59 UTC ydbd size 5.7 GiB changed* by +6.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: f940b8c merge: e1b2b43 diff diff %
ydbd size 6 129 528 712 Bytes 6 129 535 712 Bytes +6.8 KiB +0.000%
ydbd stripped size 1 530 785 904 Bytes 1 530 788 720 Bytes +2.8 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@GrigoriyPA GrigoriyPA merged commit 0ea658a into ydb-platform:main Oct 23, 2024
10 checks passed
@GrigoriyPA GrigoriyPA deleted the YQ-3784-support-invalidate-in-purecalc branch October 23, 2024 17:38
@GrigoriyPA GrigoriyPA mentioned this pull request Oct 28, 2024
Merged
GrigoriyPA added a commit to GrigoriyPA/ydb that referenced this pull request Oct 30, 2024
@GrigoriyPA
YQ-3784 support computation graph invalidation in purecalc (ydb-platf…
58238d8 
…orm#10799)
@shnikd shnikd mentioned this pull request Nov 7, 2024
Open
@niksaveliev niksaveliev mentioned this pull request Nov 8, 2024
Merged
robot-piglet pushed a commit that referenced this pull request Nov 12, 2024
Merge PR #10741, #10799, #10732
c24e1e1 
\#10732 Fix a bug in YQL node creation for indexImplTable table settings

\#10799support computation graph invalidation in purecalc

\#10741Don't use Now() during replay for yt settings
commit_hash:bc4c150ceb2ae05fc19eaa4804fb668730a89410
maximyurchuk pushed a commit that referenced this pull request Nov 12, 2024
@maximyurchuk
Merge PR #10741, #10799, #10732
4e4600b 
\#10732 Fix a bug in YQL node creation for indexImplTable table settings

\#10799support computation graph invalidation in purecalc

\#10741Don't use Now() during replay for yt settings
commit_hash:bc4c150ceb2ae05fc19eaa4804fb668730a89410
This was referenced Nov 13, 2024
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request Nov 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitstn vitstn vitstn approved these changes

Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GrigoriyPA @vitstn