Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use Now() during replay for yt settings #10732

Merged
merged 6 commits into from
Oct 22, 2024

Conversation

vitstn
Copy link
Collaborator

@vitstn vitstn commented Oct 22, 2024

Changelog entry

...

Changelog category

  • Improvement

Additional information

...

@vitstn vitstn requested a review from a team as a code owner October 22, 2024 16:45
@vitstn vitstn requested a review from rvu1024 October 22, 2024 16:45
rvu1024
rvu1024 previously approved these changes Oct 22, 2024
Copy link

github-actions bot commented Oct 22, 2024

2024-10-22 16:49:26 UTC Pre-commit check linux-x86_64-release-asan for f6c2286 has started.
2024-10-22 16:49:36 UTC Artifacts will be uploaded here
2024-10-22 16:52:43 UTC ya make is running...
🔴 2024-10-22 16:57:14 UTC Build failed, see the logs. Also see fail summary

Copy link

github-actions bot commented Oct 22, 2024

2024-10-22 16:50:39 UTC Pre-commit check linux-x86_64-relwithdebinfo for f6c2286 has started.
2024-10-22 16:50:50 UTC Artifacts will be uploaded here
2024-10-22 16:53:55 UTC ya make is running...
🔴 2024-10-22 17:00:04 UTC Build failed, see the logs. Also see fail summary

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@vitstn vitstn enabled auto-merge (squash) October 22, 2024 17:09
@vitstn vitstn requested a review from rvu1024 October 22, 2024 17:09
rvu1024
rvu1024 previously approved these changes Oct 22, 2024
Copy link

github-actions bot commented Oct 22, 2024

2024-10-22 17:12:10 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8ea8203 has started.
2024-10-22 17:12:13 UTC Artifacts will be uploaded here
2024-10-22 17:15:20 UTC ya make is running...
🔴 2024-10-22 17:19:19 UTC Build failed, see the logs. Also see fail summary

Copy link

github-actions bot commented Oct 22, 2024

2024-10-22 17:13:24 UTC Pre-commit check linux-x86_64-release-asan for 8ea8203 has started.
2024-10-22 17:13:34 UTC Artifacts will be uploaded here
2024-10-22 17:16:38 UTC ya make is running...
🔴 2024-10-22 17:26:28 UTC Build failed, see the logs. Also see fail summary

Copy link

github-actions bot commented Oct 22, 2024

2024-10-22 17:33:32 UTC Pre-commit check linux-x86_64-release-asan for f1d1968 has started.
2024-10-22 17:33:42 UTC Artifacts will be uploaded here
2024-10-22 17:36:46 UTC ya make is running...
2024-10-22 17:37:25 UTC Check cancelled

Copy link

github-actions bot commented Oct 22, 2024

2024-10-22 17:35:21 UTC Pre-commit check linux-x86_64-relwithdebinfo for f1d1968 has started.
2024-10-22 17:35:32 UTC Artifacts will be uploaded here
2024-10-22 17:37:23 UTC Check cancelled

Copy link

github-actions bot commented Oct 22, 2024

2024-10-22 17:38:48 UTC Pre-commit check linux-x86_64-release-asan for 7473d5a has started.
2024-10-22 17:38:52 UTC Artifacts will be uploaded here
2024-10-22 17:41:55 UTC ya make is running...
🔴 2024-10-22 17:47:13 UTC Build failed, see the logs. Also see fail summary

@vitstn vitstn requested a review from rvu1024 October 22, 2024 17:40
Copy link

github-actions bot commented Oct 22, 2024

2024-10-22 17:41:14 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7473d5a has started.
2024-10-22 17:41:25 UTC Artifacts will be uploaded here
2024-10-22 17:44:42 UTC ya make is running...
🔴 2024-10-22 17:51:42 UTC Build failed, see the logs. Also see fail summary

Copy link

github-actions bot commented Oct 22, 2024

2024-10-22 18:07:19 UTC Pre-commit check linux-x86_64-release-asan for 5e6a87e has started.
2024-10-22 18:07:29 UTC Artifacts will be uploaded here
2024-10-22 18:08:41 UTC Check cancelled

Copy link

github-actions bot commented Oct 22, 2024

2024-10-22 18:08:07 UTC Pre-commit check linux-x86_64-relwithdebinfo for 5e6a87e has started.
2024-10-22 18:08:18 UTC Artifacts will be uploaded here
2024-10-22 18:08:41 UTC Check cancelled

Copy link

github-actions bot commented Oct 22, 2024

2024-10-22 18:12:49 UTC Pre-commit check linux-x86_64-release-asan for 92e7fa7 has started.
2024-10-22 18:13:00 UTC Artifacts will be uploaded here
2024-10-22 18:16:05 UTC ya make is running...
🟡 2024-10-22 19:42:23 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12479 12279 0 49 51 100

🟢 2024-10-22 19:43:26 UTC Build successful.
🟢 2024-10-22 19:43:59 UTC ydbd size 5.7 GiB changed* by +57.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: c8a32ef merge: 92e7fa7 diff diff %
ydbd size 6 099 783 304 Bytes 6 099 841 920 Bytes +57.2 KiB +0.001%
ydbd stripped size 1 522 530 608 Bytes 1 522 549 872 Bytes +18.8 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 22, 2024

2024-10-22 18:14:49 UTC Pre-commit check linux-x86_64-relwithdebinfo for 92e7fa7 has started.
2024-10-22 18:14:59 UTC Artifacts will be uploaded here
2024-10-22 18:18:06 UTC ya make is running...
🟡 2024-10-22 19:25:27 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
75537 61532 0 1 13907 97

2024-10-22 19:32:27 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-22 19:44:05 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
97 (only retried tests) 4 0 0 0 93

🟢 2024-10-22 19:44:12 UTC Build successful.
🟢 2024-10-22 19:44:31 UTC ydbd size 2.8 GiB changed* by +31.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: c8a32ef merge: 92e7fa7 diff diff %
ydbd size 3 012 369 992 Bytes 3 012 402 568 Bytes +31.8 KiB +0.001%
ydbd stripped size 478 204 152 Bytes 478 209 336 Bytes +5.1 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@vitstn vitstn merged commit 26b808f into ydb-platform:main Oct 22, 2024
10 checks passed
@vitstn vitstn deleted the replay_now_for_yt_settings branch October 22, 2024 20:42
robot-piglet pushed a commit that referenced this pull request Nov 12, 2024
\#10732 Fix a bug in YQL node creation for indexImplTable table settings

\#10799support computation graph invalidation in purecalc

\#10741Don't use Now() during replay for yt settings
commit_hash:bc4c150ceb2ae05fc19eaa4804fb668730a89410
maximyurchuk pushed a commit that referenced this pull request Nov 12, 2024
\#10732 Fix a bug in YQL node creation for indexImplTable table settings

\#10799support computation graph invalidation in purecalc

\#10741Don't use Now() during replay for yt settings
commit_hash:bc4c150ceb2ae05fc19eaa4804fb668730a89410
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants