Skip to content

Conversation

@pashandor789
Copy link
Contributor

@pashandor789 pashandor789 commented Oct 16, 2024

Changelog category

  • Bugfix

What could happen? When the edge had been created and we tried to add a condition from the transitive closure to this edge, it would be skipped, so we would miss a condition in the tree, if we choose this edge in the join tree

@pashandor789 pashandor789 requested review from a team as code owners October 16, 2024 15:20
@github-actions
Copy link

github-actions bot commented Oct 16, 2024

2024-10-16 15:23:16 UTC Pre-commit check linux-x86_64-release-asan for 6fb39c4 has started.
2024-10-16 15:23:47 UTC Artifacts will be uploaded here
2024-10-16 15:27:28 UTC ya make is running...
🟡 2024-10-16 16:57:13 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11105 10864 0 72 64 105

🟢 2024-10-16 16:58:15 UTC Build successful.
🟡 2024-10-16 16:58:50 UTC ydbd size 5.7 GiB changed* by +1.6 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: f1972db merge: 6fb39c4 diff diff %
ydbd size 6 128 234 192 Bytes 6 129 884 832 Bytes +1.6 MiB +0.027%
ydbd stripped size 1 529 060 304 Bytes 1 529 374 512 Bytes +306.8 KiB +0.021%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Oct 16, 2024

2024-10-16 15:24:39 UTC Pre-commit check linux-x86_64-relwithdebinfo for 6fb39c4 has started.
2024-10-16 15:25:12 UTC Artifacts will be uploaded here
2024-10-16 15:28:50 UTC ya make is running...
🟡 2024-10-16 16:31:18 UTC Some tests failed, follow the links below. Going to retry failed tests...

Details

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
73966 59988 0 5 13870 103

2024-10-16 16:39:35 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-16 16:51:15 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
106 (only retried tests) 8 0 0 0 98

🟢 2024-10-16 16:51:21 UTC Build successful.
🟢 2024-10-16 16:51:42 UTC ydbd size 2.8 GiB changed* by +55.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 8739de4 merge: 6fb39c4 diff diff %
ydbd size 3 028 486 472 Bytes 3 028 543 272 Bytes +55.5 KiB +0.002%
ydbd stripped size 480 129 624 Bytes 480 135 832 Bytes +6.1 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions github-actions bot added bugfix and removed bugfix labels Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants