Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust vector index settings #10542

Merged
merged 11 commits into from
Oct 18, 2024
Merged

Conversation

MBkkt
Copy link
Collaborator

@MBkkt MBkkt commented Oct 17, 2024

  • Finish separation of kmeans tree (type of vector index) settings and common vector index settings
  • Add two kmeans tree specific settings: clusters count and levels count (0 means auto)
  • Unify similarity and distance inside proto settings (but not inside WITH options)

The info about count of levels also needed in scheme for our select from vector index.

@MBkkt MBkkt requested a review from azevaykin October 17, 2024 08:45
@MBkkt MBkkt requested a review from a team as a code owner October 17, 2024 08:45

This comment was marked as outdated.

This comment was marked as outdated.

@MBkkt MBkkt force-pushed the adjust-vector-index-settings branch from 36c4e75 to b2227d2 Compare October 17, 2024 09:31

This comment was marked as outdated.

This comment was marked as outdated.

Copy link

github-actions bot commented Oct 17, 2024

2024-10-17 09:44:00 UTC Pre-commit check linux-x86_64-relwithdebinfo for 167cb47 has started.
2024-10-17 09:44:10 UTC Artifacts will be uploaded here
2024-10-17 09:47:37 UTC ya make is running...
🔴 2024-10-17 10:19:58 UTC Build failed, see the logs. Also see fail summary

Copy link

github-actions bot commented Oct 17, 2024

2024-10-17 09:44:40 UTC Pre-commit check linux-x86_64-release-asan for 167cb47 has started.
2024-10-17 09:44:50 UTC Artifacts will be uploaded here
2024-10-17 09:48:16 UTC ya make is running...
🔴 2024-10-17 10:26:06 UTC Build failed, see the logs. Also see fail summary

@MBkkt MBkkt self-assigned this Oct 17, 2024
azevaykin
azevaykin previously approved these changes Oct 17, 2024
vitstn
vitstn previously approved these changes Oct 17, 2024
@MBkkt MBkkt dismissed stale reviews from vitstn and azevaykin via eb33473 October 17, 2024 12:25
Copy link

github-actions bot commented Oct 17, 2024

2024-10-17 12:28:51 UTC Pre-commit check linux-x86_64-relwithdebinfo for 6610de9 has started.
2024-10-17 12:29:02 UTC Artifacts will be uploaded here
2024-10-17 12:32:36 UTC ya make is running...
🔴 2024-10-17 12:43:08 UTC Build failed, see the logs. Also see fail summary

Copy link

github-actions bot commented Oct 17, 2024

2024-10-17 12:29:22 UTC Pre-commit check linux-x86_64-release-asan for 6610de9 has started.
2024-10-17 12:29:33 UTC Artifacts will be uploaded here
2024-10-17 12:33:01 UTC ya make is running...
🔴 2024-10-17 12:54:24 UTC Build failed, see the logs. Also see fail summary

This comment was marked as outdated.

This comment was marked as outdated.

@MBkkt MBkkt added the rebase-and-check Rebase PR with the current base branch and check label Oct 17, 2024
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Oct 17, 2024

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

@MBkkt MBkkt mentioned this pull request Oct 18, 2024
17 tasks
Copy link

github-actions bot commented Oct 18, 2024

2024-10-18 10:48:26 UTC Pre-commit check linux-x86_64-release-asan for 2220bfe has started.
2024-10-18 10:48:37 UTC Artifacts will be uploaded here
2024-10-18 10:52:06 UTC ya make is running...
🟡 2024-10-18 12:37:41 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
17325 16828 0 112 347 38

🟢 2024-10-18 12:39:09 UTC Build successful.
🟢 2024-10-18 12:39:41 UTC ydbd size 5.7 GiB changed* by +69.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: cebe29d merge: 2220bfe diff diff %
ydbd size 6 103 366 112 Bytes 6 103 437 648 Bytes +69.9 KiB +0.001%
ydbd stripped size 1 521 592 816 Bytes 1 521 617 776 Bytes +24.4 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 18, 2024

2024-10-18 10:48:29 UTC Pre-commit check linux-x86_64-relwithdebinfo for 2220bfe has started.
2024-10-18 10:48:40 UTC Artifacts will be uploaded here
2024-10-18 10:52:06 UTC ya make is running...
🟡 2024-10-18 11:53:50 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
80223 66257 0 2 13870 94

2024-10-18 12:02:12 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-18 12:13:42 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
96 (only retried tests) 4 0 0 1 91

🟢 2024-10-18 12:13:49 UTC Build successful.
🟢 2024-10-18 12:14:07 UTC ydbd size 2.8 GiB changed* by +23.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: cebe29d merge: 2220bfe diff diff %
ydbd size 3 012 456 960 Bytes 3 012 480 464 Bytes +23.0 KiB +0.001%
ydbd stripped size 477 649 976 Bytes 477 650 904 Bytes +928 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@MBkkt MBkkt requested a review from azevaykin October 18, 2024 11:54
@MBkkt MBkkt enabled auto-merge (squash) October 18, 2024 13:02
@MBkkt MBkkt requested a review from vitstn October 18, 2024 13:06
@MBkkt MBkkt merged commit eb88635 into ydb-platform:main Oct 18, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants