Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for QuickLogic EOS S3 SoC #23565

Merged
merged 5 commits into from
Sep 4, 2020

Conversation

PiotrZierhoffer
Copy link
Collaborator

@PiotrZierhoffer PiotrZierhoffer commented Mar 18, 2020

This PR is the first from a series of PRs related to the EOS S3 ecosystem.

EOS S3 is a Cortex-M4-F based platform with an FPGA and a sensor processing subsystem.

The series will add support for the SoC itself, for the boards and several drivers.

More to read:

The series will consist of the following PRs:

  • EOS S3 SoC
  • QuickLogic Chandalar board
  • QuickLogic QuickFeather board
  • GPIO support
  • SPI support
  • on-board FPGA support

@zephyrbot

This comment has been minimized.

@PiotrZierhoffer PiotrZierhoffer force-pushed the eos-s3-soc branch 3 times, most recently from d04a020 to 89d4fd6 Compare March 18, 2020 15:00
west.yml Outdated Show resolved Hide resolved
west.yml Outdated Show resolved Hide resolved
@ioannisg
Copy link
Member

Could you send out the Board definition in the same PR? So CI will pick up and build for the Board/SoC

Copy link
Member

@ioannisg ioannisg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Pls, add the Board support (Can be minimal) as part of this PR

@kowalewskijan
Copy link
Contributor

I removed QuickLogic Chandalar board and replaced it with QuickLogic QuickFeather board since it has much more features enabled, which will come in next PRs.

@PiotrZierhoffer
Copy link
Collaborator Author

As we changed the board we use, I ask for re-review of this PR

Copy link
Member

@tgorochowik tgorochowik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, should be ready to merge once zephyrproject-rtos/hal_quicklogic#1 is in.

@kowalewskijan kowalewskijan force-pushed the eos-s3-soc branch 2 times, most recently from aa28950 to 890585f Compare August 6, 2020 10:13
@kowalewskijan
Copy link
Contributor

Since the HAL PR was merged, I updated west.yml manifest to point to correct remote and commit.

@PiotrZierhoffer
Copy link
Collaborator Author

@carlescufi @ioannisg as from our perspective this is good to go, would you care to [re]review this?




static int eos_s3_init(struct device *arg)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
static int eos_s3_init(struct device *arg)
static int eos_s3_init(const struct device *arg)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the line as suggested

@carlescufi carlescufi added this to the v2.4.0 milestone Sep 4, 2020
@carlescufi
Copy link
Member

This is almost ready for merging, just one check, will this be built by default CI?

@carlescufi
Copy link
Member

@galak and @MaureenHelm please take a look and consider it for 2.4.

@nashif nashif requested a review from carlescufi September 4, 2020 10:58
Copy link
Member

@carlescufi carlescufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no objections except for:

  • Fix the const struct device
  • Make sure this board is built in CI

Jan Kowalewski added 4 commits September 4, 2020 16:12
Add QuickLogic HAL module to west manifest.

Signed-off-by: Jan Kowalewski <jkowalewski@antmicro.com>
Add proper Kconfig for external QuickLogic module.

Signed-off-by: Jan Kowalewski <jkowalewski@antmicro.com>
Add basic devicetree for EOS S3 SoCs.

Signed-off-by: Jan Kowalewski <jkowalewski@antmicro.com>
Add basic port for QuickLogic EOS S3 SoC.

Signed-off-by: Jan Kowalewski <jkowalewski@antmicro.com>
Add basic port for EOS S3 Quick Feather board.

Signed-off-by: Jan Kowalewski <jkowalewski@antmicro.com>
@kowalewskijan
Copy link
Contributor

I fixed the suggestion from @carlescufi and rebased the branch.
@carlescufi : I can see that in the buildkite/zephyr CI there is a quick_feather target called in tests e.g.: here, so I assume it is fine.

@nashif nashif merged commit 3b6e815 into zephyrproject-rtos:master Sep 4, 2020
@Willmish
Copy link

Hi @PiotrZierhoffer , me and @JDuchniewicz are working on a project utilising an EOS S3 based board (SparkFun's Qt PLUS), and are struggling to get it to flash properly using the adapted version of TinyFPGA programmer (https://github.com/QuickLogic-Corp/TinyFPGA-Programmer-Application/tree/master). I was wondering whether you could share with us what was your workflow/tools when working with the board?

(Right now for us the board hangs when Verifying binary written to the board - this is happening on 2 different boards and tested on 3 different setups (MacOS, Ubuntu 20.04, Arch Linux)).
Screenshot 2023-05-27 at 16 37 53

Any help would be highly appreciated!

@Willmish
Copy link

Willmish commented May 27, 2023

@PiotrZierhoffer For context - I also tried flashing using openOCD via STLINK but am always met with a time out when trying to halt the target CPU:
Screenshot 2023-05-27 at 20 48 52
(Had to modify the board/quicklogic_quickfeather.cfg to use "hla_swd" instead of "swd" for the transport)

Also I belive @JDuchniewicz tried flashing using JLINK, without much success.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants