arch: riscv: revert ARCH_STACK_PTR_ALIGN change in #76791 to fix #76996
#77047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycsin
changed the title
ARCH_STACK_PTR_ALIGN change to fix #76996ARCH_STACK_PTR_ALIGN change in #76791 to fix #76996
zephyrbot
added
area: Architectures
area: RISCV
zephyrbot
requested review from
carlocaione,
dcpleung,
edersondisouza,
fkokosinski,
katsuster,
kgugala,
mgielda,
nashif,
npitre and
tgorochowik
|
@nordic-piks can you please check if this fixes the issue? |
Already checking, I will give update in a few hours. |
It helps ;) |
nordic-piks
approved these changes
Aug 14, 2024
fkokosinski
previously approved these changes
Aug 20, 2024
…ect-rtos#76045 The change of alignment check in zephyrproject-rtos#76045 could be wrong and isn't unnecessary to fix the stack traces output, undo it for now. Signed-off-by: Yong Cong Sin <ycsin@meta.com> Signed-off-by: Yong Cong Sin <yongcong.sin@gmail.com>
This reverts commit 87b95be. Signed-off-by: Yong Cong Sin <ycsin@meta.com> Signed-off-by: Yong Cong Sin <yongcong.sin@gmail.com>
ycsin
force-pushed
the
pr/fix_issue_76996
branch
from
8426c45 to
3dc7b47
Compare
|
force pushed to resolve merge conflict |
fkokosinski
approved these changes
Aug 27, 2024
masz-nordic
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially undo #76045 (but keep the required part to fix the traces output) and partially revert #76791 (but keep the test)
Fixes #76996