[Backport v3.7-branch] arch: riscv: stacktrace: fix output without ra on the stack top
#77048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Account for the scenario when we are doing `esf`-based unwinding from a function which doesn't have any callee. In this case the `ra` is not saved on the stack and the second function from the top of the frame could be missing. Signed-off-by: Yong Cong Sin <ycsin@meta.com> Signed-off-by: Yong Cong Sin <yongcong.sin@gmail.com>
qemu_riscv32e uses a different ISA and is kinda special, add it to the testcase for better coverage. Signed-off-by: Yong Cong Sin <ycsin@meta.com> Signed-off-by: Yong Cong Sin <yongcong.sin@gmail.com>
zephyrbot
added
area: Architectures
area: RISCV
zephyrbot
requested review from
carlocaione,
dcpleung,
edersondisouza,
fkokosinski,
katsuster,
kgugala,
mgielda,
nashif,
npitre and
tgorochowik
ycsin
changed the title
on the stack topra on the stack top
nordic-piks
approved these changes
Sep 6, 2024
cfriedt
approved these changes
Oct 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport the end result of #76045, #76791 & #77047
Fixes #76762