Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export missing scope parameter issue #89

Closed
wants to merge 79 commits into from

Conversation

oye816
Copy link

@oye816 oye816 commented Apr 30, 2024

References

Add references/links to any related issues or PRs. These may include:

Description

Export missing scope parameter issue

Instructions for Reviewers

Please add a more detailed description of the changes made by your PR. At a minimum, providing a bulleted list of changes in your PR is helpful to reviewers.

List of changes in this PR:

  • Fix Open a researcher profile → Choose the CRIS tab for Publications → Login → Choose Export for Publications will display "There are no items to export with the selected configuration" issue.

Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

davide-negretti and others added 30 commits November 27, 2023 11:25
[DSC-1408] - Fix dropdown readonly field

Approved-by: Andrea Barbasso
# Conflicts:
#	src/config/default-app-config.ts
#	src/environments/environment.test.ts
[DSC-1352] Move breadcrumb char limit property inside layout configuration properties

Approved-by: Andrea Barbasso
DSC-1037

Approved-by: Giuseppe Digilio
[DSC-1434] feature: update twitter to x button

Approved-by: Davide Negretti
Change section labels according to changes done in the submission form excel file
alisaismailati and others added 26 commits January 26, 2024 13:57
[DSC-1446] added default file thumbnail

Approved-by: Stefano Maffei
Item mapper main DSC-1073

Approved-by: Stefano Maffei
[DSC-1066] search-filter query with [ ]

Approved-by: Stefano Maffei
DSpace#1315)

DSC-1387 export menu in person entity main cris

Approved-by: Davide Negretti
Gdpr metrics DSC-1522

Approved-by: Andrea Barbasso
Approved-by: Giuseppe Digilio
Authority source DSC-1498

Approved-by: Stefano Maffei
# Conflicts:
#	src/config/default-app-config.ts
#	src/environments/environment.test.ts
@oye816 oye816 changed the base branch from main-cris to dspace-cris-2023_02_x May 6, 2024 00:21
* dspace-cris-2023_02_x: (65 commits)
  [DSC-397] fix issue that lead to failing e2e
  [DSC-1653] removed comments
  [DSC-1653] Defined a mixin for vertical ellipsis
  [DSC-1637] resolve conflicts
  [DSC-1601] - Added test case
  [DSC-1601] - Adjusted code for fixing requested
  [DSC-1601] - Added new implementation when bitstream is restricted
  [DSC-1601] - Removed old implementation
  [DSC-1575] Fixed labels name
  [CST-9683] Fix visualization order of the metrics boxes in the item page
  [DSC-1524] Use ngOnChanges to detect changes on input variable
  [DSC-1655] Configure person icon to be visible without authority
  [DSC-1628] change icon color in config
  [DSC-1524] Adjusted test for End User Agreement not shown
  [DSC-1524] Fixing End User Agreement not shown
  [DSC-1652] fix lint
  [DSC-1652] refactor translateService calls, change default values for timeouts
  [DSC-1575] Added labels required
  [DSC-1652] add warning and error messages to loader component
  [DSC-1601] Fixed issue with icon visibility in FileDownloadLinkComponent
  ...

# Conflicts:
#	package.json
#	src/app/shared/form/builder/ds-dynamic-form-ui/models/onebox/dynamic-onebox.component.scss
#	src/app/shared/form/builder/ds-dynamic-form-ui/models/onebox/dynamic-onebox.component.ts
@oye816 oye816 closed this May 7, 2024
@oye816 oye816 deleted the export_issue branch May 9, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Researchers and Organizations cannot use the Export function.