Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the accessibility mode setting #12

Closed
5 tasks done
jasonwebb opened this issue Aug 16, 2020 · 0 comments
Closed
5 tasks done

Deprecate the accessibility mode setting #12

jasonwebb opened this issue Aug 16, 2020 · 0 comments
Labels
feature change Change to an existing feature or functionality

Comments

@jasonwebb
Copy link

jasonwebb commented Aug 16, 2020

Accessibility should not be something that can be turned on or off with a feature flag. Instead it is the natural result of building clean, modern, and semantic code, and should be considered a necessary core feature.

  • Remove all conditionals using the accessibility variable.
  • Remove the initADA and activateADA methods, integrating any important functionality directly into the core functionality.
    • Besides, none of this functionality is explicitly called out by the ADA (or Section 508, or AODA, or any other civil rights legislation around equitable access). Instead, this legislation (and related case law) leans on the WCAG as a technical criteria.
    • At the very least, this functionality is about basic human equality, which we shouldn't really need a law to make us do. These method names seem to imply that the important thing is that a legal requirement is being targeted and met, when really it should just be something we do automatically.
  • Once this functionality is removed, ensure that passing the accessibility setting via a config or data attribute does not introduce any bugs.
  • Consider emitting a console warning or info message when this setting is passed to alert devs about the change in functionality.
  • Add documentation of this change to the main README.
@jasonwebb jasonwebb added the feature change Change to an existing feature or functionality label Aug 16, 2020
jasonwebb added a commit that referenced this issue Aug 18, 2020
…dateSlideVisibility method, remove initADA + activateADA methods
jasonwebb added a commit that referenced this issue Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature change Change to an existing feature or functionality
Projects
None yet
Development

No branches or pull requests

1 participant