Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove keyboard navigation functionality #15

Closed
3 tasks done
jasonwebb opened this issue Aug 18, 2020 · 0 comments
Closed
3 tasks done

Remove keyboard navigation functionality #15

jasonwebb opened this issue Aug 18, 2020 · 0 comments
Labels
feature change Change to an existing feature or functionality

Comments

@jasonwebb
Copy link

jasonwebb commented Aug 18, 2020

Currently the Left and Right arrow keys can be used to move between slides, but this functionality is (at best) really unintuitive for real keyboard-only users and (at worst) unusable for screen reader users. Very few carousels have this functionality, and no visible instructions are provided to explain it, so most users would have no reason to believe it exists.

Additionally, the Left and Right arrow keys are already used by the most popular screen readers (JAWS and NVDA) for virtual cursor navigation to move character-by-character through content. Just by using their virtual cursor normally, screen reader users can potentially trigger slide changes - obviously that's a problem!

  • Remove keyHandler method.
  • Remove all references to keyHandler (on prev/next buttons, slide dots, and slides/track).
  • Document this change in the main README.
@jasonwebb jasonwebb added the feature change Change to an existing feature or functionality label Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature change Change to an existing feature or functionality
Projects
None yet
Development

No branches or pull requests

1 participant