Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the individual slide container markup #9

Closed
7 tasks done
jasonwebb opened this issue Aug 16, 2020 · 1 comment
Closed
7 tasks done

Improve the individual slide container markup #9

jasonwebb opened this issue Aug 16, 2020 · 1 comment
Labels
feature change Change to an existing feature or functionality

Comments

@jasonwebb
Copy link

jasonwebb commented Aug 16, 2020

  • Eliminate role="tabpanel" since these don't really look like tabs, especially when multiple slides are visible at a time.
  • Remove aria-hidden="false" from all visible slides, since false is the default value and all this really does is make AT work harder for no reason.
  • Remove tabindex="-1", since slides should never receive focus anyway.
  • Add role="group" to each slide
  • Add aria-label="slide".
  • Add useGroupRole setting that can be used to turn off / on the role="group" and aria-label.
  • Add documentation about this feature change in the main README
@jasonwebb jasonwebb added the feature change Change to an existing feature or functionality label Aug 16, 2020
jasonwebb added a commit that referenced this issue Aug 18, 2020
…dateSlideVisibility method, remove initADA + activateADA methods
jasonwebb added a commit that referenced this issue Aug 18, 2020
@jacobraccuia
Copy link

Hi Jason, I am learning more about more accessible coding and have a question regarding aria-label="slide". Would it be better to have the ability to give each slide a name so it was more clear what the slide was depicting? When testing with my screen reader, although I gave a custom region label, there is no information when viewing this group and I need to dig deeper to learn about that slide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature change Change to an existing feature or functionality
Projects
None yet
Development

No branches or pull requests

2 participants