forked from kenwheeler/slick
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the individual slide container markup #9
Labels
feature change
Change to an existing feature or functionality
Comments
jasonwebb
added
the
feature change
Change to an existing feature or functionality
label
Aug 16, 2020
jasonwebb
added a commit
that referenced
this issue
Aug 18, 2020
…dateSlideVisibility method, remove initADA + activateADA methods
jasonwebb
added a commit
that referenced
this issue
Aug 18, 2020
…igurable with new useGroupRole setting
3 tasks
Hi Jason, I am learning more about more accessible coding and have a question regarding aria-label="slide". Would it be better to have the ability to give each slide a name so it was more clear what the slide was depicting? When testing with my screen reader, although I gave a custom region label, there is no information when viewing this group and I need to dig deeper to learn about that slide. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
role="tabpanel"
since these don't really look like tabs, especially when multiple slides are visible at a time.aria-hidden="false"
from all visible slides, sincefalse
is the default value and all this really does is make AT work harder for no reason.tabindex="-1"
, since slides should never receive focus anyway.role="group"
to each slidearia-label="slide"
.useGroupRole
setting that can be used to turn off / on therole="group"
andaria-label
.The text was updated successfully, but these errors were encountered: