Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the wrapper markup #7

Closed
3 tasks done
jasonwebb opened this issue Aug 16, 2020 · 1 comment
Closed
3 tasks done

Improve the wrapper markup #7

jasonwebb opened this issue Aug 16, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@jasonwebb
Copy link

jasonwebb commented Aug 16, 2020

  • Add role="region" to the outermost wrapper.
  • Add a generic but clear aria-label to the wrapper.
    • Consider using "carousel" as the default.
  • Consider making the aria-label configurable with a new setting.
    • This should come with some guidance about what makes an aria-label effect in this use case.
@jasonwebb jasonwebb added the enhancement New feature or request label Aug 16, 2020
jasonwebb added a commit that referenced this issue Aug 16, 2020
@jasonwebb
Copy link
Author

jasonwebb commented Aug 16, 2020

In 3c74fc6, a new setting is now available: regionLabel. Use it to provide custom text to use as the aria-label value on the wrapper (default is 'carousel').

This setting can also be defined through the data attribute data-regionlabel placed on the wrapper element used to initialize the Slick package.

Additional documentation is available in the main README in the New features and New settings sections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant