Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Signering #2871

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

[WIP] Signering #2871

wants to merge 3 commits into from

Conversation

cammiida
Copy link
Contributor

@cammiida cammiida commented Jan 6, 2025

Description

Related Issue(s)

  • closes #{issue number}

Verification/QA

  • Manual functionality testing
    • I have tested these changes manually
    • Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
    • No testing done/necessary
  • Automated tests
    • Unit test(s) have been added/updated
    • Cypress E2E test(s) have been added/updated
    • No automatic tests are needed here (no functional changes/additions)
    • I want someone to help me make some tests
  • UU/WCAG (follow these guidelines until we have our own)
    • I have tested with a screen reader/keyboard navigation/automated wcag validator
    • No testing done/necessary (no DOM/visual changes)
    • I want someone to help me perform accessibility testing
  • User documentation @ altinn-studio-docs
    • Has been added/updated
    • No functionality has been changed/added, so no documentation is needed
    • I will do that later/have created an issue
  • Support in Altinn Studio
    • Issue(s) created for support in Studio
    • This change/feature does not require any changes to Altinn Studio
  • Sprint board
    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
    • I don't have permissions to do that, please help me out
  • Labels
    • I have added a kind/* label to this PR for proper release notes grouping
    • I don't have permissions to add labels, please help me out

* WIP

* adds zod

* adds start of signee list component

* makes app table type generic

* renders tag in table for signee status

* adds header styling to signee list table

* adds todos and some error handling

* removes fake prop in schema to trigger parsing error

* moves signee state tag component to its own file

* adds language and error message when process task is not a signing task

* fixes caption helptext display

* added support for caption, description and helptext and sized table to md

* adds support for organisation signature

* adds lang texts for table header

* adds sorting on name column

* updates todos and removes unnecessary accessors

* right aligns the last column

* updates TODOs

* removes not found and unnecessary caption font-size

* smaller improvement to error handling

* adds custom error message to refine

* simplifies error handling

* fixes css classes

* adds support for is loading status in table and signee table

* extracts signee list error component to its own file

* fixes codeql warning and adds test for getSigneeStatus

* moves data fetching function and related code out of component file

* adds api tests

* adds stale time and simplifies signee list query object

* fixes moved import

* fixes org lookup css classes

* adds signee list component unit tests

* code review cleanup
@cammiida cammiida changed the title Signee List Component (#2807) [WIP] Signering Jan 6, 2025
@cammiida cammiida added the kind/product-feature Pull requests containing new features label Jan 6, 2025
* add datamodelbinding for surname for personlookup

* rm surname datamodelbinding and compose fullname

* update validation of person lookup name

* rm surname from datamodelbindings

* validate first and last name

* validate tempName inline

* Update src/layout/PersonLookup/PersonLookupComponent.tsx

Co-authored-by: Camilla Marie Dalan <camillamdalan@gmail.com>

---------

Co-authored-by: Camilla Marie Dalan <camillamdalan@gmail.com>
@HauklandJ
Copy link
Contributor

/publish

Copy link
Contributor

github-actions bot commented Jan 6, 2025

Published PR packages:

  • <link rel="stylesheet" type="text/css" href="https://altinncdn.no/toolkits/altinn-app-frontend/4.14.0-preview.1.signing.f83a1b35/altinn-app-frontend.css">
  • <script src="https://altinncdn.no/toolkits/altinn-app-frontend/4.14.0-preview.1.signing.f83a1b35/altinn-app-frontend.js"></script>

* WIP signing document list

* adds support for selflinks apps blob url

* adds support for attachment type in table

* moves error component to own file

* supports loading in signing doc list table

* adds error message when component is used in a non signing task

* fixes cypress test

* fixes import error

* moves api stuff out to api file

* adds tests for signing document list component

* code review fixes
Copy link

sonarqubecloud bot commented Jan 7, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
6.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@cammiida
Copy link
Contributor Author

cammiida commented Jan 7, 2025

/publish

Copy link
Contributor

github-actions bot commented Jan 7, 2025

Published PR packages:

  • <link rel="stylesheet" type="text/css" href="https://altinncdn.no/toolkits/altinn-app-frontend/4.14.0-preview.1.signing.8972a85f/altinn-app-frontend.css">
  • <script src="https://altinncdn.no/toolkits/altinn-app-frontend/4.14.0-preview.1.signing.8972a85f/altinn-app-frontend.js"></script>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/product-feature Pull requests containing new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants