Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(persistence): sql persistence #2737

Merged
merged 168 commits into from
May 8, 2024
Merged

feat(persistence): sql persistence #2737

merged 168 commits into from
May 8, 2024

Conversation

mikeldking
Copy link
Contributor

@mikeldking mikeldking commented Apr 1, 2024 •
edited
Loading

Feature branch for #1689

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Apr 1, 2024
@mikeldking mikeldking marked this pull request as draft April 1, 2024 17:18
@mikeldking mikeldking added the feature branch a feature branch that consolidates multiple features into a single commit on main label Apr 1, 2024
RogerHYang and others added 2 commits April 2, 2024 15:11
@RogerHYang @mikeldking
refactor: sqlite3 proof of concept (#2740)
fad0009 
* wip

---------

Co-authored-by: Mikyo King <mikyo@arize.com>
@RogerHYang
refactor: sqlite with SQLAlchemy (#2747)
d05454b 
* wip
@mikeldking mikeldking requested review from RogerHYang and removed request for RogerHYang April 4, 2024 01:31
mikeldking and others added 20 commits April 3, 2024 19:39
@mikeldking
initialize alembic
8f79e29 
refactor
@mikeldking
make alembic path to DB dynamic
4272f5c
@mikeldking
move migrations over
2dbe17f
@mikeldking
remove init_db
595400f
@mikeldking
finish out the migration
3ef525d
@mikeldking
WIP'
8c10e46
@mikeldking
make it work
ca5a23d
@mikeldking
add contraints naming conventions
fdf2507
@mikeldking @RogerHYang
Update src/phoenix/db/migrate.py
27a87e8 
Co-authored-by: Roger Yang <80478925+RogerHYang@users.noreply.github.com>
@mikeldking @RogerHYang
Update src/phoenix/db/migrate.py
5f26302 
Co-authored-by: Roger Yang <80478925+RogerHYang@users.noreply.github.com>
@mikeldking
restore log level
a4d4c88
@mikeldking
Merge pull request #2748 from Arize-ai/migrate
b56820d 
feat(persistence): migrations support
@RogerHYang
refactor: sqlite async session for graphql api (#2784)
30b2ab0
@mikeldking
feat(experimental): postgres support
a2657d4
@mikeldking
WIP
5299634
@mikeldking
WIP
058b1fe
@mikeldking
postgres support
3b36473
@mikeldking
add pg support
c4b7089
@mikeldking
Cleanup
f977bf5
@mikeldking
remove hardcoded db
b8b01f8
RogerHYang and others added 23 commits May 4, 2024 22:22
@RogerHYang
refactor: add uvloop to container deps (#3089)
5fe781d
@RogerHYang
fix: normalize datetime for phoenix client (#3088)
94a25ae
@RogerHYang
chore: remove unused dependency (#3096)
7c182b0
@RogerHYang
refactor: transmit truncated strings for input and output values in t…
094a4a1 
…able displays (#3097)

* refactor: transmit truncated strings for input and output values for table display

* clean up
@RogerHYang
refactor: graphql node interface for trace and spans (#3095)
1988be8
@RogerHYang
refactor: use TTL=3600 for project-level cache (#3093)
1ad035f
@anticorrelator
feat: Add indexes on spans table (#3098)
12d2574
@RogerHYang
refactor: refresh page on a per-project basis (#3087)
0f5a6c1
@RogerHYang
Merge branch 'main' into merge-main-to-sql
be74469
@RogerHYang
Merge pull request #3103 from Arize-ai/merge-main-to-sql
e9ab76a 
chore: merge main into sql
@RogerHYang
chore: docker-compose.yml with postgres (#3099)
a7d0514
@RogerHYang
fix: disable grpc when readonly (#3105)
71ceba9
@RogerHYang
chore: clear todo tags (#3110)
e4d8d30
@anticorrelator
refactor: Explicitly configure transaction context and ensure rollbac…
79da9e7 
…ks on failure (#3112)

* Ensure migration rollbacks

* Set "transactional_ddl" setting explicitly
@anticorrelator
fix: Invalidate cache on project reset (#3113)
2944ae5 
* Invalidate cache on project reset

* Do not reset cache if it doesn't exist
@axiomofjoy
feat: support pagination on spans resolver (#3046)
2113c5c
@RogerHYang
fix: commit insert into alembic_version (#3115)
93a144f
@RogerHYang
refactor: simplify cache invalidation (#3121)
888552c
@RogerHYang
refactor: insertion on conflict do something (or nothing) (#3116)
c9fc861
@anticorrelator
Use summaries not histograms (#3123)
fb9a153
@RogerHYang
fix: backward compatible truthiness for query from dict parsing (#3124)
b425f9d
@anticorrelator
Rename metrics (#3126)
79c7bd5
@RogerHYang
fix: check payload for legacy project_name (#3125)
d7eae60 
* fix: check payload for legacy project_name

* clean up
@mikeldking mikeldking marked this pull request as ready for review May 8, 2024 22:40
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels May 8, 2024
anticorrelator
anticorrelator approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@anticorrelator anticorrelator left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ONE CEREMONIAL APPROVAL

kid

axiomofjoy
axiomofjoy approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@axiomofjoy axiomofjoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

epic 🚀

@mikeldking mikeldking merged commit eb17847 into main May 8, 2024
19 checks passed
@mikeldking mikeldking deleted the sql branch December 26, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axiomofjoy axiomofjoy axiomofjoy approved these changes

@anticorrelator anticorrelator anticorrelator approved these changes

@RogerHYang RogerHYang Awaiting requested review from RogerHYang

Assignees
No one assigned
Labels
feature branch a feature branch that consolidates multiple features into a single commit on main size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mikeldking @Townsheriff @anticorrelator @axiomofjoy @RogerHYang