Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Onboarding: Setup tool should be inaccessible after being completed #1561

Closed
gamebits opened this issue Mar 16, 2022 · 3 comments · Fixed by #1610
Closed

Onboarding: Setup tool should be inaccessible after being completed #1561

gamebits opened this issue Mar 16, 2022 · 3 comments · Fixed by #1610
Assignees
@adekbadek
Labels
[Initiative] Onboarding released on @alpha released [Type] Enhancement Improved behavior or functionality

Comments

@gamebits
Copy link
Contributor

gamebits commented Mar 16, 2022 •
edited
Loading

Is your feature request related to a problem? Please describe.

Completion of the setup tool unlocks the full menu of Newspack menu items, none of which is the setup tool itself. This is as it should be: all the individual functions of the setup tool are available in various Newspack settings, and there is no need to regain access to the tool itself.

Yet it can still be accessed directly via the URL:

https://example.com/wp-admin/admin.php?page=newspack-setup-wizard#/

newspack-setup

Since we have provided links to the setup tool to publishers in Slack, it may be confusing if they click that link and are presented with the impression that their site still needs to be set up.

Describe the solution you'd like

Attempts to access /admin.php?page=newspack-setup-wizard#/ on a site that has already completed the setup tool should instead redirect to /admin.php?page=newspack-site-design-wizard.

Describe alternatives you've considered

Three alternatives come to mind:

  1. A redirect to the Newspack landing page of /admin.php?page=newspack.
  2. The setup tool remains accessible, but with a notice/warning that it has already been completed.
  3. The setup tool remains accessible, but only to users with an automattic.com or a8c.com email address domain.

Additional context

Discussion in Slack: p1647434558941389-slack-C01C378QWRX
@gamebits gamebits added [Type] Enhancement Improved behavior or functionality [Initiative] Onboarding labels Mar 16, 2022
@yogeshbeniwal
Copy link
Contributor

2. The setup tool remains accessible, but with a notice/warning that it has already been completed.

IMO Notice/Warning will be a better option.

@adekbadek adekbadek self-assigned this Apr 14, 2022
adekbadek added a commit that referenced this issue Apr 14, 2022
@adekbadek
feat(setup): display notice on Setup wizard after setup has been comp…
f685297 
…leted

Closes #1561
@adekbadek adekbadek mentioned this issue Apr 14, 2022
Merged
6 tasks
adekbadek added a commit that referenced this issue Apr 18, 2022
@adekbadek
feat(setup): notice on Setup wizard after setup completed (#1610)
22d6b1c 
Closes #1561
matticbot pushed a commit that referenced this issue May 2, 2022
@semantic-release-bot
chore(release): 1.82.0-alpha.1 [skip ci]
4e11bf1 
# [1.82.0-alpha.1](v1.81.0...v1.82.0-alpha.1) (2022-05-02)

### Bug Fixes

* **ads:** update refresh control help text ([#1601](#1601)) ([fc70afc](fc70afc))
* crashes with autocomplete inputs in Campaigns wizard and CategoryAutocomplete ([#1609](#1609)) ([101d1d6](101d1d6))
* handle Yoast Premium as a replacement for Yoast ([#1614](#1614)) ([9a503c0](9a503c0)), closes [#298](#298)
* **popups:** improve formatting of human-readable numbers ([#1603](#1603)) ([3106f18](3106f18))
* relax capabilities required to interact with Newspack ([04eb0be](04eb0be)), closes [#543](#543)
* **salesforce:** a PHP warning on sync completion due to incorrect variable ([#1616](#1616)) ([492a439](492a439))

### Features

* **ads:** use ad sizes from plugin ([#1577](#1577)) ([d238b08](d238b08))
* **donations-stripe:** integrate w/ woocommerce-memberships ([#1599](#1599)) ([807e224](807e224))
* **setup:** notice on Setup wizard after setup completed ([#1610](#1610)) ([22d6b1c](22d6b1c)), closes [#1561](#1561)
* **starter-content:** add excerpt & subtitle ([36c4452](36c4452)), closes [#514](#514)
* update debug mode notice style and position ([#1605](#1605)) ([b28075c](b28075c))
* **woocommerce:** hide setup task list ([#1615](#1615)) ([78854e8](78854e8)), closes [#1156](#1156)
@matticbot
Copy link
Contributor

🎉 This issue has been resolved in version 1.82.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this issue May 3, 2022
@semantic-release-bot
chore(release): 1.82.0 [skip ci]
1547282 
# [1.82.0](v1.81.0...v1.82.0) (2022-05-03)

### Bug Fixes

* **ads:** update refresh control help text ([#1601](#1601)) ([fc70afc](fc70afc))
* crashes with autocomplete inputs in Campaigns wizard and CategoryAutocomplete ([#1609](#1609)) ([101d1d6](101d1d6))
* handle Yoast Premium as a replacement for Yoast ([#1614](#1614)) ([9a503c0](9a503c0)), closes [#298](#298)
* **popups:** improve formatting of human-readable numbers ([#1603](#1603)) ([3106f18](3106f18))
* relax capabilities required to interact with Newspack ([04eb0be](04eb0be)), closes [#543](#543)
* **salesforce:** a PHP warning on sync completion due to incorrect variable ([#1616](#1616)) ([492a439](492a439))

### Features

* **ads:** use ad sizes from plugin ([#1577](#1577)) ([d238b08](d238b08))
* **donations-stripe:** integrate w/ woocommerce-memberships ([#1599](#1599)) ([807e224](807e224))
* **setup:** notice on Setup wizard after setup completed ([#1610](#1610)) ([22d6b1c](22d6b1c)), closes [#1561](#1561)
* **starter-content:** add excerpt & subtitle ([36c4452](36c4452)), closes [#514](#514)
* update debug mode notice style and position ([#1605](#1605)) ([b28075c](b28075c))
* **woocommerce:** hide setup task list ([#1615](#1615)) ([78854e8](78854e8)), closes [#1156](#1156)
@matticbot
Copy link
Contributor

🎉 This issue has been resolved in version 1.82.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adekbadek adekbadek

Labels
[Initiative] Onboarding released on @alpha released [Type] Enhancement Improved behavior or functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(setup): display notice on Setup wizard after setup has been comp… Automattic/newspack-plugin
4 participants
@yogeshbeniwal @adekbadek @gamebits @matticbot