fix(salesforce): a PHP warning on sync completion due to incorrect variable #1616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkoo
added
[Type] Bug
adekbadek
approved these changes
Apr 18, 2022
github-actions
bot
added
[Status] Approved
matticbot
pushed a commit
that referenced
this pull request
May 2, 2022
# [1.82.0-alpha.1](v1.81.0...v1.82.0-alpha.1) (2022-05-02) ### Bug Fixes * **ads:** update refresh control help text ([#1601](#1601)) ([fc70afc](fc70afc)) * crashes with autocomplete inputs in Campaigns wizard and CategoryAutocomplete ([#1609](#1609)) ([101d1d6](101d1d6)) * handle Yoast Premium as a replacement for Yoast ([#1614](#1614)) ([9a503c0](9a503c0)), closes [#298](#298) * **popups:** improve formatting of human-readable numbers ([#1603](#1603)) ([3106f18](3106f18)) * relax capabilities required to interact with Newspack ([04eb0be](04eb0be)), closes [#543](#543) * **salesforce:** a PHP warning on sync completion due to incorrect variable ([#1616](#1616)) ([492a439](492a439)) ### Features * **ads:** use ad sizes from plugin ([#1577](#1577)) ([d238b08](d238b08)) * **donations-stripe:** integrate w/ woocommerce-memberships ([#1599](#1599)) ([807e224](807e224)) * **setup:** notice on Setup wizard after setup completed ([#1610](#1610)) ([22d6b1c](22d6b1c)), closes [#1561](#1561) * **starter-content:** add excerpt & subtitle ([36c4452](36c4452)), closes [#514](#514) * update debug mode notice style and position ([#1605](#1605)) ([b28075c](b28075c)) * **woocommerce:** hide setup task list ([#1615](#1615)) ([78854e8](78854e8)), closes [#1156](#1156)
|
🎉 This PR is included in version 1.82.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
matticbot
pushed a commit
that referenced
this pull request
May 3, 2022
# [1.82.0](v1.81.0...v1.82.0) (2022-05-03) ### Bug Fixes * **ads:** update refresh control help text ([#1601](#1601)) ([fc70afc](fc70afc)) * crashes with autocomplete inputs in Campaigns wizard and CategoryAutocomplete ([#1609](#1609)) ([101d1d6](101d1d6)) * handle Yoast Premium as a replacement for Yoast ([#1614](#1614)) ([9a503c0](9a503c0)), closes [#298](#298) * **popups:** improve formatting of human-readable numbers ([#1603](#1603)) ([3106f18](3106f18)) * relax capabilities required to interact with Newspack ([04eb0be](04eb0be)), closes [#543](#543) * **salesforce:** a PHP warning on sync completion due to incorrect variable ([#1616](#1616)) ([492a439](492a439)) ### Features * **ads:** use ad sizes from plugin ([#1577](#1577)) ([d238b08](d238b08)) * **donations-stripe:** integrate w/ woocommerce-memberships ([#1599](#1599)) ([807e224](807e224)) * **setup:** notice on Setup wizard after setup completed ([#1610](#1610)) ([22d6b1c](22d6b1c)), closes [#1561](#1561) * **starter-content:** add excerpt & subtitle ([36c4452](36c4452)), closes [#514](#514) * update debug mode notice style and position ([#1605](#1605)) ([b28075c](b28075c)) * **woocommerce:** hide setup task list ([#1615](#1615)) ([78854e8](78854e8)), closes [#1156](#1156)
|
🎉 This PR is included in version 1.82.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Fixes a PHP warning on successful Salesforce sync due to an incorrectly named variable that was also causing some post meta to not be saved.
How to test the changes in this Pull Request:
newspack_salesforce_opportunitiespost meta (via WP CLI:wp post meta list <order ID>.Other information: