Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(setup): display notice on Setup wizard after setup has been comp… #1610

Merged
merged 2 commits into from
Apr 18, 2022

Conversation

adekbadek
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

Closes #1561

How to test the changes in this Pull Request:

  1. Remove the 'newspack_setup_complete' option
  2. Visit the Setup wizard, observe that there's no notice above the wizard
  3. Complete the setup by clicking "Finish" on the last step (or update the option value in the DB)
  4. Visit the Setup wizard, observe a notice about the setup having been completed

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@adekbadek adekbadek added the [Status] Needs Review The issue or pull request needs to be reviewed label Apr 14, 2022
@adekbadek adekbadek requested a review from a team as a code owner April 14, 2022 16:20
Copy link
Contributor

@dkoo dkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described, but there's an odd bit of space above the notice that I think we could get rid of:

Screen Shot 2022-04-14 at 3 39 04 PM

@adekbadek
Copy link
Member Author

Huh, missed that! Fixed in 1df61b1

@adekbadek adekbadek requested a review from dkoo April 15, 2022 08:42
Copy link
Contributor

@dkoo dkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Apr 15, 2022
@adekbadek adekbadek merged commit 22d6b1c into master Apr 18, 2022
@adekbadek adekbadek deleted the add/after-setup-notice branch April 18, 2022 08:34
matticbot pushed a commit that referenced this pull request May 2, 2022
# [1.82.0-alpha.1](v1.81.0...v1.82.0-alpha.1) (2022-05-02)

### Bug Fixes

* **ads:** update refresh control help text ([#1601](#1601)) ([fc70afc](fc70afc))
* crashes with autocomplete inputs in Campaigns wizard and CategoryAutocomplete ([#1609](#1609)) ([101d1d6](101d1d6))
* handle Yoast Premium as a replacement for Yoast ([#1614](#1614)) ([9a503c0](9a503c0)), closes [#298](#298)
* **popups:** improve formatting of human-readable numbers ([#1603](#1603)) ([3106f18](3106f18))
* relax capabilities required to interact with Newspack ([04eb0be](04eb0be)), closes [#543](#543)
* **salesforce:** a PHP warning on sync completion due to incorrect variable ([#1616](#1616)) ([492a439](492a439))

### Features

* **ads:** use ad sizes from plugin ([#1577](#1577)) ([d238b08](d238b08))
* **donations-stripe:** integrate w/ woocommerce-memberships ([#1599](#1599)) ([807e224](807e224))
* **setup:** notice on Setup wizard after setup completed ([#1610](#1610)) ([22d6b1c](22d6b1c)), closes [#1561](#1561)
* **starter-content:** add excerpt & subtitle ([36c4452](36c4452)), closes [#514](#514)
* update debug mode notice style and position ([#1605](#1605)) ([b28075c](b28075c))
* **woocommerce:** hide setup task list ([#1615](#1615)) ([78854e8](78854e8)), closes [#1156](#1156)
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.82.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request May 3, 2022
# [1.82.0](v1.81.0...v1.82.0) (2022-05-03)

### Bug Fixes

* **ads:** update refresh control help text ([#1601](#1601)) ([fc70afc](fc70afc))
* crashes with autocomplete inputs in Campaigns wizard and CategoryAutocomplete ([#1609](#1609)) ([101d1d6](101d1d6))
* handle Yoast Premium as a replacement for Yoast ([#1614](#1614)) ([9a503c0](9a503c0)), closes [#298](#298)
* **popups:** improve formatting of human-readable numbers ([#1603](#1603)) ([3106f18](3106f18))
* relax capabilities required to interact with Newspack ([04eb0be](04eb0be)), closes [#543](#543)
* **salesforce:** a PHP warning on sync completion due to incorrect variable ([#1616](#1616)) ([492a439](492a439))

### Features

* **ads:** use ad sizes from plugin ([#1577](#1577)) ([d238b08](d238b08))
* **donations-stripe:** integrate w/ woocommerce-memberships ([#1599](#1599)) ([807e224](807e224))
* **setup:** notice on Setup wizard after setup completed ([#1610](#1610)) ([22d6b1c](22d6b1c)), closes [#1561](#1561)
* **starter-content:** add excerpt & subtitle ([36c4452](36c4452)), closes [#514](#514)
* update debug mode notice style and position ([#1605](#1605)) ([b28075c](b28075c))
* **woocommerce:** hide setup task list ([#1615](#1615)) ([78854e8](78854e8)), closes [#1156](#1156)
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.82.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @alpha released [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Onboarding: Setup tool should be inaccessible after being completed
3 participants