Add function app config to latest Web API #27358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to Merge✅ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM). |
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| CommonDefinitions.json | 2023-12-01(a1af2b4) | 2023-01-01(main) |
| WebApps.json | 2023-12-01(a1af2b4) | 2023-01-01(main) |
️️✔️LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️❌SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
Francisco-Gamino
changed the title
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
Francisco-Gamino
removed
WaitForARMFeedback
AzureRestAPISpecReview
added
the
WaitForARMFeedback
This was referenced Jan 11, 2024
[AutoPR Az.web.DefaultTag] Add function app config to latest Web API
azure-sdk/azure-powershell#5386
Closed
|
@Francisco-Gamino This is an unreleased API, correct? |
|
There are a bunch of breaking change and model validation issues. Model Validation issues need to be fixed, no matter where they are from. Are the breaking changes from your changes, or the other changes in your development branch? |
| "properties": { | ||
| "type": { | ||
| "description": "Property to select Azure Storage Type. Available option: blobContainer.", | ||
| "type": "string" |
There was a problem hiding this comment.
is the implication that this is an enum? What are all the valid values, if not?
There was a problem hiding this comment.
Currently, we only plan to support blobContainer. However, we might support other types in the future. Based on this, should this still be an enum?
There was a problem hiding this comment.
Updated deployment storage type to be an enum.
specification/web/resource-manager/Microsoft.Web/stable/2023-12-01/CommonDefinitions.json
Outdated
Show resolved
Hide resolved
specification/web/resource-manager/Microsoft.Web/stable/2023-12-01/CommonDefinitions.json
Show resolved
Hide resolved
specification/web/resource-manager/Microsoft.Web/stable/2023-12-01/CommonDefinitions.json
Show resolved
Hide resolved
specification/web/resource-manager/Microsoft.Web/stable/2023-12-01/CommonDefinitions.json
Show resolved
Hide resolved
raosuhas
reviewed
Jan 24, 2024
specification/web/resource-manager/Microsoft.Web/stable/2023-12-01/CommonDefinitions.json
Show resolved
Hide resolved
raosuhas
added
the
ARMChangesRequested
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
6 tasks
raosuhas
added
the
ARMSignedOff
openapi-workflow-bot
bot
removed
the
ARMChangesRequested
nzthiago
reviewed
Jan 30, 2024
| @@ -0,0 +1,378 @@ | |||
| { | |||
| "parameters": { | |||
There was a problem hiding this comment.
This file seems to include all that can be possibly set for a function app regardless of SKU. Is that how it's meant to be? It'd be great to have a separate file specific for Flex Consumption that shows only what's posssible and won't be blocked for a FC app. For example: this sample has both LinuxFxVersion and a bunch of app settings, has the "Reserved" setting and others, etc. Not sure who looks at this sample but just calling it out
There was a problem hiding this comment.
I have updated the example to make it Flex Consumption specific.
@davidmrdavid @nzthiago -- Could you please take another look? Thank you.
nzthiago
approved these changes
Feb 1, 2024
nzthiago
suggested changes
Feb 2, 2024
| "version": "3.11" | ||
| }, | ||
| "scaleAndConcurrency": { | ||
| "alwaysReady": null, |
There was a problem hiding this comment.
This should not be here if it’s not required, could we delete this line?
There was a problem hiding this comment.
Good point. Fixed.
| "alwaysReady": null, | ||
| "maximumInstanceCount": 100, | ||
| "instanceMemoryMB": 2048, | ||
| "triggers": null |
There was a problem hiding this comment.
This should not be here if it’s not required, could we delete this line?
Alancere
added
the
Approved-SdkBreakingChange-Go
nzthiago
approved these changes
Feb 2, 2024
davidmrdavid
approved these changes
Feb 2, 2024
naveedaz
approved these changes
Feb 3, 2024
Francisco-Gamino
merged commit 56abc43
into
Azure:release-web-2023-12-01
24 of 27 checks passed
catalinaperalta
pushed a commit
that referenced
this pull request
Apr 20, 2024
* Introduce Microsoft.Web API version 2023-12-01 (#27100) * Add VnetBackupRestoreEnabled property to the latest API Version (#27175) * changed ApproveRejectSitePrivateEndpointConnection request body to match service parameter (#27317) Co-authored-by: Xingyang Li <xingyangli@microsoft.com> * e2e encryption (#27226) Co-authored-by: Chris Rosenblatt <crosenblatt@microsoft.com> * Adding Vnet-related APIs to Swagger (#27251) * Add function app config to latest Web API (#27358) * Add functionAppConfig definition * Add create or update function app Flex Consumption example * Add create or update function app Flex Consumption with details example * Update CommonDefinitions.json to reference the new examples * Make PUT/PATCH api async for function on aca (#27612) * Make PUT/PATCH api async for function on aca * Remove response body * update examples * Add headers --------- Co-authored-by: Vishal Gupta <vishgupta@microsoft.com> * Add FlexConsumption to the list of supported skus (#27951) * Add TLS1.3 to valid TLS Versions (#27885) Authored-by: Chris Rosenblatt <crosenblatt@microsoft.com>. I'm completing this since it was asked for and Chris is OOF atm * Added Linux SiteContainer APIs (#27942) * Added Linux SiteContainer APIs * Resolved validation failures. * Added SiteContainer and SiteContainerCollection * Fixed LintDiff errors * Fixed spellings * Updated params order. * Resolving comments. * Resolving comments. * Added volumeMounts and envVariables. * Resolving comments * Resolving comments * Removed type and metadata. * Haochidu/release web 2023 12 01/aseregion hotfix (#28018) * Update ResourceProvider.json hot fix API will return with the correct body but also with a nextLink with a URL instead of just null. I did a little more research and it seems like since my API does not return next links I think the fix should just be set the nextlinkname to null in the swagger specification. * Update ResourceProvider.json * Revert "Adding Vnet-related APIs to Swagger (#27251)" (#28249) This reverts commit 0765e9d. * Add DnsConfiguration site property to Microsoft.Web API Specs (#27378) * Add DnsConfiguration property to WebApps.json * Add SiteDnsConfig to CommonDefinitions.json * Updated dnslegacy property description * Update CommonDefinitions.json * Undo previous update to CommonDefinitions.json * Update CommonDefinitions.json: added readonly: true for dnsLegacySortOrder * Add AzureStorageProtocol field to AzureStorageInfoValue definition. (#28289) Co-authored-by: Amber Renton <amberrenton@microsoft.com> * Update create function app examples for Flex Consumption (#28566) * Revert "Make PUT/PATCH api async for function on aca (#27612)" (#28568) This reverts commit cd214ae. * Revert "Haochidu/release web 2023 12 01/aseregion hotfix (#28018)" (#28738) This reverts commit ec1d84f. * create sdk-suppression.yaml (#28751) * create sdk-suppression.yaml * add azure-sdk-for-go suppression --------- Co-authored-by: Alancere <804873052@qq.com> --------- Co-authored-by: Ashok Kumar Karasala <106590066+vkarasala@users.noreply.github.com> Co-authored-by: xingyangli1278 <xingyangli1278@gmail.com> Co-authored-by: Xingyang Li <xingyangli@microsoft.com> Co-authored-by: Chris Rosenblatt <rosench13@gmail.com> Co-authored-by: Chris Rosenblatt <crosenblatt@microsoft.com> Co-authored-by: hdmimsft <137456285+hdmimsft@users.noreply.github.com> Co-authored-by: Francisco Gamino <Francisco-Gamino@users.noreply.github.com> Co-authored-by: Vishal Gupta <vishalgupta7991@gmail.com> Co-authored-by: Vishal Gupta <vishgupta@microsoft.com> Co-authored-by: DJagwani <122347490+DJagwani@users.noreply.github.com> Co-authored-by: Haochi <136372741+ha0ch1@users.noreply.github.com> Co-authored-by: tbhartia <149726222+tbhartia@users.noreply.github.com> Co-authored-by: Amber Renton <136374263+amberrenton@users.noreply.github.com> Co-authored-by: Amber Renton <amberrenton@microsoft.com> Co-authored-by: jocawtho <jocawtho@microsoft.com> Co-authored-by: ZiWei Chen <98569699+kazrael2119@users.noreply.github.com> Co-authored-by: Alancere <804873052@qq.com>
rkmanda
pushed a commit
that referenced
this pull request
Apr 20, 2024
* Introduce Microsoft.Web API version 2023-12-01 (#27100) * Add VnetBackupRestoreEnabled property to the latest API Version (#27175) * changed ApproveRejectSitePrivateEndpointConnection request body to match service parameter (#27317) Co-authored-by: Xingyang Li <xingyangli@microsoft.com> * e2e encryption (#27226) Co-authored-by: Chris Rosenblatt <crosenblatt@microsoft.com> * Adding Vnet-related APIs to Swagger (#27251) * Add function app config to latest Web API (#27358) * Add functionAppConfig definition * Add create or update function app Flex Consumption example * Add create or update function app Flex Consumption with details example * Update CommonDefinitions.json to reference the new examples * Make PUT/PATCH api async for function on aca (#27612) * Make PUT/PATCH api async for function on aca * Remove response body * update examples * Add headers --------- Co-authored-by: Vishal Gupta <vishgupta@microsoft.com> * Add FlexConsumption to the list of supported skus (#27951) * Add TLS1.3 to valid TLS Versions (#27885) Authored-by: Chris Rosenblatt <crosenblatt@microsoft.com>. I'm completing this since it was asked for and Chris is OOF atm * Added Linux SiteContainer APIs (#27942) * Added Linux SiteContainer APIs * Resolved validation failures. * Added SiteContainer and SiteContainerCollection * Fixed LintDiff errors * Fixed spellings * Updated params order. * Resolving comments. * Resolving comments. * Added volumeMounts and envVariables. * Resolving comments * Resolving comments * Removed type and metadata. * Haochidu/release web 2023 12 01/aseregion hotfix (#28018) * Update ResourceProvider.json hot fix API will return with the correct body but also with a nextLink with a URL instead of just null. I did a little more research and it seems like since my API does not return next links I think the fix should just be set the nextlinkname to null in the swagger specification. * Update ResourceProvider.json * Revert "Adding Vnet-related APIs to Swagger (#27251)" (#28249) This reverts commit 0765e9d. * Add DnsConfiguration site property to Microsoft.Web API Specs (#27378) * Add DnsConfiguration property to WebApps.json * Add SiteDnsConfig to CommonDefinitions.json * Updated dnslegacy property description * Update CommonDefinitions.json * Undo previous update to CommonDefinitions.json * Update CommonDefinitions.json: added readonly: true for dnsLegacySortOrder * Add AzureStorageProtocol field to AzureStorageInfoValue definition. (#28289) Co-authored-by: Amber Renton <amberrenton@microsoft.com> * Update create function app examples for Flex Consumption (#28566) * Revert "Make PUT/PATCH api async for function on aca (#27612)" (#28568) This reverts commit cd214ae. * Revert "Haochidu/release web 2023 12 01/aseregion hotfix (#28018)" (#28738) This reverts commit ec1d84f. * create sdk-suppression.yaml (#28751) * create sdk-suppression.yaml * add azure-sdk-for-go suppression --------- Co-authored-by: Alancere <804873052@qq.com> --------- Co-authored-by: Ashok Kumar Karasala <106590066+vkarasala@users.noreply.github.com> Co-authored-by: xingyangli1278 <xingyangli1278@gmail.com> Co-authored-by: Xingyang Li <xingyangli@microsoft.com> Co-authored-by: Chris Rosenblatt <rosench13@gmail.com> Co-authored-by: Chris Rosenblatt <crosenblatt@microsoft.com> Co-authored-by: hdmimsft <137456285+hdmimsft@users.noreply.github.com> Co-authored-by: Francisco Gamino <Francisco-Gamino@users.noreply.github.com> Co-authored-by: Vishal Gupta <vishalgupta7991@gmail.com> Co-authored-by: Vishal Gupta <vishgupta@microsoft.com> Co-authored-by: DJagwani <122347490+DJagwani@users.noreply.github.com> Co-authored-by: Haochi <136372741+ha0ch1@users.noreply.github.com> Co-authored-by: tbhartia <149726222+tbhartia@users.noreply.github.com> Co-authored-by: Amber Renton <136374263+amberrenton@users.noreply.github.com> Co-authored-by: Amber Renton <amberrenton@microsoft.com> Co-authored-by: jocawtho <jocawtho@microsoft.com> Co-authored-by: ZiWei Chen <98569699+kazrael2119@users.noreply.github.com> Co-authored-by: Alancere <804873052@qq.com>
7 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
PR Description
This PR contains the following changes:
functionAppConfigdefinitionCreateOrUpdateFunctionApp.jsonexamplePR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Click here to see the details of Step 1
Breaking changes review (Diagram Step 1)
If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:
Such claims must be reviewed, and the process is the same.
Click here to see the details of Step 2
ARM API changes review (Diagram Step 2)
ARMReviewlabel.Click here to see the diagram footnotes
Diagram footnotes
[1] ARM review queue (for merge queues, see [2])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label
ARMChangesRequestedis removed from your PR. This should cause the label
WaitForARMFeedbackto be added.[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
If you need further help with anything, see
Getting helpsection below.Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the Diagram Step 2, "ARM API changes Review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
Getting help
Purpose of this PRandDue diligence checklist.Next Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.