-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Make PUT/PATCH api async for function on aca (#27612)" #28568
Revert "Make PUT/PATCH api async for function on aca (#27612)" #28568
Conversation
Next Steps to MergeNext steps that must be taken to merge this PR:
|
Swagger Validation Report
|
Compared specs (v0.10.7) | new version | base version |
---|---|---|
WebApps.json | 2023-12-01(742b86c) | 2023-01-01(main) |
️🔄
LintDiff inProgress [Detail]
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️❌
SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️
Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
@rkmanda can you please help review and merge this PR? |
This reverts commit cd214ae.
Hi @krisnaray , @mentat9 , @visingla-ms can you please help with this review, as this is just a revert of the previous PR we merged which you helped review. This has been up for 8 days without any activity, and it's blocking our new api-version PR |
All the changes in this PR are of existing swagger, we're not introducing any new changes.. (because it's a revert of a previous PR which was merged few weeks ago). So, failing checks are not applicable. |
0db58f3
into
Azure:release-web-2023-12-01
* Introduce Microsoft.Web API version 2023-12-01 (#27100) * Add VnetBackupRestoreEnabled property to the latest API Version (#27175) * changed ApproveRejectSitePrivateEndpointConnection request body to match service parameter (#27317) Co-authored-by: Xingyang Li <xingyangli@microsoft.com> * e2e encryption (#27226) Co-authored-by: Chris Rosenblatt <crosenblatt@microsoft.com> * Adding Vnet-related APIs to Swagger (#27251) * Add function app config to latest Web API (#27358) * Add functionAppConfig definition * Add create or update function app Flex Consumption example * Add create or update function app Flex Consumption with details example * Update CommonDefinitions.json to reference the new examples * Make PUT/PATCH api async for function on aca (#27612) * Make PUT/PATCH api async for function on aca * Remove response body * update examples * Add headers --------- Co-authored-by: Vishal Gupta <vishgupta@microsoft.com> * Add FlexConsumption to the list of supported skus (#27951) * Add TLS1.3 to valid TLS Versions (#27885) Authored-by: Chris Rosenblatt <crosenblatt@microsoft.com>. I'm completing this since it was asked for and Chris is OOF atm * Added Linux SiteContainer APIs (#27942) * Added Linux SiteContainer APIs * Resolved validation failures. * Added SiteContainer and SiteContainerCollection * Fixed LintDiff errors * Fixed spellings * Updated params order. * Resolving comments. * Resolving comments. * Added volumeMounts and envVariables. * Resolving comments * Resolving comments * Removed type and metadata. * Haochidu/release web 2023 12 01/aseregion hotfix (#28018) * Update ResourceProvider.json hot fix API will return with the correct body but also with a nextLink with a URL instead of just null. I did a little more research and it seems like since my API does not return next links I think the fix should just be set the nextlinkname to null in the swagger specification. * Update ResourceProvider.json * Revert "Adding Vnet-related APIs to Swagger (#27251)" (#28249) This reverts commit 0765e9d. * Add DnsConfiguration site property to Microsoft.Web API Specs (#27378) * Add DnsConfiguration property to WebApps.json * Add SiteDnsConfig to CommonDefinitions.json * Updated dnslegacy property description * Update CommonDefinitions.json * Undo previous update to CommonDefinitions.json * Update CommonDefinitions.json: added readonly: true for dnsLegacySortOrder * Add AzureStorageProtocol field to AzureStorageInfoValue definition. (#28289) Co-authored-by: Amber Renton <amberrenton@microsoft.com> * Update create function app examples for Flex Consumption (#28566) * Revert "Make PUT/PATCH api async for function on aca (#27612)" (#28568) This reverts commit cd214ae. * Revert "Haochidu/release web 2023 12 01/aseregion hotfix (#28018)" (#28738) This reverts commit ec1d84f. * create sdk-suppression.yaml (#28751) * create sdk-suppression.yaml * add azure-sdk-for-go suppression --------- Co-authored-by: Alancere <804873052@qq.com> --------- Co-authored-by: Ashok Kumar Karasala <106590066+vkarasala@users.noreply.github.com> Co-authored-by: xingyangli1278 <xingyangli1278@gmail.com> Co-authored-by: Xingyang Li <xingyangli@microsoft.com> Co-authored-by: Chris Rosenblatt <rosench13@gmail.com> Co-authored-by: Chris Rosenblatt <crosenblatt@microsoft.com> Co-authored-by: hdmimsft <137456285+hdmimsft@users.noreply.github.com> Co-authored-by: Francisco Gamino <Francisco-Gamino@users.noreply.github.com> Co-authored-by: Vishal Gupta <vishalgupta7991@gmail.com> Co-authored-by: Vishal Gupta <vishgupta@microsoft.com> Co-authored-by: DJagwani <122347490+DJagwani@users.noreply.github.com> Co-authored-by: Haochi <136372741+ha0ch1@users.noreply.github.com> Co-authored-by: tbhartia <149726222+tbhartia@users.noreply.github.com> Co-authored-by: Amber Renton <136374263+amberrenton@users.noreply.github.com> Co-authored-by: Amber Renton <amberrenton@microsoft.com> Co-authored-by: jocawtho <jocawtho@microsoft.com> Co-authored-by: ZiWei Chen <98569699+kazrael2119@users.noreply.github.com> Co-authored-by: Alancere <804873052@qq.com>
* Introduce Microsoft.Web API version 2023-12-01 (#27100) * Add VnetBackupRestoreEnabled property to the latest API Version (#27175) * changed ApproveRejectSitePrivateEndpointConnection request body to match service parameter (#27317) Co-authored-by: Xingyang Li <xingyangli@microsoft.com> * e2e encryption (#27226) Co-authored-by: Chris Rosenblatt <crosenblatt@microsoft.com> * Adding Vnet-related APIs to Swagger (#27251) * Add function app config to latest Web API (#27358) * Add functionAppConfig definition * Add create or update function app Flex Consumption example * Add create or update function app Flex Consumption with details example * Update CommonDefinitions.json to reference the new examples * Make PUT/PATCH api async for function on aca (#27612) * Make PUT/PATCH api async for function on aca * Remove response body * update examples * Add headers --------- Co-authored-by: Vishal Gupta <vishgupta@microsoft.com> * Add FlexConsumption to the list of supported skus (#27951) * Add TLS1.3 to valid TLS Versions (#27885) Authored-by: Chris Rosenblatt <crosenblatt@microsoft.com>. I'm completing this since it was asked for and Chris is OOF atm * Added Linux SiteContainer APIs (#27942) * Added Linux SiteContainer APIs * Resolved validation failures. * Added SiteContainer and SiteContainerCollection * Fixed LintDiff errors * Fixed spellings * Updated params order. * Resolving comments. * Resolving comments. * Added volumeMounts and envVariables. * Resolving comments * Resolving comments * Removed type and metadata. * Haochidu/release web 2023 12 01/aseregion hotfix (#28018) * Update ResourceProvider.json hot fix API will return with the correct body but also with a nextLink with a URL instead of just null. I did a little more research and it seems like since my API does not return next links I think the fix should just be set the nextlinkname to null in the swagger specification. * Update ResourceProvider.json * Revert "Adding Vnet-related APIs to Swagger (#27251)" (#28249) This reverts commit 0765e9d. * Add DnsConfiguration site property to Microsoft.Web API Specs (#27378) * Add DnsConfiguration property to WebApps.json * Add SiteDnsConfig to CommonDefinitions.json * Updated dnslegacy property description * Update CommonDefinitions.json * Undo previous update to CommonDefinitions.json * Update CommonDefinitions.json: added readonly: true for dnsLegacySortOrder * Add AzureStorageProtocol field to AzureStorageInfoValue definition. (#28289) Co-authored-by: Amber Renton <amberrenton@microsoft.com> * Update create function app examples for Flex Consumption (#28566) * Revert "Make PUT/PATCH api async for function on aca (#27612)" (#28568) This reverts commit cd214ae. * Revert "Haochidu/release web 2023 12 01/aseregion hotfix (#28018)" (#28738) This reverts commit ec1d84f. * create sdk-suppression.yaml (#28751) * create sdk-suppression.yaml * add azure-sdk-for-go suppression --------- Co-authored-by: Alancere <804873052@qq.com> --------- Co-authored-by: Ashok Kumar Karasala <106590066+vkarasala@users.noreply.github.com> Co-authored-by: xingyangli1278 <xingyangli1278@gmail.com> Co-authored-by: Xingyang Li <xingyangli@microsoft.com> Co-authored-by: Chris Rosenblatt <rosench13@gmail.com> Co-authored-by: Chris Rosenblatt <crosenblatt@microsoft.com> Co-authored-by: hdmimsft <137456285+hdmimsft@users.noreply.github.com> Co-authored-by: Francisco Gamino <Francisco-Gamino@users.noreply.github.com> Co-authored-by: Vishal Gupta <vishalgupta7991@gmail.com> Co-authored-by: Vishal Gupta <vishgupta@microsoft.com> Co-authored-by: DJagwani <122347490+DJagwani@users.noreply.github.com> Co-authored-by: Haochi <136372741+ha0ch1@users.noreply.github.com> Co-authored-by: tbhartia <149726222+tbhartia@users.noreply.github.com> Co-authored-by: Amber Renton <136374263+amberrenton@users.noreply.github.com> Co-authored-by: Amber Renton <amberrenton@microsoft.com> Co-authored-by: jocawtho <jocawtho@microsoft.com> Co-authored-by: ZiWei Chen <98569699+kazrael2119@users.noreply.github.com> Co-authored-by: Alancere <804873052@qq.com>
This reverts commit cd214ae.
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting help
section at the bottom of this PR description.Note
As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Click here to see the details of Step 1, Breaking Changes review
If you are in purview of Step 1 of the diagram, follow the Breaking Changes review process.
IMPORTANT! This applies even if you believe your PR was mislabeled, for any reason, including tool failure.
Click here to see the details of Step 2, ARM review
See https://aka.ms/azsdk/pr-arm-review.
Click here to see the diagram footnotes
Diagram footnotes
[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PR
andDue diligence checklist
.Next Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.